From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E94C2B9F4 for ; Mon, 14 Jun 2021 14:12:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52F9261206 for ; Mon, 14 Jun 2021 14:12:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F9261206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ieWX6dJfiRrLsFHgzuAplWUpWz+XINOvbaLafWSeUe8=; b=MPRFK/7qMlqnOd JwJo45Xie+pEc7gDLlzfch6CX4scRmAhyrXStxtCzCY4J+R34Xo718ZdagJBwQRpYv2JpOAvCETdQ J1VuRBXoJk93zIKRvHFA0C4IIBNQd/eLQmpsSIBizj0nT9omv9usbpmSP5xDAwgMYsiW3pdg3TXp6 RuH4vet99IdIlK0oUUbsVBg4I8837qnjADmm29iJrOa7DxTAGynyYKLUQBFYpISPc9L5ZwWLzXuWp nUOhLgS3L8vgnSZ99laWLvoQh+XtQDICLVWFinzlnBirI/czhr/SEgjFzjcVTSdy/UL+42f/dP5/Q Hm97E1SylAc2KFEaY9GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnIe-00EShk-Qe; Mon, 14 Jun 2021 14:10:49 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnIb-00ESgC-5z for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 14:10:46 +0000 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4G3Y5H5SsYz6G8p9; Mon, 14 Jun 2021 22:01:07 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 16:10:42 +0200 Received: from localhost (10.52.124.209) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 15:10:41 +0100 Date: Mon, 14 Jun 2021 15:10:36 +0100 From: Jonathan Cameron To: Cristian Marussi CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 12/16] firmware: arm_scmi: Add message passing abstractions for transports Message-ID: <20210614151036.00000409@Huawei.com> In-Reply-To: <20210611165937.701-13-cristian.marussi@arm.com> References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-13-cristian.marussi@arm.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.124.209] X-ClientProxiedBy: lhreml727-chm.china.huawei.com (10.201.108.78) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_071045_439018_A99D8024 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Jun 2021 17:59:33 +0100 Cristian Marussi wrote: > From: Peter Hilber > > Add abstractions for future transports using message passing, such as > virtio. Derive the abstractions from the shared memory abstractions. > > Abstract the transport SDU through the opaque struct scmi_msg_payld. > Also enable the transport to determine all other required information > about the transport SDU. > > Signed-off-by: Peter Hilber > --- ... > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index b783ae058c8a..fa4075336580 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -410,6 +410,21 @@ void shmem_clear_channel(struct scmi_shared_mem __iomem *shmem); > bool shmem_poll_done(struct scmi_shared_mem __iomem *shmem, > struct scmi_xfer *xfer); > > +/* declarations for message passing transports */ > +struct scmi_msg_payld; > + > +/** Maximum overhead of message w.r.t. struct scmi_desc.max_msg_size */ Doesn't look to be kernel-doc.. > +#define SCMI_MSG_MAX_PROT_OVERHEAD (2 * sizeof(__le32)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel