From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B987C48BDF for ; Tue, 15 Jun 2021 22:09:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D18F1610EA for ; Tue, 15 Jun 2021 22:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D18F1610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vkQqDFjCbzJSkrfQmdqqizxU4Cglc9IcvZ+nZXui1ME=; b=IzA6aYATMcSVDv zOzmdpxCGU3uG6387L4W6jpKUBBDduSVuchYwspPMATsj1anP3s76pEzYMzCSfjVH5XPaUtfBdmZP 3uHG7ZvDHCdc+Elj5SOk0G+nVnKnnjeRYC14+TsUEDKi7K95VbqelnKvK5EH6Umihw34A8nqjqvds ths5vktMiQ96II8bwEihNoPjgv1cjeyRb12MJs6aj4oDCW+Ks5CEK1HADrAJWFXsjK51Df2lFO3ah SZNV3mfF8fS4wFwqQxdhGaJyzR1s7Lj3eUqfT/JPBW/0g2v1d0oBLCAsuaZjyhobaEx0rJ/2nKnpd vbPGm44eVuRm8BqBoVKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltHDy-003Qtg-3q; Tue, 15 Jun 2021 22:07:59 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEW3-002MVm-5N; Tue, 15 Jun 2021 19:14:28 +0000 Received: by mail-pl1-x62c.google.com with SMTP id v12so8965493plo.10; Tue, 15 Jun 2021 12:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K96NEhRwOfOsQAPRB6OZS+5qrNhl6I/oCeCqkJvi258=; b=qqZc2Uh2ZSIzSDA25Ys4zEG506SaSOwt57+BYQxVx/T6xa/17qGN5X4LRAR++F1oEo mhKz0nqRJrVl4OLbSn2pQI3Tq9Hx5Q+uzsXKjny4hbYpttchuB/iQBbJT98LRGoyvOCy XQuzNbLm16MVFZkxuHdKFD5p3V7SP4SPFIHvgqNhJBUfokWXFPKk5jcvC86GnBvNh62h Yt00xKCIGpDKTZ3ro1VpQM9resKlcM2hjAIB4Mo9fh24aglQGiUHkeY6HxbX0LoCJzGV cQlzanM1Lp4xDaA/m8SZN41i3FjJ2jGjMonXq9ZWwCYyWfiI3DWXLnRusY20j/nxW+Pe 9BEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K96NEhRwOfOsQAPRB6OZS+5qrNhl6I/oCeCqkJvi258=; b=io0dJhCWoa0X6i4t5Bl6RW+adaiii2UgzuaSkWVWL++PFNA3kFPtQtVMALl2eTC12b tWya7vgGaDfOISxJwhMPo1rwdbSpgOddGDjK6i0yPqNoXlc2Ft9+KUpcJ+73xz3ZAb4d siyWzJTejvrcO0I0jIjYYFi4ZzaWDmuJXxU1zHB30l866o8Q3k0yP89H974229shSaY8 BJW3bzmlT8WyTDvJsO8WYaVXvfu+scbNGA05tIGRICcYBOnss/7y3CaIRASKS+RHgQZV UjEZYPZURh/NL/0ryQK2o/BHCqHrRX4i31aTVxqLCzQ9l+gqRlJGtAuUaTfaD4a/SvRo fUlQ== X-Gm-Message-State: AOAM533LBeJ9l44c1BqrJqFNITzVbIjXs66tq7bztcAVV2xuvLvjfI7k yC6GsjyZpqC0o5sXQqsSwelLQ5+bVm9ijw== X-Google-Smtp-Source: ABdhPJzBXgY2YbgSAgc0sRNfpuHgDCWRry9ogh+YjFBZ+/hwygS7W27RAZZaG8TlduIafjPsxMKlZg== X-Received: by 2002:a17:90a:5401:: with SMTP id z1mr740025pjh.7.1623784465930; Tue, 15 Jun 2021 12:14:25 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id j4sm3165008pjv.7.2021.06.15.12.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 12:14:25 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Jim Quinlan , Nicolas Saenz Julienne , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Florian Fainelli , Jim Quinlan , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/3] PCI: brcmstb: Check return value of clk_prepare_enable() Date: Tue, 15 Jun 2021 15:14:02 -0400 Message-Id: <20210615191405.21878-2-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210615191405.21878-1-jim2101024@gmail.com> References: <20210615191405.21878-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_121427_280003_81155311 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Check for failure of clk_prepare_enable() on device resume. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Fixes: 8195b7417018 ("PCI: brcmstb: Add suspend and resume pm_ops") --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 08bc788d9422..abc62a86d94e 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1162,7 +1162,9 @@ static int brcm_pcie_resume(struct device *dev) int ret; base = pcie->base; - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = reset_control_reset(pcie->rescal); if (ret) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel