From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F9EC2B9F4 for ; Tue, 22 Jun 2021 11:08:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8089361352 for ; Tue, 22 Jun 2021 11:08:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8089361352 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6VpiHL4EUwcfycEN/4n0LSfb0iP8RG8tiiqEx+aVYGQ=; b=RMhdBU7mmht/T9 0mre/LX9JyEq920sjQpVvkinnZ/8CNBQuyIZVPHrc8AzQ6BNJQTfybZJiJ6Acpt+LZYGfT8yPN0it bAgK61yexwJrhAdYckVtAxgOsQicP9lHGi74v0yX1wnw0/lBzumHwjNfefxYDvJJhj2mOY8j9mvXL gcNELMZEdtedmxgwpDtPWCalWb6pnMFd9TUFqhzYwFpGOwYKEDpN+Md9KYBu9A/RicGTQV+iL24KL goIC55KcM7B+sqfruajIbqC078ls/mTp2vCXSo3ZFmJoYdiSK3CAIw3eynQaP11JmnGpELd5R655y WwKZKgy+ov20NoA70Sig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lveEn-006r4o-OG; Tue, 22 Jun 2021 11:06:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lveEh-006r2R-5m for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 11:06:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0E7061351; Tue, 22 Jun 2021 11:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624359990; bh=tkNOU3KSOZoUF6VdPE47mV5VaubKmE+YLjZc9m6B/WQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e/yGAqJPo7FcjH+soJIGd4rVoVpAg6ZNiOYFCpIBaTWurncNyH1Se12qE4P822dB0 qiofqU4R1B3OINcxg6n6MQ8nPu27/l7y9Tzqo3fd0OZ56m1HVtWp5GBEBt+6YZbVay PJKmINNkrCbjbueC1AJR0OMDzCwoRmgMCij5NodGHrtqYxBG0+luQhEAtoSJrrgeOu 7ziaiLhw3r45OyVs95NWyalpxMeEgT3yk2hlSTzp4xr7QdiR5sDArdi9LkhD5Fwntg NoA8dv9WEx+a5jwnc6YrFHAEWmia0i/cKTXlKW3iC/SV1oXTpEJyleCwv3CAmBRtAP pE08eZkAjrVmQ== Received: by pali.im (Postfix) id EA073889; Tue, 22 Jun 2021 13:06:27 +0200 (CEST) Date: Tue, 22 Jun 2021 13:06:27 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Luca Ceresoli Cc: Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas Subject: Re: [PATCH v2] PCI: dra7xx: Fix reset behaviour Message-ID: <20210622110627.aqzxxtf2j3uxfeyl@pali> References: <20210531090540.2663171-1-luca@lucaceresoli.net> <20210531133211.llyiq3jcfy25tmz4@pali> <8ff1c54f-bb29-1e40-8342-905e34361e1c@lucaceresoli.net> <9fdbada4-4902-cec1-f283-0d12e1d4ac64@ti.com> <20210531162242.jm73yzntzmilsvbg@pali> <8207a53c-4de9-d0e5-295a-c165e7237e36@lucaceresoli.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8207a53c-4de9-d0e5-295a-c165e7237e36@lucaceresoli.net> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_040631_293443_F4093C2A X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On Tuesday 22 June 2021 12:57:22 Luca Ceresoli wrote: > Nothing happened after a few weeks... I understand that knowing the > correct reset timings is relevant, but unfortunately I cannot help much > in finding out the correct values. > > However I'm wondering what should happen to this patch. It *does* fix a > real bug, but potentially with an incorrect or non-optimal usleep range. > Do we really want to ignore a bugfix because we are not sure about how > long this delay should be? As there is no better solution right now, I'm fine with your patch. But patch needs to be approved by Lorenzo, so please wait for his final answer. I would suggest to add a comment for call "usleep_range(1000, 2000);" that you have chosen some "random" values which worked fine on your setup and that they fix mentioned bug. Comment just to mark this sleep code that is suboptimal / not-so-correct and to prevent other people to copy+paste this code into other (new) drivers... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel