From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A627C2B9F4 for ; Fri, 25 Jun 2021 17:53:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31AF361962 for ; Fri, 25 Jun 2021 17:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31AF361962 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2DLQkpOhkfwzKAt+xTa1TUk44sqs8srtBekKMHQNLD0=; b=0lTVtudLI/3dgatKflkJdgqF2h 9iuBswdiGtsNHTUSVYZI6Ct9rdHv5kcLe85xgRMezMN+wkA0nA6Hlx4jkVXFdOMe8dspNXEtzn48t XlyrSu8ybxFDXBZL07Y/sl0H4yyEi3SqDKaL4JjqqpadMVsFNEdaCWAx7c8IVDr6OlwY1VRaFFXqq OvcHKRSHkh0zxqSFXjykZzHZ+ELgk6zhHsfdUpAvW8smHUpg8hEOIYJb0GSZIr3/M/wIXI9AFQdjx hCWfTcxkszry/ODJF6KaRWKGyyKSExwypY+nv4/f0VMjRVbCRrsumBtCP8s9Ru+ihbTjecp2tV/eh fgLekBcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwq0A-002XGz-PO; Fri, 25 Jun 2021 17:52:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwq07-002XFk-0g for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 17:52:24 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwq05-0006El-0N; Fri, 25 Jun 2021 19:52:21 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lwq03-0006cY-Ow; Fri, 25 Jun 2021 19:52:19 +0200 Date: Fri, 25 Jun 2021 19:52:19 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jitao Shi Cc: Thierry Reding , Lee Jones , Matthias Brugger , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, ck.hu@mediatek.com, stonea168@163.com, huijuan.xie@mediatek.com Subject: Re: [PATCH v5 2/3] pwm: mtk_disp: implement atomic API .apply() Message-ID: <20210625175219.ppeq4yloi76ud4jj@pengutronix.de> References: <20210616085224.157318-1-jitao.shi@mediatek.com> <20210616085224.157318-3-jitao.shi@mediatek.com> MIME-Version: 1.0 In-Reply-To: <20210616085224.157318-3-jitao.shi@mediatek.com> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_105223_105412_1870110C X-CRM114-Status: GOOD ( 22.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8355727096568872670==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8355727096568872670== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="agipn6zma3xjneoo" Content-Disposition: inline --agipn6zma3xjneoo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 16, 2021 at 04:52:23PM +0800, Jitao Shi wrote: > Switch the driver to support the .apply() method. >=20 > Signed-off-by: Jitao Shi > --- > drivers/pwm/pwm-mtk-disp.c | 69 ++++++++++---------------------------- > 1 file changed, 17 insertions(+), 52 deletions(-) >=20 > diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c > index 204d76beeb26..a4766e931b68 100644 > --- a/drivers/pwm/pwm-mtk-disp.c > +++ b/drivers/pwm/pwm-mtk-disp.c > @@ -67,14 +67,25 @@ static void mtk_disp_pwm_update_bits(struct mtk_disp_= pwm *mdp, u32 offset, > writel(value, address); > } > =20 > -static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device = *pwm, > - int duty_ns, int period_ns) > +static int mtk_disp_pwm_apply(struct pwm_chip *chip, struct pwm_device *= pwm, > + const struct pwm_state *state) > { > struct mtk_disp_pwm *mdp =3D to_mtk_disp_pwm(chip); > u32 clk_div, period, high_width, value; > u64 div, rate; > int err; > =20 Here something like: if (state->polarity !=3D PWM_POLARITY_NORMAL) return -EINVAL; is missing. > + if (!state->enabled) { > + mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask, > + 0x0); > + if (mdp->enabled) { > + clk_disable_unprepare(mdp->clk_mm); > + clk_disable_unprepare(mdp->clk_main); > + } > + mdp->enabled =3D false; > + return 0; > + } > + > if (!mdp->enabled) { > err =3D clk_prepare_enable(mdp->clk_main); > if (err < 0) { > @@ -102,7 +113,7 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip,= struct pwm_device *pwm, > * high_width =3D (PWM_CLK_RATE * duty_ns) / (10^9 * (clk_div + 1)) > */ > rate =3D clk_get_rate(mdp->clk_main); > - clk_div =3D div_u64(rate * period_ns, NSEC_PER_SEC) >> > + clk_div =3D div_u64(rate * state->period, NSEC_PER_SEC) >> This multiplication might overflow. But maybe it's sensible to address this in a separate commit to keep things simple. > PWM_PERIOD_BIT_WIDTH; > if (clk_div > PWM_CLKDIV_MAX) { > if (!mdp->enabled) { > @@ -112,11 +123,11 @@ static int mtk_disp_pwm_config(struct pwm_chip *chi= p, struct pwm_device *pwm, > return -EINVAL; > } > div =3D NSEC_PER_SEC * (clk_div + 1); > - period =3D div64_u64(rate * period_ns, div); > + period =3D div64_u64(rate * state->period, div); ditto. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --agipn6zma3xjneoo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDWF9AACgkQwfwUeK3K 7AkLdgf+It9rCnCg7lTfWTAMvXBrn6TdovPnzwlboNULBtNOkiBWAPZ/0K1as1nY hAesg/ARX8rRR9okaFU8Pv9BQ6rQ7idmLE8x4NE5oLrkAuCfg+4Azpol3t3DA7q/ rOdSMIUsyIeZjI4TlJcA70lmTwf97hFeQtj23XzZ9S4U966uCdyp+9b+g8QD+B/4 GYqbJWcbWHr0+Wwra9tYluuvYB3XwXDFN6fCWgEm1rcqZ3SwDlJiKQoWaYUdWnhA XXGUJ662Q/B5BzTSo6lj1vRYLYWRFL4KcelxiVWVnXLDesEXdCKnx4XUe8cuZuEn PIrbO9/7N863rcPZn+qYpl8+QDlcXg== =JXek -----END PGP SIGNATURE----- --agipn6zma3xjneoo-- --===============8355727096568872670== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8355727096568872670==--