Hi, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on tip/x86/mm asm-generic/master linus/master sparc/master v5.13] [cannot apply to sparc-next/master next-20210629] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/akpm-linux-foundation-org/mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-patch-removed-from-mm-tree/20210617-075958 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: sparc-defconfig (attached as .config) compiler: sparc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/490957abd94a7b67576c0029c771c6691dce1878 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review akpm-linux-foundation-org/mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-patch-removed-from-mm-tree/20210617-075958 git checkout 490957abd94a7b67576c0029c771c6691dce1878 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from arch/sparc/include/asm/pgtable.h:7, from include/linux/pgtable.h:6, from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/ftrace.h:12, from include/linux/kprobes.h:29, from include/linux/kgdb.h:19, from arch/sparc/kernel/kgdb_32.c:7: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from include/linux/pgtable.h:6, from arch/sparc/kernel/traps_32.c:21: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/kernel/traps_32.c: At top level: arch/sparc/kernel/traps_32.c:368:6: error: no previous prototype for 'trap_init' [-Werror=missing-prototypes] 368 | void trap_init(void) | ^~~~~~~~~ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from arch/sparc/include/asm/viking.h:13, from arch/sparc/include/asm/mbus.h:12, from arch/sparc/include/asm/elf_32.h:94, from arch/sparc/include/asm/elf.h:7, from include/linux/elf.h:6, from include/linux/module.h:18, from include/linux/moduleloader.h:6, from arch/sparc/kernel/module.c:8: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/kernel/module.c: In function 'module_frob_arch_sections': arch/sparc/kernel/module.c:62:8: error: variable 'strtab' set but not used [-Werror=unused-but-set-variable] 62 | char *strtab; | ^~~~~~ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from include/linux/pgtable.h:6, from include/linux/mm.h:33, from include/linux/memblock.h:13, from arch/sparc/mm/srmmu.c:14: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/mm/srmmu.c: In function 'poke_hypersparc': arch/sparc/mm/srmmu.c:1081:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable] 1081 | volatile unsigned long clear; | ^~~~~ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from include/linux/pgtable.h:6, from include/linux/mm.h:33, from arch/sparc/mm/leon_mm.c:14: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/mm/leon_mm.c: In function 'leon_swprobe': arch/sparc/mm/leon_mm.c:42:25: error: variable 'paddrbase' set but not used [-Werror=unused-but-set-variable] 42 | unsigned int lvl, pte, paddrbase; | ^~~~~~~~~ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from arch/sparc/include/asm/viking.h:13, from arch/sparc/include/asm/mbus.h:12, from arch/sparc/include/asm/elf_32.h:94, from arch/sparc/include/asm/elf.h:7, from include/linux/elf.h:6, from include/linux/module.h:18, from arch/sparc/lib/cmpdi2.c:2: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/lib/cmpdi2.c: At top level: arch/sparc/lib/cmpdi2.c:6:11: error: no previous prototype for '__cmpdi2' [-Werror=missing-prototypes] 6 | word_type __cmpdi2(long long a, long long b) | ^~~~~~~~ cc1: all warnings being treated as errors -- In file included from arch/sparc/include/asm/pgtable.h:7, from arch/sparc/include/asm/viking.h:13, from arch/sparc/include/asm/mbus.h:12, from arch/sparc/include/asm/elf_32.h:94, from arch/sparc/include/asm/elf.h:7, from include/linux/elf.h:6, from include/linux/module.h:18, from arch/sparc/lib/ucmpdi2.c:2: arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable': >> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion] 158 | return ~0; | ^ arch/sparc/lib/ucmpdi2.c: At top level: arch/sparc/lib/ucmpdi2.c:5:11: error: no previous prototype for '__ucmpdi2' [-Werror=missing-prototypes] 5 | word_type __ucmpdi2(unsigned long long a, unsigned long long b) | ^~~~~~~~~ cc1: all warnings being treated as errors vim +158 arch/sparc/include/asm/pgtable_32.h 974b9b2c68f3d3 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2020-06-08 154 490957abd94a7b arch/sparc/include/asm/pgtable_32.h Andrew Morton 2021-06-16 155 static inline pmd_t *pud_pgtable(pud_t pud) 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg 2012-05-13 156 { 7235db268a2777 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2019-12-04 157 if (srmmu_device_memory(pud_val(pud))) { 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg 2012-05-13 @158 return ~0; 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg 2012-05-13 159 } else { 7235db268a2777 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2019-12-04 160 unsigned long v = pud_val(pud) & SRMMU_PTD_PMASK; 490957abd94a7b arch/sparc/include/asm/pgtable_32.h Andrew Morton 2021-06-16 161 return (pmd_t *)__nocache_va(v << 4); 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg 2012-05-13 162 } 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg 2012-05-13 163 } f5e706ad886b6a include/asm-sparc/pgtable_32.h Sam Ravnborg 2008-07-17 164 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org