From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89C0C11F64 for ; Thu, 1 Jul 2021 10:05:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C9561468 for ; Thu, 1 Jul 2021 10:05:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99C9561468 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n+ApsjtcEm9d5BRd7w6MHAhqJGJWX1nJeLEwW+kFqg8=; b=UqF1qfryhJ7lV4 uJszxOMyfPZANwEluhiyX8lJGVVVHE2irCw8DooEEj9gZEZMZxBqUk9ZBP2Uz9epzqH/bSSmFm9wb pjhxWUhldnB6UQ8Iq69TjsCygH7vyiHfUCQSoAh3u7fV1dF4mheFJkBrNl0kXXKhhvm4Di3QfPJZj 0agrj5316AOzia2/a4YtWAv0jC68rkdT/3CYCweAB/Vpax8lkntyefaL53xuCdhqn60yU2UzJuIf5 pNCo56Gg8R0xg4UdNi+98FqF+hPnfZnjqHIKnoDUbkX5HuMWQHF66NuUBLHmxE7GTcUG+cSns7HiA 621UnVGDQBR/k9CdSNBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lytYk-00Gsa9-Ft; Thu, 01 Jul 2021 10:04:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lytYg-00GsYx-FJ for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 10:04:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88598D6E; Thu, 1 Jul 2021 03:04:29 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF90D3F718; Thu, 1 Jul 2021 03:04:25 -0700 (PDT) Date: Thu, 1 Jul 2021 11:04:19 +0100 From: Cristian Marussi To: Peter Hilber Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Message-ID: <20210701100258.GB50227@e120937-lin> References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-2-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_030434_603024_04E7CB5E X-CRM114-Status: GOOD ( 26.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On Thu, Jul 01, 2021 at 10:42:40AM +0200, Peter Hilber wrote: > Hi Cristian, > > please find some remarks to the patch series in this email and the > following. > Thanks for your comments, very much appreciated. I'll reply inline. Just to let you know, I have ready a V5 series where, beside some general cleanup and further simplification, I addressed in the SCMI core the issue that you pointed out about the possible concurrent and out-of-order response/delayed_response delivery by the transport. I've refrained from posting that on the list still, due to the merge window being open. I'll post most probably next week. (still have to see if I can also simplify probing sequence in V5...which is the last point in my list) > On 11.06.21 18:59, Cristian Marussi wrote: > > SCMI message headers carry a sequence number and such field is sized to > > allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an > > acceptable maximum number of pending in-flight messages. > > > > Fix accordignly the checks performed on the value exported by transports > > in scmi_desc.max_msg. > > > > Reported-by: Vincent Guittot > > Fixes: aa4f886f3893 ("firmware: arm_scmi: add basic driver infrastructure for SCMI") > > Signed-off-by: Cristian Marussi > > --- > > drivers/firmware/arm_scmi/driver.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > > index 66e5e694be7d..6713b259f1e6 100644 > > --- a/drivers/firmware/arm_scmi/driver.c > > +++ b/drivers/firmware/arm_scmi/driver.c > > @@ -1025,8 +1025,9 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo, > > const struct scmi_desc *desc = sinfo->desc; > > /* Pre-allocated messages, no more than what hdr.seq can support */ > > - if (WARN_ON(desc->max_msg >= MSG_TOKEN_MAX)) { > > - dev_err(dev, "Maximum message of %d exceeds supported %ld\n", > > + if (WARN_ON(!desc->max_msg || desc->max_msg > MSG_TOKEN_MAX)) { > > + dev_err(dev, > > + "Invalid max_msg %d. Maximum messages supported %ld.\n", > > %ld -> %lu > Right, I'll fix. > > desc->max_msg, MSG_TOKEN_MAX); > > return -EINVAL; > > } > > Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel