From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3735C11F64 for ; Thu, 1 Jul 2021 10:33:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4ED36148E for ; Thu, 1 Jul 2021 10:33:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4ED36148E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BQXfMRpjAUu4yxneQFOY9RxvSCef68t/aA1Lh1gRlsg=; b=pCIpHDMUpYEFM6 Upa8axRoY82ZUCN0xpW58oA2j6dNnmsEmovMHjbm86MgOA8LNEFFBLMwWMUcJAU1XIhm+qEw4aAy3 Kfg2HU8+nC75HLB834rUeadjg4cEiA7jASw4jz6xvG/1LXHVF8Z7ByQlmi8nIWzJxApIar0XumOOv 6LLxyqSRzD3Fbk86NIgbj+UdchrPEO270ArdocU3+X0tfKw8ndqj1vdo6caRjHhCjwkjj7ydzRDx4 zabWW7YvFR/SMNNdG6IHUcE/EFxgWitWuntBKxNW8T6Gd/63Yr29NSfjmysb2JKFAj5Y3qEpoWIJ0 aPfc/q0BDUfbaB8kfX/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lytz4-00GwxN-2G; Thu, 01 Jul 2021 10:31:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lytyz-00GwoY-Kr for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 10:31:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB5FCD6E; Thu, 1 Jul 2021 03:31:43 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F17473F718; Thu, 1 Jul 2021 03:31:30 -0700 (PDT) Date: Thu, 1 Jul 2021 11:31:24 +0100 From: Cristian Marussi To: Peter Hilber Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v4 13/16] dt-bindings: arm: Add virtio transport for SCMI Message-ID: <20210701103124.GD17807@e120937-lin> References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-14-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_033145_829726_6E54D327 X-CRM114-Status: GOOD ( 26.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, Jul 01, 2021 at 10:43:02AM +0200, Peter Hilber wrote: > On 11.06.21 18:59, Cristian Marussi wrote: > > From: Igor Skalkin > > > > Document the properties for arm,scmi-virtio compatible nodes. > > The backing virtio SCMI device is described in patch [1]. > > > > While doing that, make shmem property required only for pre-existing > > mailbox and smc transports, since virtio-scmi does not need it. > > > > [1] https://lists.oasis-open.org/archives/virtio-comment/202102/msg00018.html > > > > CC: Rob Herring > > CC: devicetree@vger.kernel.org > > Signed-off-by: Igor Skalkin > > [ Peter: Adapted patch for submission to upstream. ] > > Co-developed-by: Peter Hilber > > Signed-off-by: Peter Hilber > > [ Cristian: converted to yaml format, moved shmen required property. ] > > Co-developed-by: Cristian Marussi > > Signed-off-by: Cristian Marussi > > --- > > v3 --> V4 > > - convertd to YAML > > - make shmem required only for pre-existing mailbox and smc transport > > - updated VirtIO specification patch message reference > > - dropped virtio-mmio SCMI device example since really not pertinent to > > virtio-scmi dt bindings transport: it is not even referenced in SCMI > > virtio DT node since they are enumerated by VirtIO subsystem and there > > could be PCI based SCMI devices anyway. > > --- > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > index cebf6ffe70d5..5c4c6782e052 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > @@ -34,6 +34,10 @@ properties: > > - description: SCMI compliant firmware with ARM SMC/HVC transport > > items: > > - const: arm,scmi-smc > > + - description: SCMI compliant firmware with SCMI Virtio transport. > > + The virtio transport only supports a single device. > > + items: > > + - const: arm,scmi-virtio > > interrupts: > > description: > > @@ -172,6 +176,7 @@ patternProperties: > > Each sub-node represents a protocol supported. If the platform > > supports a dedicated communication channel for a particular protocol, > > then the corresponding transport properties must be present. > > + The virtio transport does not support a dedicated communication channel. > > properties: > > reg: > > @@ -195,7 +200,6 @@ patternProperties: > > required: > > - compatible > > - - shmem > > if: > > properties: > > @@ -209,6 +213,7 @@ then: > > required: > > - mboxes > > + - shmem > > else: > > if: > > @@ -219,6 +224,7 @@ else: > > then: > > required: > > - arm,smc-id > > + - shmem > > examples: > > - | > > > > Maybe a minimal example for arm,scmi-virtio could be added, such as below: > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5c4c6782e052..576faf970c1b 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -344,4 +344,19 @@ examples: > }; > }; > > + - | > + firmware { > + scmi { > + compatible = "arm,scmi-virtio"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_devpd2: protocol@11 { > + reg = <0x11>; > + #power-domain-cells = <1>; > + }; > + }; > + }; > + Not sure about this, I explicitly removed the arm,scmi-virtio example because with the current bindings it won't really exemplify anything really specific to the virtio transport if not the usage of the compatible string, and moreover the mmio case is just a case, there could be PCI based virtio SCMI device that would have even less to show here as an example. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel