From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84408C07E95 for ; Tue, 13 Jul 2021 17:08:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E8D961362 for ; Tue, 13 Jul 2021 17:08:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E8D961362 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yC9rjIN9U9k1/VV4QttYD50XLxwl7k59jvKFsTRa79k=; b=ZjJuS4yB0fJkq0 4+fD+2ZI9q2nPTkQJNv35Wv7B9i1rAEJ+SCsZELusspsNfr17i2OLrw59FKzZEucJ/ULtPb5iql5Y 6Mmek8d+8QYjln6TxXY5qLG6sRqfXHJ3tr9PcTiZ0+rHIJSYuDDiap81oilEtiZaQcsZCJmj4kJhw aLSDhvHsFMhIVfEx7OJ9hY+vauEQVq1s2p/zTmR5wsBZcmem6bBmxV1aJIOV8Zn/7vN0QYppZT978 LkFa6e7yqM0N+9KgokUyY1ivTvUgfqKxsbB5KCcJMtiRs7TbrI5Qx5dIXryGeVnI/q5wPWXrjLzTN Yp2EeKCBzFd3rtWUDcXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3Lrv-00B15u-0r; Tue, 13 Jul 2021 17:06:51 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3Lrr-00B15C-DA for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 17:06:48 +0000 Received: by mail-pg1-x52c.google.com with SMTP id y17so22145443pgf.12 for ; Tue, 13 Jul 2021 10:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QArzQ0W00D/rVP8EGx2qH04dhUL8Nmjd4SowzwPfG+E=; b=oDlv3oMGj49avEx981/x3Q1OUGWWU+RvRtSApC2aCbAq31sTbYz1HeIou9K4iufsWE FjyDDTT4n69TNlOtKh4Al0Hw4wd4dl5hYyx1v9FeHeNIfHqvoJB5V5JwUaPLHd+2/fXn C54g1GAlizqokAsgOD32uAqZxYvUwKXLQtPTIBTCqhkDB41hxFxx3LzZ1cxPkn1V+hc7 MddtRMsf3xGVdoLdXVCxSN9zhoa/Sbv8rVBoSadI1TRRKO0MV4/wamMWEN1vR7ODoEaN GEiX0NhqjsFoVHAtGeyhRV1T1yzMX1jFbuQhsyalgJ79EOo/y3jrnnvgVZroUUyw5XnO xDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QArzQ0W00D/rVP8EGx2qH04dhUL8Nmjd4SowzwPfG+E=; b=tG9Lzddxp8HNVFohHBwjGy5zvUtEjL+wMGvYseXh3pKjxNMyHr0/tSDEgdR+OuHGCi 2jDXJreX3dWrbEhhtFVxoxcGs3vn6K0tznV7TbYDh48N/FMIrdreXItRmFLPkiW9nzjb XtzDGHzfldyA1ZPz+Z/KRc1gRp/L1vLHTQpFZ36wcr8ULvGc9PJvRARQbfyUlUsvesOd zbUI6rK+ew7ekewpRnLxAabU6d7MOkWQ2OgVdPfqzi6xKRezgB8io6EX9yWSaIWj6GDe /mMYUFwsHVwAuNgtznjNz+u3W4EA2oDizUi7UlKSTmpQmAMmUeAZyRO4ebhPnrMZ/QhC 5V0Q== X-Gm-Message-State: AOAM530HezoeT0+o8DXrJ5nq16+90oYffclz3i/x5RgdvilC0gCplCrD UCnVVSPPBwDmY1UpfjfLKubravaW00r5xg== X-Google-Smtp-Source: ABdhPJwhdHhKNch3dmExiOnwJJAwpEILRF/J+Bbti4veWAi68kMTHQqvaDHL20vCPFA9/ogPjjnB9w== X-Received: by 2002:aa7:990b:0:b029:327:6b3f:8a1c with SMTP id z11-20020aa7990b0000b02903276b3f8a1cmr5486444pff.26.1626196001413; Tue, 13 Jul 2021 10:06:41 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id d15sm6948261pfl.82.2021.07.13.10.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 10:06:40 -0700 (PDT) Date: Tue, 13 Jul 2021 11:06:38 -0600 From: Mathieu Poirier To: Dong Aisheng Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, Peng Fan Subject: Re: [PATCH V2 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Message-ID: <20210713170638.GA1816225@p14s> References: <20210707094033.1959752-1-aisheng.dong@nxp.com> <20210707094033.1959752-5-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210707094033.1959752-5-aisheng.dong@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_100647_490716_4576A443 X-CRM114-Status: GOOD ( 19.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 07, 2021 at 05:40:33PM +0800, Dong Aisheng wrote: > DRAM is not io memory, so changed to ioremap_wc. This is also > aligned with core io accessories. e.g. memcpy/memset and cpu direct > access. > > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted before Linux Kernel") > Reviewed-by: Peng Fan > Signed-off-by: Dong Aisheng > --- > v1->v2: > * new patch It's a new patch and yet Peng's RB tag is already on it... > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index ff620688fad9..4ae416ba5080 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > break; > > /* Not use resource version, because we might share region */ > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); How was it working before? Will it really work for all platforms and was this extensively tested? Peng - I will need an explicit reply from you that you are in agreement with this change. I will also need you to review patch 01 and 02 of this set. Thanks, Mathieu > if (!priv->mem[b].cpu_addr) { > dev_err(dev, "failed to remap %pr\n", &res); > return -ENOMEM; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel