From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA47C4338F for ; Fri, 23 Jul 2021 13:01:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55CD760E73 for ; Fri, 23 Jul 2021 13:01:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55CD760E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mtvZsNnP4IdbRWBOyb7Y6L4IDT961UBLnxmPOaqzk5c=; b=XOCFMwg86jRjJ9 EuP7ACuR8ri4SalwUSOa2quP6pz2PR3vt0Tb4hRtxhnxIgEn6ea5uQ7yOyr9lVup3Ke+ZeD4QOhmq uFnc4P79FmUnqoeTFU+MqNhKsCFUGJDahtsXhxFU/kPxXwW63sWtox2mUElbLxojOoWqrJ58dAezy pVUNDJLgmMCasw1Vrnc199+Yv0R4QAUWDYUkSfGvDMJtYsCR2BYy/lPXpWz29ArTAtoFw8LDHZTFY Ju0aUEu1L7NYW6rL9dXc8qXSmaKZEswXtk/iExHYfE/RXs/0pbl+bI0VQBzSJ6ZxOR7EVUCbh1z1U R49Q77dFmQks7zQD2CqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ult-004keJ-Bb; Fri, 23 Jul 2021 12:59:21 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ulp-004kbO-5f for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 12:59:18 +0000 Received: by mail-pj1-x1033.google.com with SMTP id mt6so2095982pjb.1 for ; Fri, 23 Jul 2021 05:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=admFING+RTwbfb4knH3wY0aguWQ8mq91cUYAMzqn6ZY=; b=WDOtDkjiFEClp/1dGC+DmEeghNPtOkKgH+2CbbTqLzl86nXh39DjrOL29GlO2l0YpE tSqt59ExJJhqIuLls0zBfNdulOX/TCK/CRRZDtfb9S03gYNmfymoT45hfp+U8+MNQEBO Z7BghqfiPc24awdBF28qCON6SqJa690UZ2v0tYadUAF8V3rTHsoT8jfdnUTFLBzVRDUo RO9XbimJJiXBEzE0zKZ3FfyHBVIJ5DXzt1azyCFinR80CVFBxOenwANpfsmtuemzFMTV bbOP+fYYaZlEJlsn7CE6a5kAnF61WK1cawtGhqO48RwnAeBNzMs+WDczu8ZieiB23sPv AUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=admFING+RTwbfb4knH3wY0aguWQ8mq91cUYAMzqn6ZY=; b=mC++j4SFpA6vS2dCflVzc5snh63sWMVhQNul/qJ5qD3GbUS3Cu9WtPaU4ocp5EL3pj cys++J/xmAvicW7S307W7rZ6RDyWpTLf1XMgF9ySJOOaWoLtldea2EN4IybEJALxC1wB raLbzgoWqTOmHbp0PJLeUvuO+j/Utx0WE1agDOCm4SdrvIVT48uajRPDPccGzBNN8iUG alZjH24zjffomEfiBI6hPG4gxIPGGiZE0LAGZOvfcReSd8MOkdsvoap/ckIgwJgr1htH 9V39Kd3zEe8nk/XneuFnWpCzsjkIEu098pYw1sEFO6nzOKBKdrgfWMN9sacSn6c7UPtb mrMA== X-Gm-Message-State: AOAM531FtmGZjzE3gAKMSBhjbwlx+exIl0oAkKGLW5wLNV7p3CTtvl4Y f3r3XUpMnfjO8aLQUxx59Ok= X-Google-Smtp-Source: ABdhPJwDFkxQliqpPV+ayjxdoyQilsjLkT4M0H0k1VhO6v+eON3/S4gIfLAe7fgx9iUJA/6Fj6CJQg== X-Received: by 2002:a63:a1c:: with SMTP id 28mr4660873pgk.445.1627045153855; Fri, 23 Jul 2021 05:59:13 -0700 (PDT) Received: from ojas ([122.161.50.107]) by smtp.gmail.com with ESMTPSA id k4sm27967694pjs.55.2021.07.23.05.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 05:59:13 -0700 (PDT) Date: Fri, 23 Jul 2021 18:29:00 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Message-ID: <20210723125900.GA279903@ojas> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_055917_299386_A862B545 X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 01:02:41PM +0200, Greg KH wrote: > On Wed, Jul 21, 2021 at 09:50:48PM +0530, Ojaswin Mujoo wrote: > > Hello, > > > > This patchset adderesses the TODO item number 10 specified at: > > > > drivers/staging/vc04-services/interface/TODO > > > > For reference, the task is: > > > > 10) Reorganize file structure: Move char driver to it's own file and join > > both platform files > > > > The cdev is defined alongside with the platform code in vchiq_arm.c. It > > would be nice to completely decouple it from the actual core code. For > > instance to be able to use bcm2835-audio without having /dev/vchiq created. > > One could argue it's better for security reasons or general cleanliness. It > > could even be interesting to create two different kernel modules, something > > the likes of vchiq-core.ko and vchiq-dev.ko. This would also ease the > > upstreaming process. > > > > A summary of the patches is as follows: > > > > - Patch 1: Move cdev init code into a function > > - Patch 2: Shift some devlarations from vchiq_arm.c to vchiq_arm.h for > > sharing > > - Patch 3: Move vchiq cdev init code from vchiq_arm.c into vchiq_dev.c > > - Patch 4: Decouple cdev code by defining a Kconfig entry to allow > > optional compilation of it. > > - Patch 5: Merge code in vchiq_2835_arm.c to vchiq_arm.c > > > > Changes since v3 [2]: > > > > * In Patch 5, replace forward declarations of some of the functions with > > function definition > > You dropped the reviews of others, so now I need to wait for them again > :( > Hello Greg, Apologies for that, I was under the impression that a new version needed a separate review :( If its okay, I can alternately resubmit this (as v5?) with Stefan's Reviewed-By tags on unchanged commits intact. Let me know if that's okay or if its better to wait out. Thank you! Ojaswin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel