From: Vladimir Oltean <olteanv@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org, qiangqing.zhang@nxp.com,
robh+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells
Date: Fri, 23 Jul 2021 16:08:51 +0300 [thread overview]
Message-ID: <20210723130851.6tfl4ijl7hkqzchm@skbuf> (raw)
In-Reply-To: <20210723112835.31743-1-festevam@gmail.com>
Hi Fabio,
On Fri, Jul 23, 2021 at 08:28:35AM -0300, Fabio Estevam wrote:
> Since commit dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into
> phy device node") the following W=1 dtc warnings are seen:
>
> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Remove the unnecessary mdio #address-cells/#size-cells to fix it.
>
> Fixes: dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Are you actually sure this is the correct fix? If I look at mdio.yaml, I
think it is pretty clear that the "ethernet-phy" subnode of the MDIO
controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If
it did, then it wouldn't warn about #address-cells.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-23 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 11:28 [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells Fabio Estevam
2021-07-23 13:08 ` Vladimir Oltean [this message]
2021-07-23 13:15 ` Fabio Estevam
2021-07-23 13:35 ` Vladimir Oltean
2021-07-24 5:21 ` Joakim Zhang
2021-07-24 12:48 ` Fabio Estevam
2021-07-24 16:37 ` Florian Fainelli
2021-07-24 17:03 ` Vladimir Oltean
2021-07-24 19:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723130851.6tfl4ijl7hkqzchm@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).