From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE65C4338F for ; Fri, 23 Jul 2021 13:37:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0352060EE2 for ; Fri, 23 Jul 2021 13:37:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0352060EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y/pPFUpAalwg/HTWNFgoNuUTsXnXHMXE52sNUvO21DQ=; b=I0rQXN1Mk+b3Xz sewIEj7LjhwPaDQKncGUideFg/WwMUo8fyZqibirmPyrlNC5ARfGltzDkPlfj1O8+EpTyEcNp4vsS tC9chJqFYjaVFs+D6In2PW8hI57Et2A9BctQCgSa1scEVgpRR1/n16QD+hD82SlcK+7xS7rq6ek1U 71ihW6okT2n/GfM81loZ9aUiw7d2V3eiS1wavtGGC08pi33/fe1LG1u0y4XL78FAjduAavMubfGdM QvMVtAwhLwykLxsfhAwIdfTwtNoHTEIbHsD5uq5J8j3CRLpU5JYcJeBuBKnNQSSKdI5sNlVEmJP+0 7HtrjS2hA0z7icKjbVTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vLS-004s3i-KE; Fri, 23 Jul 2021 13:36:07 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vLM-004s2M-E9 for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 13:36:01 +0000 Received: by mail-ej1-x62e.google.com with SMTP id hq13so3685877ejc.7 for ; Fri, 23 Jul 2021 06:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=syQdpBaTHu3uZXlH1OVRUA7Md0MxaCJtCpKEccQDxYU=; b=huxKMkt0pXXNh5W/94n8CXFbDb7BVJT05xDQ3kMIqeqJzgh+ugjnRjyXli0YWyYgDn Hdxj+5BexGIoqPGN4yrJ/V6waa4oC7YpEj8zyF+frkDZOszrH5s9tIfW/T8z7azOzCox XGy/sf7+Hb1BGFkxf343bYDJPBu2IaE0oG0j9bQJXm9Em/zr5ofm7B/rReBlgeJ7rhEN qHHxRDXpq3oT0H0xygbSQfP+ESyqDOM+7YLNFKIu+nLmLVF4PtpHTEcFz5A41iSKR8By RTYtFEBVx+Hmaj4DtDcJ7m5ryFnMEW43JPEkjT3JebanLhWEj5coUsMHXQEMzWl/gHw7 Adrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=syQdpBaTHu3uZXlH1OVRUA7Md0MxaCJtCpKEccQDxYU=; b=iqfej3sUKoR51/jjNxsaSa7A2g2OwnmDvG7biGx3kbOdQftw6Dy/ckbIP242qpuVsX LAvTNCOqF/g7uDJeZPIE+w2/dihH59UYIESIHTDhiN7AwXZnDgjtDNOrE0XpwX4k4DZA vWGxAkTqEKucBk7xTFTB+Gx1or6ZBcYp1el8Crj0Px7cWc1XyjBp6aLzlKPfAjQk1Imi x+Wv7rhemixz05JVi5J1pF+PAJZ3y3wSQ6g5c5edyheKHSHX5QToU7r7Xti0bEAdTGgk 7uTbQD1s7Rw47gpIqfwX0KMDn2RdOOvAHK922mY0WFWrxEV0pIuDzAwaWBEU5Le+Xy3w MZvg== X-Gm-Message-State: AOAM5335Sd++LbVbFPKrz5k1caWsRwogbivcbIu4Dq1U4IxwA+plY7x2 dKwseP4UQAu8Gk0qC0O8rUc= X-Google-Smtp-Source: ABdhPJwb3SBZhK1DPpsdXTPaCI0y0ohVwIroXkDpCWGROEDXHXeJgWea5S0x+piJIduQ49VuPoiSGQ== X-Received: by 2002:a17:906:180a:: with SMTP id v10mr4602237eje.112.1627047358195; Fri, 23 Jul 2021 06:35:58 -0700 (PDT) Received: from skbuf ([82.76.66.29]) by smtp.gmail.com with ESMTPSA id v16sm13478381edc.52.2021.07.23.06.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 06:35:57 -0700 (PDT) Date: Fri, 23 Jul 2021 16:35:56 +0300 From: Vladimir Oltean To: Fabio Estevam Cc: "David S. Miller" , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Joakim Zhang , Rob Herring , netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells Message-ID: <20210723133556.xnhhxdkvassykavn@skbuf> References: <20210723112835.31743-1-festevam@gmail.com> <20210723130851.6tfl4ijl7hkqzchm@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_063600_559346_75A1AC5C X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 10:15:52AM -0300, Fabio Estevam wrote: > Hi Vladimr, > > On Fri, Jul 23, 2021 at 10:08 AM Vladimir Oltean wrote: > > > Are you actually sure this is the correct fix? If I look at mdio.yaml, I > > think it is pretty clear that the "ethernet-phy" subnode of the MDIO > > controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If > > it did, then it wouldn't warn about #address-cells. > > Thanks for reviewing it. > > After double-checking I realize that the correct fix would be to pass > the phy address, like: > > phy: ethernet-phy@1 { > reg = <1>; > > Since the Ethernet PHY address is design dependant, I can not make the > fix myself. > > I will try to ping the board maintainers for passing the correct phy address. > > Thanks Normally you should have been able to make all PHY addresses be 0. That is the MDIO "broadcast address" and if there's a single PHY on the bus, it should respond to that. Citation: IEEE 802.3-2015: 22.2.4.5.5 PHYAD (PHY Address) The PHY Address is five bits, allowing 32 unique PHY addresses. The first PHY address bit transmitted and received is the MSB of the address. A PHY that is connected to the station management entity via the mechanical interface defined in 22.6 shall always respond to transactions addressed to PHY Address zero <00000>. A station management entity that is attached to multiple PHYs must have prior knowledge of the appropriate PHY Address for each PHY. However, if you google "MDIO broadcast address", you'll find all sorts of funny reports of buggy PHYs not adhering to that clause, under all sorts of pretexts... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel