From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE066C4338F for ; Thu, 29 Jul 2021 14:41:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B98A6056C for ; Thu, 29 Jul 2021 14:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B98A6056C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dR94lcWXobdSrSt6uVICRBk/93vuKpWCO21C8r/AXQo=; b=4nKcIKYI+7V7ir lftrCLiTOv9zFFl15Nr/s7RzgAC/VHLC1TatZsc9WBrXEB73+yQM8O3fAm0FJuBJg4UVGjVGFWqyk mzvbDcbLqqIu6ooI+Mdbrj7Q++etVNowLTAj44AZMG1yuZyZ4foforWA7Ly4MJzWKOx+wK6CWBKdq mscTmnLI7A2UxxjWHsKrHFGBitgW+rUFnMQrQ+Lpqg5AJn3inhSdg5fhNoHkotRZ17JGoDMKcRiMv Zptkm3JFnGDbIou0P0QvkslMbgTc8lF2vEsKecU8jqRifmqVcfMUyiy4UZXNI4lq8YNQakcF0FVu/ ZMqUoy6vp5ffN8nBu96Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m97Bo-004Yb8-Lv; Thu, 29 Jul 2021 14:39:12 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m97Bk-004YaE-AJ for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 14:39:09 +0000 Date: Thu, 29 Jul 2021 16:39:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1627569546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rg+oK7al/gkoxKpHY8A5GVHzGSQ8H3z9QsI+7e6V9q8=; b=JBNmTcJyCBcoTav/tDA4vM2XAC7jXdsckYkoOoNOoN6YF9KXwi7F6+EoTdtQEL6ubx/m8e ti13sCIhnGUBuhfhcXGkc2mg3Z2IRzJj2iR6AJ0lozbupL5D+ShkfNgVfVK/Oue3tmHHI4 KXC09hM6nk8bNTV4sf/QNH8DmClKrZNtnj0CXwiHt3p8/tmpto7oSJiHz8m1bHL7s8MTgR 2yGnHomGDJjPGkTaYRXZSffKmYLX16oiXzpvPON0/Hyngw8JTBnTiuxFC5u57GQ8Ei5y26 hV7AsqmcA7EQ47RV/uhFlDgEjlxp2cX5CYpT+oJ43RZqR4tOoU6ltVGq5CFVJA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1627569546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rg+oK7al/gkoxKpHY8A5GVHzGSQ8H3z9QsI+7e6V9q8=; b=gT/EhgEbcWHoyH0zud+m4/IJIvcN5SQax8dG98Aq+mLcRJ7V3W3vnj8o867nC4gsf93hnY pBQYibvIS/FR3HDw== From: Sebastian Andrzej Siewior To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Thomas Gleixner Subject: Re: [PATCH] arm64/sve: Delay freeing memory in fpsimd_flush_thread() Message-ID: <20210729143904.ict3st7whd6ct7nj@linutronix.de> References: <20210729105215.2222338-1-bigeasy@linutronix.de> <20210729105215.2222338-2-bigeasy@linutronix.de> <20210729142616.GO4670@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729142616.GO4670@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_073908_557961_0C9C3E56 X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-07-29 15:26:16 [+0100], Mark Brown wrote: > On Thu, Jul 29, 2021 at 12:52:14PM +0200, Sebastian Andrzej Siewior wrote: > > > +static void *sve_free_atomic(struct task_struct *task) > > +{ > > + void *sve_state = task->thread.sve_state; > > + > > + WARN_ON(test_tsk_thread_flag(task, TIF_SVE)); > > + > > + task->thread.sve_state = NULL; > > + return sve_state; > > +} > > This has exactly one caller - why not just inline it there? It'd > probably make it easier to follow what's going on. In case someone makes changes to the non-atomic version which should also happen here. But I can inline it. Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel