From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A07C4338F for ; Wed, 4 Aug 2021 14:14:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 826A260EE8 for ; Wed, 4 Aug 2021 14:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 826A260EE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dr9xTlPF5ntt119yJgaPnGa/J5oHTk9md+F/9NhsNyw=; b=JxIgeZwNYFzD2A 6wJ1UpykkHKG2cvHlWtMWy5pYsUdtRvo0kq14LpTD65uEAKmyu3ky1DE384AhQMqGxk3PsleemYTY NWgkasomWuXvsrQisK/S4y78ic6jXlTLkRJjPN41+igDhv2pTX+fd9fPDiTZ6Xoeho/psNvTDDtRD UO5LmqMhXVM1q17VnZjQCh9fYbixdll9QjOgNJxIPMuXsw3p3Kz3uj0MHUWwiZfq364n/fDcfngEg dQC8Jp/NHYDR3OMIKORu6MyRJ5QrfXcTz91f7Gbr5RHXNHgV0Tm2MfrbdBB/q8T8psLvgkWfctQNj bv06R7+UNSN6OvnwmZ4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBHdj-006Mcx-7S; Wed, 04 Aug 2021 14:12:59 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBHdX-006LZE-5D for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 14:12:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bUVWeAD6MqsZNNa1HstYCm/fKhtId89nYJHVlkYj/PQ=; b=wjxg1pABgeT9WS7dy5Sqbvx6O yBGW+IUAjHHgUN2wbF8WJ8qodTdJKOHm+eUOhQB4nxCNrx08rvvBR8kmGTIIOA5LBIhPCqxh8Zncp aUx0Wwfkm2NNYvzSYBXhP3FxOSxGTOwZIzc4HpiyLYf7Qmt6O7a8q3nk6uWi/7bxDAddTrap5WzyJ iRvm95dMolrEoZz+9obuDb4uxhNvfJwpzW3ErfoDhLvM1prX4TxbLdJzS6ppZ4nDecS7bU6IPew3/ Ok9bUYkO1AZhjGh/uuyDrGCB/3KHPhcVj+RfxwBarU4T4nXEe9Ci/vfmbeKCLspY6kz9b3JcmvowE hEC1zkE6w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46942) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBHbX-0000MZ-Cv; Wed, 04 Aug 2021 15:10:43 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1mBHbW-0004rk-UW; Wed, 04 Aug 2021 15:10:42 +0100 Date: Wed, 4 Aug 2021 15:10:42 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, Nishanth Menon Subject: Re: [PATCH] ARM: Fix Keystone 2 kernel mapping regression Message-ID: <20210804141042.GQ22278@shell.armlinux.org.uk> References: <20210804135747.737233-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210804135747.737233-1-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_071247_255437_294BD91D X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, Looks fine. An improvement: On Wed, Aug 04, 2021 at 03:57:47PM +0200, Linus Walleij wrote: > @@ -250,7 +253,12 @@ __create_page_tables: > add r0, r4, #KERNEL_OFFSET >> (SECTION_SHIFT - PMD_ORDER) > ldr r6, =(_end - 1) > adr_l r5, kernel_sec_start @ _pa(kernel_sec_start) > - str r8, [r5] @ Save physical start of kernel > +#ifdef CONFIG_CPU_ENDIAN_BE8 > + add r5, r5, #4 @ Move to the upper 32bit word > + str r8, [r5] @ Save physical start of kernel (BE) These two instructions can simply be replaced with: str r8, [r5, #4] > +#else > + str r8, [r5] @ Save physical start of kernel (LE) > +#endif > orr r3, r8, r7 @ Add the MMU flags > add r6, r4, r6, lsr #(SECTION_SHIFT - PMD_ORDER) > 1: str r3, [r0], #1 << PMD_ORDER > @@ -259,7 +267,12 @@ __create_page_tables: > bls 1b > eor r3, r3, r7 @ Remove the MMU flags > adr_l r5, kernel_sec_end @ _pa(kernel_sec_end) > - str r3, [r5] @ Save physical end of kernel > +#ifdef CONFIG_CPU_ENDIAN_BE8 > + add r5, r5, #4 @ Move to the upper 32bit word > + str r8, [r5] @ Save physical end of kernel (BE) Same here. The patch can still usefully be tested by Nishanth without these changes... it'll tell us if this was indeed the issue. Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel