From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79E2C432BE for ; Thu, 5 Aug 2021 09:44:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 733B260F22 for ; Thu, 5 Aug 2021 09:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 733B260F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EXJxXbI6NVUcSNU3VOHJOchFTQkRNskhLfDVUcMEIRE=; b=tVzO+1U10TvPLt piWq1UDJ4Esr1Utbu7JmQCFnUOHre0GoYN2exvP6XhQ+Ed5rxHg/rcCCgy7o6/2OrskrnQ9SAsX78 uOq5nl36RVAZgQj4SiWnzl3hotK9KbQEvw4fFyPoTWkE5Yoma/TssNod8SyFaPsoUxLs9EwhEgdjl xvoX1WPoAeYw7xaBBLGqY2zriExbyxwPJzWqoDVJTpaKP7fmk5AkthOkhx6gvlVkPUfVVCsqvoNHr R338RGMcGZeD6PhmmXFdysF0ZUT8D0ZLeBiaS2nNC3iJeNdY2aUlpXfs9H854nQTUM7oj3pJGVtQ+ VZxU7qhmMYm0c5x5m1Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZso-008vlL-C7; Thu, 05 Aug 2021 09:41:47 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZre-008vJH-6C for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 09:40:35 +0000 Received: by mail-pj1-x102c.google.com with SMTP id e2-20020a17090a4a02b029016f3020d867so7898932pjh.3 for ; Thu, 05 Aug 2021 02:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nDgSiKT3PmC/uVgbSGJ5t/4JCmbXe35pN3HpY7zZV9E=; b=C6wyBK36441JkySRlvZ/2pfKdBz31BE8gQlFQzt5bcvETqDRArNU8tGTG9jk5HrXm8 c+VvdloQWAyGTz2BO0E9PWSmHPiFYRdhwGc+BINqy6yNpcrZ3VMorgtPknMB8368Q6WM snrSDbzmuiLJgbUt/DcpuxCppoZAnA7Yl4VVW3v7NYIeSpR7DT1ZGAmdvklUADOVK4p0 D/VDnfrUAidl0RQOXIlojaUCwmIOfTTF22wN8u9J3/NYWcwXvsEMX8ghCKZu/Cyi9i41 J6R2QjAG00zXHIlPnv962j2wh2i9Sr2rJfS9GrXYaJEfblDCtvBJ5AA5uh51aRsaLVzY Ffjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nDgSiKT3PmC/uVgbSGJ5t/4JCmbXe35pN3HpY7zZV9E=; b=E0RtDmBn21Px1lCNnX5CXWnnEteM9ZY9zovpa/sfYWbQJ4RvUs9ZlFmEunPE6neYUV 8nN1/tOEoJ2boSSsO4V8y2KMbylxaW5HkgCrz6LyxMMnCysU6X/fBVCwuhaDBxq6qN5E A4S10uTRz9UGTZRbVLa5TO018VY3KzIgj9xgiF0+jLrPV3rIWni3JwcFd832QKOaeQf5 WjTY62LmGSPzjAz4k9j9tTVjYa+0E16kSdA39pkxWHW19jHOD/+7U5cHDw/duJffPDZm A7MBNlIg/zHCTxZejMhxsZiyojSwpMBrFGlbJnBWia2kPUBbuSdFX9AiIYJ9nu0cukcT d9Aw== X-Gm-Message-State: AOAM532AJmDQF1CJadmGioeMsYHg1aI6H78/13+zaUSDNVOHdQTxTbct +oZpJCY4ybm5B9U0aRbxLRStZw== X-Google-Smtp-Source: ABdhPJyPyEcVsCvddqnfpJm3MeotME9LAyQ5SA1NJxPIjyQ+VBI4nEmORfuHRBrQHWkSGcv02u0ZuA== X-Received: by 2002:a05:6a00:16d6:b029:32a:ffe9:76a with SMTP id l22-20020a056a0016d6b029032affe9076amr4429638pfc.60.1628156432150; Thu, 05 Aug 2021 02:40:32 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id x189sm6908188pfx.99.2021.08.05.02.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 02:40:31 -0700 (PDT) Date: Thu, 5 Aug 2021 17:40:24 +0800 From: Leo Yan To: James Clark Cc: Mike Leach , Arnaldo Carvalho de Melo , Mathieu Poirier , Coresight ML , Al Grant , "Suzuki K. Poulose" , Anshuman Khandual , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org Subject: Re: [PATCH 3/6] perf cs-etm: Save TRCDEVARCH register Message-ID: <20210805094024.GA19058@leoy-ThinkPad-X240s> References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-4-james.clark@arm.com> <20210731063731.GC7437@leoy-ThinkPad-X240s> <9156d7a1-3676-ab98-2c38-26f9765b845c@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9156d7a1-3676-ab98-2c38-26f9765b845c@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_024034_359723_431F83B7 X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 03, 2021 at 01:34:36PM +0100, James Clark wrote: > > On 31/07/2021 07:37, Leo Yan wrote: > >>> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > >>> index 85168d87b2d7..65a863bdf5cc 100644 > >>> --- a/tools/perf/arch/arm/util/cs-etm.c > >>> +++ b/tools/perf/arch/arm/util/cs-etm.c > >>> @@ -53,6 +53,7 @@ static const char *metadata_etmv4_ro[CS_ETMV4_PRIV_MAX] = { > >>> [CS_ETMV4_TRCIDR2] = "trcidr/trcidr2", > >>> [CS_ETMV4_TRCIDR8] = "trcidr/trcidr8", > >>> [CS_ETMV4_TRCAUTHSTATUS] = "mgmt/trcauthstatus", > >>> + [CS_ETE_TRCDEVARCH] = "mgmt/trcdevarch" > > ETMv4 supports TRCDEVARCH, so I think it's good to use the naming > > "CS_ETMV4_TRCDEVARCH"? > > > > Based on the other discussions do you still think I should do this? No, don't need to add TRCDEVARCH for ETMv4 anymore. > As part of the new magic number I moved it into a new enum so it > might be clearer now? Regard ETMv4 and ETE use the different decoder types from OpenCSD, you could add a new magic number and new enum for ETE. It would be easier for later extension for ETMv4 and ETE separately if decoder requires to pass more config info. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel