From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16B5C4338F for ; Thu, 5 Aug 2021 16:38:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB6E661050 for ; Thu, 5 Aug 2021 16:38:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB6E661050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UC/L5FbvgwOXx6OO8r4j89JFfSHiOZ7g62ZzN3Oi1FU=; b=p1f4EKVa+azTde WmONCMYmevOyGgCnobRaJix2BtcrE58ZMWWFIXxdLWD2dhHv5TVpXRSaKyEUi9+0KeHtRYZoCsnJx Gxc88WLrjSvZCbwPrfyUy7Y25VOcccBOMyzYRo6JMiqM1MYzdXJSUtqKZFvExg7DIvtGrEjfrNNas TPRpi/hoDsXlvlEZz8enKjnZ15gHeWmJYuz5F7jBpT3OKwlFFhw95Rw/0oCW92VIw7jbnC9/S8lTV H8uWT76gHdCLoe0A9V5+jOymYun/QNIXGT6z8mdHN2ucNZpAZSb7V5ve9Ln85SGcCbv+Svo54Ea13 wD9sby8Gol9aVdsbshBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgML-00AGfa-Gh; Thu, 05 Aug 2021 16:36:41 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgMG-00AGeS-D7 for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 16:36:39 +0000 Received: by mail-pj1-x1033.google.com with SMTP id mz5-20020a17090b3785b0290176ecf64922so16143040pjb.3 for ; Thu, 05 Aug 2021 09:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gZUbnq9fvKjj+31UV+0WtAsWShgRVDQP8luUkhlwWZQ=; b=MlY3BdTH3kmc6EMwTgYCLXMCvZJN90V4Z8Ldfne/SIadxLASuCCvffmpGgaBBMIDgC +CAC1O1VILBOHJXORA66vwfvelYsU3UqOgTTMi3n63GA+JgJ1XlXOc8rmD8UENN3kaQX 6LgyIZvodxAwYnw3l/ql4ZCuObRa1uHCZoS7lFE/uOTY/wKKl67sGrh4N+772G2biy1I /TeAuwQm/+h2mI9pAwBKp9DyPRGQQU5VVoQa2nXRJFl01UfwC2YNirCluExMBSEExSbQ EjLVRBPiyuGhEWwxS4u9iht0z1jS9xMEPlAx6SnNf/5B5h1EgfvMzITNqDe+3tcPhq2z +Fhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gZUbnq9fvKjj+31UV+0WtAsWShgRVDQP8luUkhlwWZQ=; b=sVZcH8cEoVinUNEtVuOOY3azAvIIqdVK3QHFHgIz7+lG7fre0BIgsxz+sA6hhaUbEw Z94XKBhZ0Srdwp6tALHnKqugRsO+49dJHmYi40YHae4ia4XIE1J1fBprppgScJH5evkJ /vkZMGwOnSPIMiHfdzAtjLaYLCuH49l93kpo5JqWX6gabo/kSn0G55dEL1fN6kar1Gvc xUKA35wW5T99x/NMVAqH5i+/0ujZ4P/iD5AImnyiDTuZdbF8zzJitJQHi8R4a0FX3P9n LhwiymgauYyt1Xs73V2RNkwOyhNeWPJhcyoEkuH/DGaqaOJWUMKr6cicged6My9Wug0S +U4w== X-Gm-Message-State: AOAM530P1GjF/ZsgzAP/SuhyaOLFXkY2F9e6f0ET+BPLCNN32jaChZDk Hxoy77l6PtLvZRt1WUEJupEfTg== X-Google-Smtp-Source: ABdhPJxKVkvflNkYOprr8jPB4n7GLFxdFOAJdpBRNxE2FBoHC6M+8kSjwo/+Kpxb2pby7XPIq8HLwA== X-Received: by 2002:a17:902:c3cb:b029:12c:a426:164a with SMTP id j11-20020a170902c3cbb029012ca426164amr4665538plj.81.1628181395073; Thu, 05 Aug 2021 09:36:35 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id cu12sm10102789pjb.5.2021.08.05.09.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 09:36:33 -0700 (PDT) Date: Thu, 5 Aug 2021 10:36:32 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Aisheng Dong , "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "ohad@wizery.com" , "dongas86@gmail.com" , "bjorn.andersson@linaro.org" , "cleger@kalray.eu" Subject: Re: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Message-ID: <20210805163632.GC3205691@p14s> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> <20210805033206.1295269-5-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_093636_490607_F591B09D X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 05, 2021 at 09:57:10AM +0000, Peng Fan (OSS) wrote: > > Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for > > dram > > > > DRAM is not io memory, so changed to ioremap_wc. This is also aligned with > > core io accessories. e.g. memcpy/memset and cpu direct access. > > > > Cc: Bjorn Andersson > > Cc: Mathieu Poirier > > Cc: Peng Fan > > Signed-off-by: Dong Aisheng > > Reviewed-by: Peng Fan > Did you test this one as well? > > --- > > v2->v3: > > * patch content unchanged. > > Only drop the wrong tag in v2 > > Tested on MX8MQ and MX8MP, MX7ULP. > > v1->v2: > > * new patch > > --- > > drivers/remoteproc/imx_rproc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > break; > > > > /* Not use resource version, because we might share region */ > > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, > > resource_size(&res)); > > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, > > res.start, > > +resource_size(&res)); > > if (!priv->mem[b].cpu_addr) { > > dev_err(dev, "failed to remap %pr\n", &res); > > return -ENOMEM; > > -- > > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel