From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89555C4338F for ; Thu, 5 Aug 2021 17:05:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5428F61132 for ; Thu, 5 Aug 2021 17:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5428F61132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9rdQTCEACRqbDeSh0gkYiWohp5du9vDDQKzBakJ9SPA=; b=jjEppagebGsFGf XMwe/0GelmoIdI8LxtWiC1qj6+V09VPOwufEeDIPgVTMGr3AwVSzxEp0MSrHBXR1mgtFEFB6/pngC wrwUh434chodAV+IfQOR9jfbIHLQuMGWhTsPD6EpH/DdFLdBe8YXIlTNgU7Bf8V1mQGKabvflZsq6 DKUxgernOSAD63k6BUtusnXkiIaZwpCNga28LpekDzDaVbyLXEBUOJe11eI7uyWOvx0N3WHepJ2Km efFDhdZy8JDAJd6nLV8nCoSJgLcOilBdW7NMskJxB8BttU8R24rxkN7zo/NCtcjfkQX05CvDCDyIH MIgl5eMHqViF8qdliISA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgmL-00AKcP-A8; Thu, 05 Aug 2021 17:03:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgmH-00AKbY-2X for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 17:03:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 970B76112F; Thu, 5 Aug 2021 17:03:26 +0000 (UTC) Date: Thu, 5 Aug 2021 18:03:18 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, suzuki.poulose@arm.com, mark.rutland@arm.com, will@kernel.org, maz@kernel.org, james.morse@arm.com, steven.price@arm.com Subject: Re: [RFC V2 01/10] mm/mmap: Dynamically initialize protection_map[] Message-ID: <20210805170318.GB6719@arm.com> References: <1627281445-12445-1-git-send-email-anshuman.khandual@arm.com> <1627281445-12445-2-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1627281445-12445-2-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_100329_173280_A116E0CD X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 26, 2021 at 12:07:16PM +0530, Anshuman Khandual wrote: > The protection_map[] elements (__PXXX and __SXXX) might sometimes contain > runtime variables in certain platforms like arm64 preventing a successful > build because of the current static initialization. So it just defers the > initialization until mmmap_init() via a new helper init_protection_map(). > > Signed-off-by: Anshuman Khandual > --- > mm/mmap.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index ca54d36..a95b078 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -100,10 +100,7 @@ static void unmap_region(struct mm_struct *mm, > * w: (no) no > * x: (yes) yes > */ > -pgprot_t protection_map[16] __ro_after_init = { > - __P000, __P001, __P010, __P011, __P100, __P101, __P110, __P111, > - __S000, __S001, __S010, __S011, __S100, __S101, __S110, __S111 > -}; > +pgprot_t protection_map[16] __ro_after_init; Mips, x86, sparc, arm32, m68k all adjust protection_map[] during boot. Could we do something similar here and avoid changing the generic code? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel