From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5D3C4338F for ; Sun, 8 Aug 2021 17:10:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E587560EBD for ; Sun, 8 Aug 2021 17:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E587560EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cmMfOhO58IlWUHf0CiY4m8uaOHudZvgTTWbMi0zfAL8=; b=gCoLZVTWxSf5bO idwyUOmjSlQD4gGuSdzU3iy7v+5/H5SoobSS2u940VFaj9kRHBKNXX+oR42UBPZsAbJwxx3jicIMV wIqMCFAEl3gAr1GMcpMgalBufbs2AV7HWbQwrVb+5sN5YN8EL/v6AZlPG4kB0y/DEGi3OBhbdVuSa 9/8EYmhh1xDsQdQ5D7NN/zw/vpzvao/yeivwUeT/9oBHvP0Oz3a5CHnibZFnn7cOwiw646qvcKxQn mPeMnPb+65EkhAZxvMzY7mbjvR20T6wztTTjo0NFdpfjDarrvGkoN45GVKTQ00xKyE2R0OiYKWB21 lGzUoQymdlZhSmjwxLdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCmHF-00G8mb-9v; Sun, 08 Aug 2021 17:07:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCmHB-00G8lb-2h for linux-arm-kernel@lists.infradead.org; Sun, 08 Aug 2021 17:07:54 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22FF060E93; Sun, 8 Aug 2021 17:07:47 +0000 (UTC) Date: Sun, 8 Aug 2021 18:10:37 +0100 From: Jonathan Cameron To: William Breathitt Gray Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com Subject: Re: [PATCH v14 04/17] counter: Rename counter_signal_value to counter_signal_level Message-ID: <20210808181037.3016bb00@jic23-huawei> In-Reply-To: <3f17010abe2415859cea9a5fddabd3c97f635ff5.1627990337.git.vilhelm.gray@gmail.com> References: <3f17010abe2415859cea9a5fddabd3c97f635ff5.1627990337.git.vilhelm.gray@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210808_100753_211070_3533B6E8 X-CRM114-Status: GOOD ( 24.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 3 Aug 2021 21:06:14 +0900 William Breathitt Gray wrote: > Signal values will always be levels so let's be explicit it about it to > make the intent of the code clear. > > Cc: Oleksij Rempel > Cc: Kamel Bouhara > Acked-by: Syed Nayyar Waris > Reviewed-by: David Lechner > Signed-off-by: William Breathitt Gray Applied. > --- > drivers/counter/104-quad-8.c | 5 +++-- > drivers/counter/counter.c | 12 ++++++------ > drivers/counter/interrupt-cnt.c | 4 ++-- > drivers/counter/microchip-tcb-capture.c | 4 ++-- > include/linux/counter.h | 12 ++++++------ > 5 files changed, 19 insertions(+), 18 deletions(-) > > diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c > index d54efdb8d393..b4dd07cf51eb 100644 > --- a/drivers/counter/104-quad-8.c > +++ b/drivers/counter/104-quad-8.c > @@ -97,7 +97,8 @@ struct quad8 { > #define QUAD8_CMR_QUADRATURE_X4 0x18 > > static int quad8_signal_read(struct counter_device *counter, > - struct counter_signal *signal, enum counter_signal_value *val) > + struct counter_signal *signal, > + enum counter_signal_level *level) > { > const struct quad8 *const priv = counter->priv; > unsigned int state; > @@ -109,7 +110,7 @@ static int quad8_signal_read(struct counter_device *counter, > state = inb(priv->base + QUAD8_REG_INDEX_INPUT_LEVELS) > & BIT(signal->id - 16); > > - *val = (state) ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *level = (state) ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/drivers/counter/counter.c b/drivers/counter/counter.c > index 6a683d086008..cb92673552b5 100644 > --- a/drivers/counter/counter.c > +++ b/drivers/counter/counter.c > @@ -289,9 +289,9 @@ struct counter_signal_unit { > struct counter_signal *signal; > }; > > -static const char *const counter_signal_value_str[] = { > - [COUNTER_SIGNAL_LOW] = "low", > - [COUNTER_SIGNAL_HIGH] = "high" > +static const char *const counter_signal_level_str[] = { > + [COUNTER_SIGNAL_LEVEL_LOW] = "low", > + [COUNTER_SIGNAL_LEVEL_HIGH] = "high" > }; > > static ssize_t counter_signal_show(struct device *dev, > @@ -302,13 +302,13 @@ static ssize_t counter_signal_show(struct device *dev, > const struct counter_signal_unit *const component = devattr->component; > struct counter_signal *const signal = component->signal; > int err; > - enum counter_signal_value val; > + enum counter_signal_level level; > > - err = counter->ops->signal_read(counter, signal, &val); > + err = counter->ops->signal_read(counter, signal, &level); > if (err) > return err; > > - return sprintf(buf, "%s\n", counter_signal_value_str[val]); > + return sprintf(buf, "%s\n", counter_signal_level_str[level]); > } > > struct counter_name_unit { > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c > index 66cac4900327..d06367bef8f0 100644 > --- a/drivers/counter/interrupt-cnt.c > +++ b/drivers/counter/interrupt-cnt.c > @@ -130,7 +130,7 @@ static int interrupt_cnt_function_get(struct counter_device *counter, > > static int interrupt_cnt_signal_read(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val) > + enum counter_signal_level *level) > { > struct interrupt_cnt_priv *priv = counter->priv; > int ret; > @@ -142,7 +142,7 @@ static int interrupt_cnt_signal_read(struct counter_device *counter, > if (ret < 0) > return ret; > > - *val = ret ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *level = ret ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 0c9a61962911..6be3adf74114 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -158,7 +158,7 @@ static int mchp_tc_count_function_set(struct counter_device *counter, > > static int mchp_tc_count_signal_read(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val) > + enum counter_signal_level *lvl) > { > struct mchp_tc_data *const priv = counter->priv; > bool sigstatus; > @@ -171,7 +171,7 @@ static int mchp_tc_count_signal_read(struct counter_device *counter, > else > sigstatus = (sr & ATMEL_TC_MTIOA); > > - *val = sigstatus ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *lvl = sigstatus ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/include/linux/counter.h b/include/linux/counter.h > index 9dbd5df4cd34..79f5dcaf6ba0 100644 > --- a/include/linux/counter.h > +++ b/include/linux/counter.h > @@ -290,16 +290,16 @@ struct counter_device_state { > const struct attribute_group **groups; > }; > > -enum counter_signal_value { > - COUNTER_SIGNAL_LOW = 0, > - COUNTER_SIGNAL_HIGH > +enum counter_signal_level { > + COUNTER_SIGNAL_LEVEL_LOW, > + COUNTER_SIGNAL_LEVEL_HIGH, > }; > > /** > * struct counter_ops - Callbacks from driver > * @signal_read: optional read callback for Signal attribute. The read > - * value of the respective Signal should be passed back via > - * the val parameter. > + * level of the respective Signal should be passed back via > + * the level parameter. > * @count_read: optional read callback for Count attribute. The read > * value of the respective Count should be passed back via > * the val parameter. > @@ -324,7 +324,7 @@ enum counter_signal_value { > struct counter_ops { > int (*signal_read)(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val); > + enum counter_signal_level *level); > int (*count_read)(struct counter_device *counter, > struct counter_count *count, unsigned long *val); > int (*count_write)(struct counter_device *counter, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel