From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D82FC4338F for ; Wed, 11 Aug 2021 10:38:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FC8F60560 for ; Wed, 11 Aug 2021 10:38:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3FC8F60560 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Z1eD7BYXsYbt9mZP9FHJ+SLrFEhmaHOG9cZvkNFXj8=; b=bj8GWwv+ejEO3a Aj6DUiRiXCWCvqb5spgKxoN9iu3PbaPhcGkkbnasWRq7ve03N5p7J/7IQ1E9snRUYL+Rv4rGexaAc 1vICqPfTC5nS3pFVPONmYqY4FG9hrjF0XcnHN8CuarCHk5XCvHyPJbhy3f6Eg9UAr7Cg1/NWT3TZb lIoi1+qXCeqDq2CgP2lFvUaZtnqW4/b5I9VZrZUemF7C6f0dO8t+Q58Gqw3ehrMKFM++9U2Q1GGaC hmhnjQMFnQRvEE/5irkYHW5Yishc0PK9ZAY48QiFlJsaz5e+CJbHVrmyyhr3ZgqYkE45kq8H8vag1 EuayUxD8BZvgZAd2yUmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDlb8-006fDN-2v; Wed, 11 Aug 2021 10:36:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDlb2-006fBt-26 for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 10:36:29 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDlaw-0007X3-Kn; Wed, 11 Aug 2021 12:36:22 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mDlav-0006UT-HD; Wed, 11 Aug 2021 12:36:21 +0200 Date: Wed, 11 Aug 2021 12:36:21 +0200 From: Michael Tretter To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Sai Krishna Potthuri , Philipp Zabel , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type Message-ID: <20210811103621.GA23827@pengutronix.de> References: <925cebbe4eb73c7d0a536da204748d33c7100d8c.1624448778.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <925cebbe4eb73c7d0a536da204748d33c7100d8c.1624448778.git.michal.simek@xilinx.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:28:45 up 174 days, 13:52, 93 users, load average: 0.02, 0.09, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_033628_163286_9664907F X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote: > From: Sai Krishna Potthuri > > This patch changes the data type of the variable 'val' from > int to u32. > > Signed-off-by: Sai Krishna Potthuri > Signed-off-by: Michal Simek > Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" > --- > > drivers/reset/reset-zynqmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index daa425e74c96..59dc0ff9af9e 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > unsigned long id) > { > struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > - int val, err; > + int err; > + u32 val; The function returns val as int instead of u32. While this shouldn't be a problem in this case, maybe there should be an additional check just to be sure? Michael > > err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); > if (err) > -- > 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel