From: Will Deacon <will@kernel.org>
To: "liuqi (BA)" <liuqi115@huawei.com>
Cc: Linuxarm <linuxarm@huawei.com>,
mark.rutland@arm.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com
Subject: Re: [PATCH v8 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Fri, 13 Aug 2021 15:40:27 +0100 [thread overview]
Message-ID: <20210813144026.GA8451@willie-the-truck> (raw)
In-Reply-To: <a56266c4-c434-f078-6027-f30c021bd593@huawei.com>
On Wed, Aug 04, 2021 at 03:29:54PM +0800, liuqi (BA) wrote:
>
> Hi Will,
> > Hmm, I was hoping that you would expose all the events as proper perf_events
> > and get rid of the subevents entirely.
> >
> > Then userspace could do things like:
> >
> > // Count number of RX memory reads
> > $ perf stat -e hisi_pcie0_0/rx_memory_read/
> >
> > // Count delay cycles
> > $ perf stat -e hisi_pcie0_0/latency/
> >
> > // Count both of the above (events must be in the same group)
> > $ perf stat -g -e hisi_pcie0_0/latency/ -e hisi_pcie0_0/rx_memory_read/
> >
> > Note that in all three of these cases the hardware will be programmed in
> > the same way and both HISI_PCIE_CNT and HISI_PCIE_EXT_CNT are allocated!
> >
> > So for example, doing this (i.e. without the '-g'):
> >
> > $ perf stat -e hisi_pcie0_0/latency/ -e hisi_pcie0_0/rx_memory_read/
> >
> > would fail because the first event would allocate both of the counters.
>
> I'm confused with this situation when getting rid of subevent:
>
> $ perf stat -e hisi_pcie0_0/latency/ -e hisi_pcie0_0/rx_memory_read/
>
> In this case, driver checks the relationship of "latency" and
> "rx_memory_read" in pmu->add() function and return a -EINVAL, but this seems
> lead to time division multiplexing.
>
> if (event->pmu->add(event, PERF_EF_START)) {
> perf_event_set_state(event, PERF_EVENT_STATE_INACTIVE);
> event->oncpu = -1;
> ret = -EAGAIN;
> goto out;
> }
> ...
> out:
> perf_pmu_enable(event->pmu);
>
> This result doesn't meet our expection, do I miss something here?
This is how perf works. If you don't want multiplexing, put the events in a
group. What's the problem with that?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-08-13 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 8:09 [PATCH v8 0/2] drivers/perf: hisi: Add support for PCIe PMU Qi Liu
2021-07-28 8:09 ` [PATCH v8 1/2] docs: perf: Add description for HiSilicon PCIe PMU driver Qi Liu
2021-07-28 8:09 ` [PATCH v8 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Qi Liu
2021-08-02 10:03 ` Will Deacon
2021-08-04 7:29 ` liuqi (BA)
2021-08-13 14:40 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813144026.GA8451@willie-the-truck \
--to=will@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).