From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6112CC4338F for ; Tue, 17 Aug 2021 17:02:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29669606A5 for ; Tue, 17 Aug 2021 17:02:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 29669606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5ND7Y+FZoEcwKILTmAZ9tXGlkW+ao5JUQkih0DHLnMw=; b=zBIGycRuXxiaM+ Q6neJZNOMRmSMbxsbvuEDtI/kH+FpxN3W0h/tX1u88+eMA5lHg6cyGt9EWLtrdggl+DhcAVkqHX+A Rx+ph+E8PVE7j/6A7vED43IWgTJveLDukdLXq8Nm+olwcNK97G7PSSU9f/ykjoGUZ/7RdwYNX0NH6 6OIzLyYnM9V5OkU3Oet8psHF4jl7E1819+zg+aadXMclPQbP45EzJoBFoWs9DdLRS+mQjOCMvGtZk X4qY/naOaZRa4KRQX6C7h3ezeV+6FuV+V/jl465oxOHtVuskBYMsxxVHgZl+cdCABSpu0y8to4M93 6V+mEPKYxHMZNP+q8lcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG2RF-0034VA-Qo; Tue, 17 Aug 2021 16:59:46 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG2R5-0034Tc-NZ for linux-arm-kernel@lists.infradead.org; Tue, 17 Aug 2021 16:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629219567; bh=Wt1Gfa74aGaeFve/KcE/rZ8HsK7KgulSzUjTwDDDzic=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=YqnZmoDWdEJX63qtoDsogNo5I0JDR8I4jMW6MCgzzslVi99tCNJRaTAcKJljGbmWd OoFQ0QEXcPud34sod1PxOnoblTcP8vr1+A/jPmqTXgXYBLiPhXzwapxNcWnprBsBfd fdLIpgwsvyhpsK6kFDyOVJ1IsRA4G+CKxz1SzHCE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([79.150.72.99]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MDQeK-1mPM5Z2lQk-00ASZB; Tue, 17 Aug 2021 18:59:27 +0200 From: Len Baker To: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: Len Baker , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: sun6i-pw2i: Prefer strscpy over strlcpy Date: Tue, 17 Aug 2021 18:58:59 +0200 Message-Id: <20210817165859.5429-1-len.baker@gmx.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:eUX8iGeHdrCmQwqUvgLJI1PlMs2ap/qw3UAD7StzS2DGEIG7K93 YzsVmA0OcXTvwaWHsLlX39BPkLzsLWj7tJvfc822oUEqkPdNoLnY/gCdjYSrZ6qgyIah/+t IUopIqUu63BntXEAYza4UcJJF4lX+PtvrcNvds2/NGZN/svsDJ5hxEriwNeLUX535Tvzj6M VSM2eZBRQsR09fflwYnlA== X-UI-Out-Filterresults: notjunk:1;V03:K0:5/Wish7CQms=:Gyfn31whfCPinEUsghZsBR rKAjkZ3YnZeIf+Z0lyPjJfYyaJMqErXIxdtVuibw5G/g9a+04PqpHu/q0kAXXjMsr1Hlp56u4 YDrGcJnk5oojDeNF1AelD7615kS7RPE3VtLspP9wuCU6ZihaCIH7Oi1K1wtwwi+vvl1oi/xjo un2A/l8LjAzRlj7rJU5eM0eREwFA/F3ip/WliZAKHzeIxB5VpiODmhGz7j8Ob1rwALINB87Ty ZX5T1C68Dfeg60K7S08REZr12qT+Sa2poNM5VpAM6pMYhwkKAaZDplL1qDFL7XGkYtuiutl1P Qmyk+YgIyZWpOBut5Hl409CyNOF2/9ZKdXaRIy9fIdnJ6I+ATYpcUrCvetgYQmb6q2LKfEyaf zb+xYE8JOeXo6c7rtX7y8RbOkoJB4c9Ajp//HM3MqQACphD8j6SlPA5hzEQznRnvXVn++vIAQ b30NL9npDuWMf8xGs+5Qp40ge3jmEFqxen5WnchImWk1OO6tDpu370WpN3Is/rXEwVpaofeM/ ZZvin71DwbVVjA8WRl64Ux8rct8tHccTbtG+XD97ufUMr7/zUXf+Sce7n5ruXDlffg5NhvXxX T3vzIGWP6fbMn/D0qO0SbPBMD71lJUXdelOq52+9VtRMk8z6EsDnMpHnjSttKSnjQhcuq2EE7 vJVazlSW5jjkKRWjVmSzhUUSIkPTyDMFcnUxIEGw0Fiki9xpw6nvI64ix95BmrVX4hq4Cqwj2 g3WjmyrVGxxEa9S9Hlw42trTYxB5mnSC2JEK6WLgxvmrQzPd2md083h7/YxXUhRmAwG4v+eL/ s/A83N4SIey/2Y/jT1dGWFs3QXu9fPCEDbAUov+bTuVKRBQQvkoaiaQAxhe2lwzlIFPMGit3s I3RK737PKEMOMfNghXEcWXxItGrYVaPCx0uoO2jhFc5805njCfOyrnxN115GNjFCO9n8iOfDn uJ7nWWQjvNi4Vprl2BSUNrbKZKlvQvDbJQKQkcj97v1nq7wbmODowrREHNIjei1piMtMKhgAz 93q55Ij+/W49q6xLNRH/k2SGR1R7R7+JFIazyJs7UdrtmavfOjCTxNUVoGzfDFQWFiaIq83sf Y7g33ZqX/kU5Y5VWkBexZ+JOM47rTmIKimNKBd0DxLTxTW1fSp7XWy58Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_095936_165397_ACA05EE3 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated. The safe replacement is strscpy(). This is a previous step in the path to remove the strlcpy() function entirely from the kernel [1]. [1] https://github.com/KSPP/linux/issues/89 Signed-off-by: Len Baker --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index 2f6f6468214d..9e3483f507ff 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -234,7 +234,7 @@ static int p2wi_probe(struct platform_device *pdev) if (IS_ERR(p2wi->regs)) return PTR_ERR(p2wi->regs); - strlcpy(p2wi->adapter.name, pdev->name, sizeof(p2wi->adapter.name)); + strscpy(p2wi->adapter.name, pdev->name, sizeof(p2wi->adapter.name)); irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel