From: Maxime Ripard <maxime@cerno.tech>
To: Rob Herring <robh@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles
Date: Wed, 18 Aug 2021 14:43:04 +0200 [thread overview]
Message-ID: <20210818124304.2jxsf44bcbprcvbk@gilmour> (raw)
In-Reply-To: <20210722022947.GA3168293@robh.at.kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 2355 bytes --]
Hi Rob, Sam,
On Wed, Jul 21, 2021 at 08:29:47PM -0600, Rob Herring wrote:
> On Wed, Jul 21, 2021 at 04:03:40PM +0200, Maxime Ripard wrote:
> > The binding mentions that all the drivers using that driver must use a
> > vendor-specific compatible but never enforces it, nor documents the
> > vendor-specific compatibles.
> >
> > Let's make we document all of them, and that the binding will create an
> > error if we add one that isn't.
> >
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > .../bindings/display/panel/lvds.yaml | 18 ++++++++++++------
> > 1 file changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > index 49460c9dceea..d1513111eb48 100644
> > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > @@ -31,12 +31,18 @@ allOf:
> >
> > properties:
> > compatible:
> > - contains:
> > - const: panel-lvds
> > - description:
> > - Shall contain "panel-lvds" in addition to a mandatory panel-specific
> > - compatible string defined in individual panel bindings. The "panel-lvds"
> > - value shall never be used on its own.
> > + items:
> > + - enum:
> > + - advantech,idk-1110wr
>
> At least this one is documented elsewhere.
Indeed, I missed it.
> You can add 'minItems: 2' if you want to just enforce having 2 compatibles. Or do:
>
> items:
> - {}
> - const: panel-lvds
>
> Which also enforces the order.
It's not just about the order since a missing compatible will also raise
a warning.
Some of those panels have a binding of their own, but some probably
won't (and I can't find anything specific about the one I'm most
interested in: tbs,a711-panel)
Can we have something like:
compatible:
oneOf:
- items:
- enum:
- tbs,a711-panel
- const: panel-lvds
- items:
- {}
- const: panel-lvds
That would work for both cases I guess?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-18 12:45 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 14:03 [PATCH 00/54] ARM: dts: Last round of DT schema fixes Maxime Ripard
2021-07-21 14:03 ` [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
2021-07-23 21:32 ` Rob Herring
2021-07-26 0:17 ` Mark Brown
2021-07-27 12:21 ` Richard Fitzgerald
2021-07-27 12:58 ` Mark Brown
2021-07-21 14:03 ` [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
2021-07-22 5:35 ` Samuel Holland
2021-07-22 7:58 ` Maxime Ripard
2021-07-21 14:03 ` [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
2021-07-23 21:35 ` Rob Herring
2021-07-21 14:03 ` [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
2021-07-23 21:36 ` Rob Herring
2021-07-21 14:03 ` [PATCH 05/54] dt-bindings: Convert Reserved Memory " Maxime Ripard
2021-07-21 14:30 ` Rob Herring
2021-08-18 10:00 ` Maxime Ripard
2021-08-18 12:54 ` Rob Herring
2021-07-22 2:09 ` Rob Herring
2021-07-21 14:03 ` [PATCH 06/54] dt-bindings: arm: Convert ARM CCI-400 " Maxime Ripard
2021-07-22 2:09 ` Rob Herring
2021-07-22 2:26 ` Rob Herring
2021-07-21 14:03 ` [PATCH 07/54] dt-bindings: bluetooth: broadcom: Fix clocks check Maxime Ripard
2021-07-23 21:38 ` Rob Herring
2021-07-21 14:03 ` [PATCH 08/54] dt-bindings: bluetooth: realtek: Add missing max-speed Maxime Ripard
2021-07-23 21:39 ` Rob Herring
2021-07-23 22:56 ` Alistair
2021-07-21 14:03 ` [PATCH 09/54] dt-bindings: clocks: Fix typo in the H6 compatible Maxime Ripard
2021-07-23 21:39 ` Rob Herring
2021-07-21 14:03 ` [PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles Maxime Ripard
2021-07-21 14:14 ` Sam Ravnborg
2021-07-22 2:09 ` Rob Herring
2021-07-22 2:29 ` Rob Herring
2021-08-18 12:43 ` Maxime Ripard [this message]
2021-08-18 13:48 ` Rob Herring
2021-08-23 16:31 ` Maxime Ripard
2021-07-21 14:03 ` [PATCH 11/54] dt-bindings: display: simple-bridge: Add corpro, gm7123 compatible Maxime Ripard
2021-07-21 14:16 ` Sam Ravnborg
2021-07-22 9:44 ` Maxime Ripard
2021-07-21 14:03 ` [PATCH 12/54] dt-bindings: gnss: Convert UBlox Neo-6M binding to a schema Maxime Ripard
2021-07-23 21:42 ` Rob Herring
2021-07-21 14:03 ` [PATCH 13/54] dt-bindings: gpio: Convert X-Powers AXP209 GPIO " Maxime Ripard
2021-07-22 2:09 ` Rob Herring
2021-07-22 2:13 ` Rob Herring
2021-07-21 14:03 ` [PATCH 14/54] dt-bindings: hwmon: Add IIO HWMON binding Maxime Ripard
2021-07-22 9:20 ` Jonathan Cameron
2021-07-22 9:34 ` Maxime Ripard
2021-07-23 21:44 ` Rob Herring
2021-07-21 14:03 ` [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check Maxime Ripard
2021-07-23 21:47 ` Rob Herring
2021-07-23 22:45 ` Linus Walleij
2021-07-21 14:03 ` [PATCH 16/54] dt-bindings: input: Convert ChipOne ICN8318 binding to a schema Maxime Ripard
2021-07-23 21:48 ` Rob Herring
2021-07-21 14:03 ` [PATCH 17/54] dt-bindings: input: Convert Pixcir Touchscreen " Maxime Ripard
2021-07-23 21:49 ` Rob Herring
2021-07-21 14:03 ` [PATCH 18/54] dt-bindings: input: Convert Regulator Haptic " Maxime Ripard
2021-07-23 21:50 ` Rob Herring
2021-07-21 14:03 ` [PATCH 19/54] dt-bindings: input: Convert Silead GSL1680 " Maxime Ripard
2021-07-23 21:51 ` Rob Herring
2021-07-21 14:03 ` [PATCH 20/54] dt-bindings: input: sun4i-lradc: Add wakeup-source Maxime Ripard
2021-07-23 21:52 ` Rob Herring
2021-07-21 14:03 ` [PATCH 21/54] dt-bindings: interconnect: sunxi: Add R40 MBUS compatible Maxime Ripard
2021-07-23 21:52 ` Rob Herring
2021-07-21 14:03 ` [PATCH 22/54] dt-bindings: media: Convert OV5640 binding to a schema Maxime Ripard
2021-07-22 2:09 ` Rob Herring
2021-07-21 14:03 ` [PATCH 23/54] dt-bindings: mfd: Convert X-Powers AC100 " Maxime Ripard
2021-07-23 21:54 ` Rob Herring
2021-08-01 12:15 ` [linux-sunxi] " Chen-Yu Tsai
2021-07-21 14:03 ` [PATCH 24/54] dt-bindings: mfd: Convert X-Powers AXP " Maxime Ripard
2021-07-22 2:09 ` Rob Herring
2021-07-21 14:03 ` [PATCH 25/54] dt-bindings: mmc: Convert MMC Card " Maxime Ripard
2021-07-23 21:57 ` Rob Herring
2021-08-04 11:24 ` Ulf Hansson
2021-07-21 14:03 ` [PATCH 26/54] dt-bindings: net: dwmac: Fix typo in the R40 compatible Maxime Ripard
2021-07-23 21:57 ` Rob Herring
2021-07-21 14:03 ` [PATCH 27/54] dt-bindings: net: wireless: Convert ESP ESP8089 binding to a schema Maxime Ripard
2021-07-23 21:58 ` Rob Herring
[not found] ` <20210806084709.0C279C4338A@smtp.codeaurora.org>
2021-08-18 8:45 ` Maxime Ripard
2021-07-21 14:03 ` [PATCH 28/54] dt-bindings: power: supply: axp20x: Add AXP803 compatible Maxime Ripard
2021-07-23 21:59 ` Rob Herring
2021-08-01 12:16 ` [linux-sunxi] " Chen-Yu Tsai
2021-08-06 21:33 ` Sebastian Reichel
2021-07-21 14:03 ` [PATCH 29/54] dt-bindings: power: supply: axp20x-battery: Add AXP209 compatible Maxime Ripard
2021-07-23 22:00 ` Rob Herring
2021-08-06 21:34 ` Sebastian Reichel
2021-07-21 14:04 ` [PATCH 30/54] dt-bindings: regulator: Convert SY8106A binding to a schema Maxime Ripard
2021-07-23 22:01 ` Rob Herring
2021-07-21 14:04 ` [PATCH 31/54] dt-bindings: sunxi: Add CPU Configuration Controller Binding Maxime Ripard
2021-07-23 22:01 ` Rob Herring
2021-07-21 14:04 ` [PATCH 32/54] dt-bindings: sunxi: Add Allwinner A80 PRCM Binding Maxime Ripard
2021-07-23 22:02 ` Rob Herring
2021-07-21 14:04 ` [PATCH 33/54] dt-bindings: thermal: Make trips node optional Maxime Ripard
2021-07-23 22:03 ` Rob Herring
2021-08-14 13:42 ` Daniel Lezcano
2021-07-21 14:04 ` [PATCH 34/54] dt-bindings: usb: Convert SMSC USB3503 binding to a schema Maxime Ripard
2021-07-23 22:08 ` Rob Herring
2021-07-21 14:04 ` [PATCH 35/54] dt-bindings: usb: dwc3: Fix usb-phy check Maxime Ripard
2021-07-23 22:15 ` Rob Herring
2021-07-29 12:29 ` Maxime Ripard
2021-07-21 14:04 ` [PATCH 36/54] dt-bindings: usb: ehci: Add Allwinner A83t compatible Maxime Ripard
2021-07-23 22:15 ` Rob Herring
2021-07-21 14:04 ` [PATCH 37/54] dt-bindings: usb: ohci: " Maxime Ripard
2021-07-23 22:16 ` Rob Herring
2021-07-21 14:04 ` [PATCH 38/54] dt-bindings: w1: Convert 1-Wire GPIO binding to a schema Maxime Ripard
2021-07-23 22:19 ` Rob Herring
2021-07-21 14:04 ` [PATCH 39/54] ARM: dts: sunxi: Rename power-supply names Maxime Ripard
2021-07-21 14:04 ` [PATCH 40/54] ARM: dts: sunxi: Rename gpio pinctrl names Maxime Ripard
2021-07-21 14:04 ` [PATCH 41/54] ARM: dts: sunxi: Fix OPP arrays Maxime Ripard
2021-07-21 14:04 ` [PATCH 42/54] ARM: dts: sunxi: Fix OPPs node name Maxime Ripard
2021-07-21 14:04 ` [PATCH 43/54] ARM: dts: sunxi: Fix the SPI NOR node names Maxime Ripard
2021-07-21 14:04 ` [PATCH 44/54] ARM: dts: v3s: Remove useless DMA properties Maxime Ripard
2021-07-21 14:04 ` [PATCH 45/54] ARM: dts: tbs711: Fix touchscreen compatible Maxime Ripard
2021-07-21 14:04 ` [PATCH 46/54] ARM: dts: cubieboard4: Remove the dumb-vga-dac compatible Maxime Ripard
2021-08-01 12:19 ` [linux-sunxi] " Chen-Yu Tsai
2021-07-21 14:04 ` [PATCH 47/54] arm64: dts: allwinner: h5: Fix GPU thermal zone node name Maxime Ripard
2021-07-21 14:04 ` [PATCH 48/54] arm64: dts: allwinner: h6: Fix de3 parent clocks ordering Maxime Ripard
2021-07-21 14:04 ` [PATCH 49/54] arm64: dts: allwinner: a100: Fix thermal zone node name Maxime Ripard
2021-07-21 14:04 ` [PATCH 50/54] arm64: dts: allwinner: pinetab: Change regulator node name to avoid warning Maxime Ripard
2021-07-21 14:04 ` [PATCH 51/54] arm64: dts: allwinner: teres-i: Add missing reg Maxime Ripard
2021-07-21 14:04 ` [PATCH 52/54] arm64: dts: allwinner: Remove regulator-ramp-delay Maxime Ripard
2021-07-22 5:55 ` Samuel Holland
2021-07-22 8:16 ` Maxime Ripard
2021-08-06 11:48 ` [linux-sunxi] " Icenowy Zheng
2021-08-06 12:05 ` Chen-Yu Tsai
2021-08-06 12:09 ` Icenowy Zheng
2021-07-21 14:04 ` [PATCH 53/54] arm64: dts: allwinner: teres-i: Remove wakekup-source from the PMIC Maxime Ripard
2021-07-21 14:04 ` [PATCH 54/54] arm64: dts: allwinner: pinephone: Fix BT SCO codec cells size Maxime Ripard
2021-07-21 16:48 ` [PATCH 00/54] ARM: dts: Last round of DT schema fixes Rob Herring
2021-07-29 12:03 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818124304.2jxsf44bcbprcvbk@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).