From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA4EC4338F for ; Wed, 18 Aug 2021 13:20:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62E3C6108E for ; Wed, 18 Aug 2021 13:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 62E3C6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LMagtgxMca1CQMFiXu/F9BgmIZKMpgVI2hcIUe38JzU=; b=rpPSsga63O8D7Z XahVBvw7mJ0zBlReL8iCuTs7QdrYuB8Gi9pCcWIwN9YbosQ9sfCvVswQPuAGpJnAo1imYoAYZ4mMS 9UHtRd9h7DLaCJ91ZZVR5SDCALqWJUdJc/XDdPXsCNkTftlajxzEbWqFMlezrYpbYLqzP4iip1w0t uq0EHj8+efmvshcmj+77fF/LboOoSXCIksuDVWB9KDMqd7Fp2XTYtziafYdPPU6pFbUCL8ZNnJ9lh 4+op14Bt2iWuAkJm4w/kEaOh7sdWyUol2XwOxbrvar9HUZM9iuJQeHXmXyG8OfkaXWFsJ4+Meh2ns tD8EzSucDkxcDctqZCkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGLSF-005fSq-9E; Wed, 18 Aug 2021 13:18:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGLSB-005fSN-AW for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 13:18:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 968B76108F; Wed, 18 Aug 2021 13:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629292679; bh=JlUFeNxsEk8ffbZ4STeULEr4uHA+Xv6pEtdyqf9Ea4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ReG+ER0rC7KxI+2srUFAOcPJZJSz3c2oz48BBu46iYswAb9jZFOWxXhLuKxAcimIX DjbXuVbs8PMt+XwbaUqcZD7T8/mgqBOs5TZvwBceHd2LO1wZZfjpd8iSPertpCTwdH L/mbn4Z4XrMNrCdgPRzjhkwKKRoWzMwHgdZGPW7XsZD2UBThC4EoObciO2qK3TjvH1 qpWP/Um3VYghocI24UCPlREOoXOBa3MBU9UAaKJXOCHsoXjakHbIRQI7CqiFkSHys7 b+Z89GvnyDj0Ck+DWAdb8S8m/90mkzktvSoEGyjEMADHbxESbiSxU8kX2kbAPD1ieW /LqDqCl5W1irA== Date: Wed, 18 Aug 2021 14:17:53 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v4 07/15] KVM: arm64: Keep mdcr_el2's value as set by __init_el2_debug Message-ID: <20210818131752.GE14107@willie-the-truck> References: <20210817081134.2918285-1-tabba@google.com> <20210817081134.2918285-8-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210817081134.2918285-8-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_061759_420122_77DA3D19 X-CRM114-Status: UNSURE ( 8.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 17, 2021 at 09:11:26AM +0100, Fuad Tabba wrote: > __init_el2_debug configures mdcr_el2 at initialization based on, > among other things, available hardware support. Trap deactivation > doesn't check that, so keep the initial value. > > No functional change intended. However, the value of mdcr_el2 > might be different after deactivating traps than it was before > this patch. I think this sentence is very confusing, so I'd remove it. I also don't think it's correct, as the EL2 initialisation code only manipulates the bits which are being masked here. So with that sentence removed: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel