From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695B7C4338F for ; Tue, 24 Aug 2021 08:49:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C469610D0 for ; Tue, 24 Aug 2021 08:49:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C469610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kLoUM1H5iKLJoLoaPOHJk6ttw6BxD5z1QKDSQnjJhSk=; b=q7uDBZKJNwBg8v iVzQDTrCfyz2ok6/90IJa2S3fvAs7UDhH2D66PTstBSW44mk8E0IKzPu8/0Lkbb5c8HQzJp/FkZRB GUI49A4GGdJtOQK6xfVsbbBOwauoJaqEJ6TbEOcFoXmMCshE8kyvzk/AtDwT5k96OLQzkFJwCr1Sl yoNw4oSVYAtNzPRcU/DcVPwBrFSAOducYtVC6JU1LMR5uNJ7Ia7rr6wGl7zQ9XUk0smIg4QxB7aFQ kaPmjn/2cJnJsIDmT8mNwa2HZ32NQoAfDIoW4NKUiMJ0f9N4KxYpU5m3QmpCZ1rJI4E0ghoJlP7qW q+LWZUpKBIaQm5Y6IkJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIS5m-002DS6-LT; Tue, 24 Aug 2021 08:47:34 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIS5g-002DQv-P6 for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 08:47:32 +0000 Received: by mail-pj1-x1036.google.com with SMTP id mw10-20020a17090b4d0a00b0017b59213831so1325364pjb.0 for ; Tue, 24 Aug 2021 01:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tVJAPvgMbNMhxKXeO03R+hvScbq+4VlPa0BONKG03BI=; b=OZM/afBgpyVQNHRrSarWgAojEw2soUXGQh9h6ar4I9ajCIv9dZOpX6cavspPTyl0Ys BiPBXCYdmJ8b/Vt0bucTBHRVM2rv5rI5nrBJTbHNd6ikCMbC+9qu3eEwIl+sTyRsoX2z vEMbtb/XaOyn3yKZ3180nL7zOrw1PPyKD71c26BfyD5X3tRsi5E3uIJzODi4A8VPLvEq CXrUgpV6be+NDKcjg8WL+sxWhXstM1Zc8p3qLjfKQq4cWxomD1wK8RPBNTaa/UYjq719 QT97KcKkv/IusGpcd3YMaT0mplIl1isyBpa+kWr6bbG5vEakL6BZRm0lHsm23qIELGiV KsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tVJAPvgMbNMhxKXeO03R+hvScbq+4VlPa0BONKG03BI=; b=m7qSSMLmCeS4cq6xM9u8Mnn3Pk0uXKJxYU7rvpZ0XuO/ttrBl7bxrfd+EAgALLFnaB bsO/WdJ99KBAjHe7akJBrF0hg8Zt0QX1G8Ik5LWbSAUF3GdUBoBbDHZ5bt24ASWFiz2p e1Rsy8tpAGOyxDjVDih+NzCpHeCb/uGLz7MN/8uz2e5jQ9m9DaswJhrnYEZ3msmtolOc MFb70G7lW0270RXVLcxGu6jXdFPU4DkafdF1gIU4HFBXleFVtkVo4QlH1gJ4GWKTvtlA U8jlaK1NG6ugGxdHGK04QoubMY8/AeIK89ozrqHh1wfwXk/oH3EEktfUWGHROsGysTSk k9+A== X-Gm-Message-State: AOAM531DLSJSRGsZyfsoq38oiMTh4mCQlqluw59SBG55j3n6JoVYK4ap lbDOoVGANoZMd5ZqfuC+livgEg== X-Google-Smtp-Source: ABdhPJzLsDqCQjs9/UG+SPzsKTBx3iLUeU+n5rJbxZCsyzTYuB7pN12asph1b+jsKUJm3U94dvzPYg== X-Received: by 2002:a17:90b:116:: with SMTP id p22mr3289987pjz.67.1629794847869; Tue, 24 Aug 2021 01:47:27 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id f137sm18728068pfa.160.2021.08.24.01.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 01:47:27 -0700 (PDT) Date: Tue, 24 Aug 2021 16:47:20 +0800 From: Leo Yan To: James Clark Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] Support ETE decoding Message-ID: <20210824084720.GG204566@leoy-ThinkPad-X240s> References: <20210806134109.1182235-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210806134109.1182235-1-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_014728_885918_772BBFB0 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, Suzuki, Mike, On Fri, Aug 06, 2021 at 02:41:00PM +0100, James Clark wrote: > Changes since v1: > * Re-implement with a new magic number instead of piggybacking on ETMv4 > * Improve comments and function name around cs_etm_decoder__get_etmv4_arch_ver() > * Add a warning for unrecognised magic numbers > * Split typo fix into new commit > * Add Leo's reviewed-by tags > * Create a new struct for ETE config (cs_ete_trace_params) instead of re-using ETMv4 config > > Applies to perf/core f3c33cbd922 > Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-ete-v2 I have finished the review for this patch series and it's good form for me. Since this patch series is to enable new feature for ETE, it's good if any of you could review as well before merging. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel