From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/sve: Better handle failure to allocate SVE register storage
Date: Tue, 24 Aug 2021 11:32:14 +0100 [thread overview]
Message-ID: <20210824103213.GA623@arm.com> (raw)
In-Reply-To: <20210817171330.25847-1-broonie@kernel.org>
On Tue, Aug 17, 2021 at 06:13:30PM +0100, Mark Brown wrote:
> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
> index eb8d972ad3d2..5a294f20e9de 100644
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -520,12 +520,6 @@ void sve_alloc(struct task_struct *task)
> /* This is a small allocation (maximum ~8KB) and Should Not Fail. */
> task->thread.sve_state =
> kzalloc(sve_state_size(task), GFP_KERNEL);
> -
> - /*
> - * If future SVE revisions can have larger vectors though,
> - * this may cease to be true:
> - */
> - BUG_ON(!task->thread.sve_state);
> }
I think we should keep a WARN_ON_ONCE here in case one wonders why the
app was suddenly killed.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-24 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 17:13 [PATCH] arm64/sve: Better handle failure to allocate SVE register storage Mark Brown
2021-08-24 10:32 ` Catalin Marinas [this message]
2021-08-24 12:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824103213.GA623@arm.com \
--to=catalin.marinas@arm.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).