From: Guenter Roeck <linux@roeck-us.net>
To: Jian Cai <jiancai@google.com>
Cc: mike.leach@linaro.org, dianders@chromium.org, mka@chromium.org,
manojgupta@google.com, llozano@google.com,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
clang-built-linux@googlegroups.com,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Leo Yan <leo.yan@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: syscfg: fix compiler warnings
Date: Thu, 26 Aug 2021 08:49:03 -0700 [thread overview]
Message-ID: <20210826154903.GA4082743@roeck-us.net> (raw)
In-Reply-To: <20210825222514.2107728-1-jiancai@google.com>
On Wed, Aug 25, 2021 at 03:25:14PM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL);
> ^[[0;1;32m ^
You might want to split this into multiple lines and remove the ANSI
escape codes. Otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
>
> Signed-off-by: Jian Cai <jiancai@google.com>
> ---
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "coresight-config.h"
> #include "coresight-etm-perf.h"
> --
> 2.33.0.259.gc128427fd7-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-26 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 22:25 [PATCH] coresight: syscfg: fix compiler warnings Jian Cai
[not found] ` <CA+SOCLLyKaEmCSrSNUKfpgPmUxcu8RyZLqZxpmw87BiO=m84Mg@mail.gmail.com>
2021-08-25 22:33 ` Jian Cai
2021-08-26 15:49 ` Guenter Roeck [this message]
2021-08-26 16:19 ` Doug Anderson
2021-08-26 16:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826154903.GA4082743@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=coresight@lists.linaro.org \
--cc=dianders@chromium.org \
--cc=jiancai@google.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mka@chromium.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).