From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C8BC4320A for ; Sun, 29 Aug 2021 15:48:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D4160F44 for ; Sun, 29 Aug 2021 15:48:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43D4160F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0hfz0tHNYO+2iAPwmmQKWWlwajTnjgybHfksivL1eN8=; b=3KAUWUBiftxgZ/ oQd4TRH+KLUnFnFS5HJshUh4NRsN8WinCGNow2miOAOds70XAl6TN3B53lbgAsL75U2iWKK69X/sP 3+kLRJSD/adPRI26EOwK0BhrB//7tRu8EaGNPWjeQiPbPqLJ9dBouA4RBxovb1U85qSiUYXZHOzeH JYg81PtvF7uAjWW/r0ma8CTOZqQGs/3ekEYzBSVxBK8GmPNtFNFhImlgq8bnBE8al1UYFyyRlgvKb xENVtmFzyFEaNFHthf730YK8iSsNoyLaj6QOUkOkpKMNsSxLbmJbvwZZffegiQbpn0p04QMwVTpoB uk+arEAYTdF0U4s/B9+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKN0s-00FjLM-Pr; Sun, 29 Aug 2021 15:46:26 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKN0q-00FjL7-QX for linux-arm-kernel@bombadil.infradead.org; Sun, 29 Aug 2021 15:46:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=EVVZvBkzErll1LLerV9wNrPxMuepByY9qtPuibcKLng=; b=gFLSxloGls4plWDQdf6SLKxTCy /GYmP2SGrk8SOB8aP06e+ng1VZH6/Fb62UCqZsmsb1HfKb7r1GUhUWqqs9NDzRdoev9lvtf2ZKk2k ppfAO6xGt2eqeyidVbYHggP6Ey8IlR5l9psEIgRnL5Pj0UTdccVgqkte16/oPcWZISwPgj1UlaJ7j 1iAy4rzkmA450cuUa7a9qjdmJm55ZHTdf8EViBLodI3QivZ8D7JQh9lyJo8P7W46n63DAGTxsFPpz vEFj0vIhsoCwkCxNH8OCQoAd1ex5x1PV4Vp7AmDWkWqKfsKshhd3dFPwI+L2dJFy/apIJpxIKUR3q MBo2Lz6Q==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKMNf-00E9Yw-JU for linux-arm-kernel@lists.infradead.org; Sun, 29 Aug 2021 15:05:57 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFDBB60F36; Sun, 29 Aug 2021 15:05:45 +0000 (UTC) Date: Sun, 29 Aug 2021 16:08:56 +0100 From: Jonathan Cameron To: Billy Tsai Cc: , , , , , , , , , , , , , Subject: Re: [RESEND v4 03/15] iio: adc: aspeed: set driver data when adc probe. Message-ID: <20210829160856.12dd9395@jic23-huawei> In-Reply-To: <20210824091243.9393-4-billy_tsai@aspeedtech.com> References: <20210824091243.9393-1-billy_tsai@aspeedtech.com> <20210824091243.9393-4-billy_tsai@aspeedtech.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210829_160555_865241_489F0B25 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Aug 2021 17:12:31 +0800 Billy Tsai wrote: > Fix the issue when adc remove will get the null driver data. > > Signed-off-by: Billy Tsai This is a fix that we should probably backport. Please add a fixes tag and move it to the start of the series so I can pick it during this kernel cycle rather than waiting for the next one. Thanks, Jonathan > --- > drivers/iio/adc/aspeed_adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c > index 7010d56ac3b9..20462cf659e4 100644 > --- a/drivers/iio/adc/aspeed_adc.c > +++ b/drivers/iio/adc/aspeed_adc.c > @@ -201,6 +201,7 @@ static int aspeed_adc_probe(struct platform_device *pdev) > > data = iio_priv(indio_dev); > data->dev = &pdev->dev; > + platform_set_drvdata(pdev, indio_dev); > > data->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(data->base)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel