From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B89C433EF for ; Tue, 21 Sep 2021 15:49:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCAFA610A1 for ; Tue, 21 Sep 2021 15:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BCAFA610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FmweZSldKCqk3sTQKV+heoeggHYswGtw9A1zTUvUB5g=; b=OiZjDGRx9wpcB9 Pf5DT1XhLzUBIAYh0KOR05GbOtU5OMYrHvkHULJqmKj2r86wamHlKURqI1EiR5NlV+kLb45QOoone OVRaTxRKmb6h6/HdV07rGlJQTJRL57mNIiFoURBQO4iLabGSxVtJ/BcmPw+a0RsO23vP/avF6YMT/ jeHRGRqdlbnxYTMRAZGWKkiuebYaUsQvATzrRRdW4lrkHxFnIcYwbBXSUnBnX39KfK1QnP43gqnQj 07MAYFVwEvE547W0lRO+YZGkfgrGjbtflDUVl2iUANsUha2nbcEkMumG+BmvZ5XawEDl88UpVMQFl yl5jAZ840+/2Z8nIy4KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mShzk-004xXd-EJ; Tue, 21 Sep 2021 15:47:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mShzf-004xWb-RD for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 15:47:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19BFA113E; Tue, 21 Sep 2021 08:47:37 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D7233F718; Tue, 21 Sep 2021 08:47:36 -0700 (PDT) Date: Tue, 21 Sep 2021 16:47:31 +0100 From: Lorenzo Pieralisi To: Yajun Deng Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq() helper function Message-ID: <20210921154731.GA2756@lpieralisi> References: <20210826060406.12571-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210826060406.12571-1-yajun.deng@linux.dev> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_084740_004076_AE3F5795 X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 26, 2021 at 02:04:06PM +0800, Yajun Deng wrote: > pcibios_alloc_irq() will be called in pci_device_probe(), but there > hasn't pcibios_free_irq() in arm64 architecture correspond it. > pcibios_free_irq() is an empty weak function in drivers/pci/pci-driver.c. "pcibios_alloc_irq() is a weak function called to allocate IRQs for a device in pci_device_probe(); arm64 implements it with ACPI specific code to enable IRQs for a device. When a device is removed (pci_device_remove()) the pcibios_free_irq() counterpart is called. Current arm64 code does not implement a pcibios_free_irq() function, and therefore, the weak empty stub is executed, which means that the IRQ for a device are not properly disabled when a device is removed. Add an arm64 pcibios_free_irq() to undo the actions carried out in pcibios_alloc_irq()." This is a stub commit log. Then you need to describe the bug you are fixing (if any, or it is just code inspection ?) > So add pcibios_free_irq() for correspond it. This will be called > in pci_device_remove(). > > ==================== > v2: remove the change in pcibios_alloc_irq(), and modify the commit log. > ==================== Don't add versioning in the commit log, it does not belong here. I don't think we should send this to stable kernels straight away, it is best to make sure we are not triggering any regressions first. Lorenzo > Signed-off-by: Yajun Deng > --- > arch/arm64/kernel/pci.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 2276689b5411..6ffd92126f65 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -29,6 +29,13 @@ int pcibios_alloc_irq(struct pci_dev *dev) > > return 0; > } > + > +void pcibios_free_irq(struct pci_dev *dev) > +{ > + if (!acpi_disabled) > + acpi_pci_irq_disable(dev); > +} > + > #endif > > /* > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel