From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8A4C433F5 for ; Fri, 24 Sep 2021 10:23:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2BE261107 for ; Fri, 24 Sep 2021 10:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2BE261107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uSjofUETK1NXfC0TikSyRhg0lFLPaGRhdSWPc8GHIYk=; b=OAZpJcMHNLT8bb TSe1//DM/LO1lpowsg6TEzAzs2R1A+oop5lGkz94O2YW0z6AyHl+bW5VCZKxlSyowPvyPRcWKt+WO TEBsW1qTIWzo1/Fj6BQRPtkWI0v8k64b+G99dNtMv5YxLZqNiEzcNRKHRlxEDMLeGhXSRRcuZf2V8 D4SlHEj9iCFCFd82XogvgAFCJU6SURvaR7K8CAXy6tyRvjjYhEXm+2eghBh1OhwPcLmgxka/o8v8s WJjbjjzPNyw3Fo3jpUSSV66CQMf3eLfihbVoVeivI0Ftf7HHLqX9898auiVQqx535wvBgrJO7mnpm 1tY4Kts3Wwn61u9Zhkrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTiL4-00E6IO-1x; Fri, 24 Sep 2021 10:21:54 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTiL0-00E6Hs-6q for linux-arm-kernel@lists.infradead.org; Fri, 24 Sep 2021 10:21:51 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id A6EB5E119D; Fri, 24 Sep 2021 03:21:19 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wtAukYPPuay0; Fri, 24 Sep 2021 03:21:18 -0700 (PDT) From: Martin Kepplinger To: abel.vesa@nxp.com Cc: a.fatoum@pengutronix.de, adrian.hunter@intel.com, aisheng.dong@nxp.com, catalin.marinas@arm.com, cw00.choi@samsung.com, devicetree@vger.kernel.org, djakov@kernel.org, festevam@gmail.com, kernel@pengutronix.de, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, myungjoo.ham@samsung.com, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, ulf.hansson@linaro.org, will.deacon@arm.com, Martin Kepplinger Subject: Re: [RFC 00/19] Add interconnect and devfreq support for i.MX8MQ Date: Fri, 24 Sep 2021 12:20:26 +0200 Message-Id: <20210924102026.2679952-1-martin.kepplinger@puri.sm> In-Reply-To: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com> References: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210924_032150_277563_38B132E1 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org hi Abel, thank you for the update (this is actually v2 of this RFC right?)! all in all this runs fine on the imx8mq (Librem 5 and devkit) I use. For all the pl301 nodes I'm not yet sure what I can actually test / switch frequencies. But I still have one problem: lcdif/mxfb already has the interconnect dram DT property and I use the following call to request bandwidth: https://source.puri.sm/martin.kepplinger/linux-next/-/commit/d690e4c021293f938eb2253607f92f5a64f15688 (mainlining this is on our todo list). With your patchset, I get: [ 0.792960] genirq: Flags mismatch irq 30. 00000004 (mxsfb-drm) vs. 00000004 (mxsfb-drm) [ 0.801143] mxsfb 30320000.lcd-controller: Failed to install IRQ handler [ 0.808058] mxsfb: probe of 30320000.lcd-controller failed with error -16 so the main devfreq user (mxsfb) is not there :) why? and when I remove the interconnect property from the lcdif DT node, mxsfb probes again, but of course it doesn't lower dram freq as needed. Do I do the icc calls wrong in mxsfb despite it working without your patchset, or may there be something wrong on your side that breaks the mxsfb IRQ? again thanks a lot for working on this! I'm always happy to test. martin --- .../boot/dts/freescale/imx8mq-librem5.dtsi | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index 6fac6676f412..8496a90f23bf 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi @@ -381,26 +381,6 @@ &A53_3 { cpu-supply = <&buck2_reg>; }; -&ddrc { - operating-points-v2 = <&ddrc_opp_table>; - - ddrc_opp_table: ddrc-opp-table { - compatible = "operating-points-v2"; - - opp-25M { - opp-hz = /bits/ 64 <25000000>; - }; - - opp-100M { - opp-hz = /bits/ 64 <100000000>; - }; - - opp-800M { - opp-hz = /bits/ 64 <800000000>; - }; - }; -}; - &dphy { status = "okay"; }; -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel