From: Will Deacon <will@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: yajun.deng@linux.dev, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq() helper function
Date: Mon, 11 Oct 2021 12:09:41 +0100 [thread overview]
Message-ID: <20211011110940.GC4068@willie-the-truck> (raw)
In-Reply-To: <20210922162201.GA24429@lpieralisi>
On Wed, Sep 22, 2021 at 05:22:01PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 22, 2021 at 02:49:13AM +0000, yajun.deng@linux.dev wrote:
> > September 21, 2021 11:47 PM, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com> wrote:
> >
> > > On Thu, Aug 26, 2021 at 02:04:06PM +0800, Yajun Deng wrote:
> > >
> > >> pcibios_alloc_irq() will be called in pci_device_probe(), but there
> > >> hasn't pcibios_free_irq() in arm64 architecture correspond it.
> > >> pcibios_free_irq() is an empty weak function in drivers/pci/pci-driver.c.
> > >
> > > "pcibios_alloc_irq() is a weak function called to allocate IRQs for
> > > a device in pci_device_probe(); arm64 implements it with
> > > ACPI specific code to enable IRQs for a device.
> > >
> > > When a device is removed (pci_device_remove()) the pcibios_free_irq()
> > > counterpart is called.
> > >
> > > Current arm64 code does not implement a pcibios_free_irq() function,
> > > and therefore, the weak empty stub is executed, which means that the
> > > IRQ for a device are not properly disabled when a device is removed.
> > >
> > > Add an arm64 pcibios_free_irq() to undo the actions carried out in
> > > pcibios_alloc_irq()."
> > >
> > > This is a stub commit log. Then you need to describe the bug you
> > > are fixing (if any, or it is just code inspection ?)
> > >
> > It is just code inspection.
>
> Before merging it it must be tested, which would prove it is needed.
Ok, I'll ignore this patch for now then. Please yell if you want me to pick
it up.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-10-11 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 6:04 [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq() helper function Yajun Deng
2021-09-21 13:47 ` Catalin Marinas
2021-09-21 15:47 ` Lorenzo Pieralisi
2021-09-22 2:49 ` yajun.deng
2021-09-22 16:22 ` Lorenzo Pieralisi
2021-10-11 11:09 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011110940.GC4068@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).