From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4C6C433EF for ; Mon, 11 Oct 2021 18:11:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B19F60EB4 for ; Mon, 11 Oct 2021 18:11:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B19F60EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mAPRB54QuEj9YEU/xCEI5z1QsYJnjPN0kUG5nYOQSmQ=; b=2AdB34+SKakkBK f+n1P3l0jHEZhSL48LoHwjYAhQ6cUYlzR+MYLGgU9zpbEa6Y+5qVzrCtRQzlmdQkbsBV7yQWgZkPk vWW8noP59tml7Jx3M2RDbKeAiJMdOaJBXR8b9H5CDGoNYNYWBbn/RVNOsXauciYrAErFrpNtyB0eY zxm+ZK+bbl9oggwYsGFnQouHdDQmhaX/6p4egO7YPMluMdfvXaQPL/01CQM35gRcJmyobC9iSxqA6 TFhIxD8G7DDeqbMt70Aydopj2M2MjpRcUBhibqWABJFTSmlgR5fQoSMd4r5xa5m+I+stFP0v6JTT2 t1ok0jc6d5ZPbY4PX3WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZzjN-00ALiR-Ub; Mon, 11 Oct 2021 18:08:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZzjK-00ALhe-Ey for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 18:08:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F72C60EB4; Mon, 11 Oct 2021 18:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633975733; bh=znvt7lXTrjz8Q7uFKJ50VwboQPdEorWs9uuIA7tBazI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CzTduaqzuCsLQPm6VXtRH2KVlfxrgwAeezXN8LIoJto9GnO4HarUxbwIRF+OXLcgG CwjE9u/52RytsnFKZXPva+CQiHJKAq/NFa2ZmAqb/yFosQ/JPVq21eChF9PyUjT+c+ JXeH2y/MI9mOL2FudCVWGv25ImJZ9uCWOIBxZTkYR0gb04FM/UPGgaPr1I9bbli7KU QNwiHCeyh2xqZhtEF3dAb6yC1vqU3uVrehkvxsEL/KNcAfrkS5RKkiabqdcMlRVqI7 5k6FV2b6Czrb9x0v2JiS1x71z3B1jTS3qqvG6HzllevLVtGJEuQbPnQYLvVV7st0us g4NT/kEUJrdGg== Received: by pali.im (Postfix) id 0B6BB7C9; Mon, 11 Oct 2021 20:08:50 +0200 (CEST) Date: Mon, 11 Oct 2021 20:08:50 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Naveen Naidu Cc: bhelgaas@google.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:PCI DRIVER FOR AARDVARK (Marvell Armada 3700)" Subject: Re: [PATCH 09/22] PCI: aardvark: Use SET_PCI_ERROR_RESPONSE() when device not found Message-ID: <20211011180850.hgp4ctykvus37fx7@pali> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_110854_539312_9495DA4D X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 11 October 2021 23:26:33 Naveen Naidu wrote: > An MMIO read from a PCI device that doesn't exist or doesn't respond > causes a PCI error. There's no real data to return to satisfy the > CPU read, so most hardware fabricates ~0 data. > > Use SET_PCI_ERROR_RESPONSE() to set the error response, when a faulty > read occurs. > > This helps unify PCI error response checking and make error check > consistent and easier to find. > > Compile tested only. > > Signed-off-by: Naveen Naidu > --- > drivers/pci/controller/pci-aardvark.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index 596ebcfcc82d..dc2f820ef55f 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -894,7 +894,7 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > int ret; > > if (!advk_pcie_valid_device(pcie, bus, devfn)) { > - *val = 0xffffffff; > + SET_PCI_ERROR_RESPONSE(val); Hello! Now I'm looking at this macro, and should not it depends on "size" argument? If doing 8-bit or 16-bit read operation then should not it rather sets only low 8 bits or low 16 bits to ones? > return PCIBIOS_DEVICE_NOT_FOUND; > } > > @@ -920,7 +920,7 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > *val = CFG_RD_CRS_VAL; > return PCIBIOS_SUCCESSFUL; > } > - *val = 0xffffffff; > + SET_PCI_ERROR_RESPONSE(val); > return PCIBIOS_SET_FAILED; > } > > @@ -955,14 +955,14 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, > *val = CFG_RD_CRS_VAL; > return PCIBIOS_SUCCESSFUL; > } > - *val = 0xffffffff; > + SET_PCI_ERROR_RESPONSE(val); > return PCIBIOS_SET_FAILED; > } > > /* Check PIO status and get the read result */ > ret = advk_pcie_check_pio_status(pcie, allow_crs, val); > if (ret < 0) { > - *val = 0xffffffff; > + SET_PCI_ERROR_RESPONSE(val); > return PCIBIOS_SET_FAILED; > } > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel