From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B42C433EF for ; Thu, 14 Oct 2021 16:22:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A1D260E97 for ; Thu, 14 Oct 2021 16:22:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A1D260E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UJZy9ebE0313obZslN1NR/qcgcYJszJr1Us+yPvL1II=; b=iR2v6YNDvlHWyC ffUhtwTYMHhOgofqFbDPbIvE8j5D7ucecMkgVDQtIZ2YkQeVQdVQAJ6lhrNZjkhU0SrcOObeo32Sp PEyI0qCvw52LW/bbp+532WkD8188Be64pde91Oy43VZm94i4QRTtquWqllu2FLDGEhTsrc4gZZ2ni ByCn7i0FV7NFu+vqzfxNuxgGS+rfDUE7Yroh/eSpIYfttIqWTtleANeMITOtGliKF4OsL7eeJ+1AT 09tG8idhKXHI1+RuD7/AqilfOECVj4FESdzcs3YNrO2vSEnr8zhWGP2WV2Jx5WNs4HUch1wJqc1VK TYckail744XP2u+hgYyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3TP-003pNv-TF; Thu, 14 Oct 2021 16:20:52 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3TL-003pMY-Dn for linux-arm-kernel@lists.infradead.org; Thu, 14 Oct 2021 16:20:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634228445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/x0GMWtXzbHVSq1sXMLR+bmmD/sS6+vnmT+tCy96wk=; b=Xe7lzAJj6gxj2OtO71TRwGWs8iTIpCS4RNr3k4RW/VVWHCKirTvdV7OHA8s9feea/AfRt0 pXP4hW7v1w/CKDXL8sWI2cu3qV3ZN8VKmXgHuG+tYzsJ590OzGVkUtWKTNJ9u6RTdastB4 /DHEiQQJzbottWOCC1X7iKkH1FJv4rM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-eqjyrXKfNiWUZ2Rd2oVPTQ-1; Thu, 14 Oct 2021 12:20:44 -0400 X-MC-Unique: eqjyrXKfNiWUZ2Rd2oVPTQ-1 Received: by mail-qv1-f69.google.com with SMTP id if11-20020a0562141c4b00b0038317257571so6038023qvb.3 for ; Thu, 14 Oct 2021 09:20:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f/x0GMWtXzbHVSq1sXMLR+bmmD/sS6+vnmT+tCy96wk=; b=Es4mr+Oon7cDXvSfTKgmA0VoibVVfUUrjRSG5KtXeMLl+jwSX60m7/AGWci2brDKwQ VSRF3+e6kBn2j9JGdXNF8+TD7Y9mh6XbctS0zUEgJcYXFn6iam81b1xor3xcsYwl1u3N 24veTaTpuA3oxs6PGLGlF5twrmCEW20oPgzhzvGJ68YwSzaHfr8yiCxtP5ttsLlJDicz Sk+FPI2IqkcNk0WHx2IITf42JafGT5+oQUxoo3uSCj9l8V+r5Estx8D2ZRohjFeab57Q blMTmz6pex+B1V1xJ5/08DChaWqT70NEk2GKAMuB1CJVeMgNRdJVJGeJehMjaaG3dWl1 VGWg== X-Gm-Message-State: AOAM532VU+ADmBr6F0dJN8tBE7fdvL40n2DgDWwiJR+ULvXQnT8Pqe1t fy5XkW3x5JLvmXw3JBAin8kueeEpJD4zKhcLXBl5yy/jY1H6bqiDDYM6LgxhQQc2BVSB+GQR3R+ Iq1Db/LN7QHdswZFjDEr1XqM5RrIXtLkSWbQ= X-Received: by 2002:ac8:10a:: with SMTP id e10mr7607145qtg.406.1634228444124; Thu, 14 Oct 2021 09:20:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP6s5Caxb2ESan17RuUDUYd/oN90Ga/T3lVfd6666txoozRp5nG/hxM/ybPlKlcMqK0iKAQQ== X-Received: by 2002:ac8:10a:: with SMTP id e10mr7607116qtg.406.1634228443916; Thu, 14 Oct 2021 09:20:43 -0700 (PDT) Received: from gator (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id f15sm1578546qtm.37.2021.10.14.09.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 09:20:43 -0700 (PDT) Date: Thu, 14 Oct 2021 18:20:38 +0200 From: Andrew Jones To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, pbonzini@redhat.com, oupton@google.com, qperret@google.com, kernel-team@android.com, tabba@google.com Subject: Re: [PATCH v9 14/22] KVM: arm64: pkvm: Make the ERR/ERX*_EL1 registers RAZ/WI Message-ID: <20211014162038.cxdoedqlbsxtzw5l@gator> References: <20211010145636.1950948-12-tabba@google.com> <20211013120346.2926621-1-maz@kernel.org> <20211013120346.2926621-4-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20211013120346.2926621-4-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_092047_581595_A7BAB24E X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 01:03:38PM +0100, Marc Zyngier wrote: > The ERR*/ERX* registers should be handled as RAZ/WI, and there > should be no need to involve EL1 for that. > > Add a helper that handles such registers, and repaint the sysreg > table to declare these registers as RAZ/WI. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/nvhe/sys_regs.c | 33 ++++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c > index f125d6a52880..042a1c0be7e0 100644 > --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c > +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c > @@ -248,6 +248,16 @@ static u64 read_id_reg(const struct kvm_vcpu *vcpu, > return pvm_read_id_reg(vcpu, reg_to_encoding(r)); > } > > +/* Handler to RAZ/WI sysregs */ > +static bool pvm_access_raz_wi(struct kvm_vcpu *vcpu, struct sys_reg_params *p, > + const struct sys_reg_desc *r) > +{ > + if (!p->is_write) > + p->regval = 0; > + > + return true; > +} > + > /* > * Accessor for AArch32 feature id registers. > * > @@ -270,9 +280,7 @@ static bool pvm_access_id_aarch32(struct kvm_vcpu *vcpu, > BUILD_BUG_ON(FIELD_GET(ARM64_FEATURE_MASK(ID_AA64PFR0_EL1), > PVM_ID_AA64PFR0_RESTRICT_UNSIGNED) > ID_AA64PFR0_ELx_64BIT_ONLY); > > - /* Use 0 for architecturally "unknown" values. */ > - p->regval = 0; > - return true; > + return pvm_access_raz_wi(vcpu, p, r); > } > > /* > @@ -301,6 +309,9 @@ static bool pvm_access_id_aarch64(struct kvm_vcpu *vcpu, > /* Mark the specified system register as an AArch64 feature id register. */ > #define AARCH64(REG) { SYS_DESC(REG), .access = pvm_access_id_aarch64 } > > +/* Mark the specified system register as Read-As-Zero/Write-Ignored */ > +#define RAZ_WI(REG) { SYS_DESC(REG), .access = pvm_access_raz_wi } > + > /* Mark the specified system register as not being handled in hyp. */ > #define HOST_HANDLED(REG) { SYS_DESC(REG), .access = NULL } > > @@ -388,14 +399,14 @@ static const struct sys_reg_desc pvm_sys_reg_descs[] = { > HOST_HANDLED(SYS_AFSR1_EL1), > HOST_HANDLED(SYS_ESR_EL1), > > - HOST_HANDLED(SYS_ERRIDR_EL1), > - HOST_HANDLED(SYS_ERRSELR_EL1), > - HOST_HANDLED(SYS_ERXFR_EL1), > - HOST_HANDLED(SYS_ERXCTLR_EL1), > - HOST_HANDLED(SYS_ERXSTATUS_EL1), > - HOST_HANDLED(SYS_ERXADDR_EL1), > - HOST_HANDLED(SYS_ERXMISC0_EL1), > - HOST_HANDLED(SYS_ERXMISC1_EL1), > + RAZ_WI(SYS_ERRIDR_EL1), > + RAZ_WI(SYS_ERRSELR_EL1), > + RAZ_WI(SYS_ERXFR_EL1), > + RAZ_WI(SYS_ERXCTLR_EL1), > + RAZ_WI(SYS_ERXSTATUS_EL1), > + RAZ_WI(SYS_ERXADDR_EL1), > + RAZ_WI(SYS_ERXMISC0_EL1), > + RAZ_WI(SYS_ERXMISC1_EL1), > > HOST_HANDLED(SYS_TFSR_EL1), > HOST_HANDLED(SYS_TFSRE0_EL1), > -- > 2.30.2 > Reviewed-by: Andrew Jones _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel