From: Leo Yan <leo.yan@linaro.org>
To: German Gomez <german.gomez@arm.com>
Cc: Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
John Garry <john.garry@huawei.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Mike Leach <mike.leach@linaro.org>,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
James Clark <James.Clark@arm.com>
Subject: Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback
Date: Fri, 15 Oct 2021 22:16:01 +0800 [thread overview]
Message-ID: <20211015141601.GA66946@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <35209d5c-6387-5248-ab61-a1e1cb0553de@arm.com>
Hi German,
On Fri, Oct 15, 2021 at 01:33:39PM +0100, German Gomez wrote:
> Hi Leo,
>
> Would you be ok with the current patch the way it is?
Sorry for my failure to catch up the discussion.
As you and Will have mentioned in other emails that it will lead to
breakage if we change to monotonical increasing head, I read the code
and realized the difficulty to use monotonical increasing head in Arm
SPE driver. So let's use the way as this patch set is.
> In case it's of
> any help, I'm sharing the testing steps that James and I went through
> when testing this internally, if you want to add to it
>
> - Test that only a portion of the buffer is saved until there is a wraparound
>
> $ ./perf record -vvv -e arm_spe/period=148576/u -S -- taskset --cpu-list 0 stress --cpu 1 & while true; do sleep 0.2; killall -s USR2 perf; done
>
> - Test snapshot mode in CPU mode
>
> $ sudo ./perf record -vvv -C 0 -e arm_spe/period=148576/u -S -- taskset --cpu-list 0 stress --cpu 1 &
>
> - Test that auxtrace buffers correspond to an aux record
> - Test snapshot default sizes in sudo and user modes
> - Test small snapshot size
>
> $ ./perf record -vvv -e arm_spe/period=148576/u -S1000 -m16,16 -- taskset --cpu-list 0 stress --cpu 1 &
>
> If there are any concerns with the patches, please let me know and I
> will try to address them.
Thanks for sharing the testing cases. Could give me a bit more time for
the test at my side? And please expect I might give some comments if
I think it's necessary.
Thanks,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-15 14:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 15:46 [PATCH 1/5] perf cs-etm: Print size using consistent format German Gomez
2021-09-16 15:46 ` [PATCH 2/5] perf arm-spe: " German Gomez
2021-09-23 13:35 ` Leo Yan
2021-09-16 15:46 ` [PATCH 3/5] perf arm-spe: Add snapshot mode support German Gomez
2021-10-20 12:48 ` Leo Yan
2021-09-16 15:46 ` [PATCH 4/5] perf arm-spe: Implement find_snapshot callback German Gomez
2021-09-23 13:50 ` Leo Yan
2021-09-23 14:40 ` Leo Yan
2021-09-30 12:26 ` German Gomez
2021-10-04 12:27 ` Leo Yan
2021-10-06 9:35 ` German Gomez
2021-10-06 9:51 ` Leo Yan
2021-10-11 15:55 ` German Gomez
2021-10-12 8:19 ` Will Deacon
2021-10-12 8:47 ` James Clark
2021-10-13 0:39 ` Leo Yan
2021-10-13 7:51 ` Will Deacon
2021-10-15 12:33 ` German Gomez
2021-10-15 14:16 ` Leo Yan [this message]
2021-10-15 14:41 ` German Gomez
2021-10-17 6:13 ` Leo Yan
2021-10-19 9:23 ` German Gomez
2021-10-19 13:12 ` Leo Yan
2021-11-02 11:02 ` German Gomez
2021-10-17 12:05 ` Leo Yan
2021-10-17 12:36 ` Leo Yan
2021-10-19 17:34 ` German Gomez
2021-10-20 13:25 ` Leo Yan
2021-09-16 15:46 ` [PATCH 5/5] perf arm-spe: Snapshot mode test German Gomez
2021-10-20 13:13 ` Leo Yan
2021-10-20 15:06 ` German Gomez
2021-11-02 14:07 ` James Clark
2021-11-02 15:37 ` James Clark
2021-11-09 13:26 ` German Gomez
2021-09-23 13:35 ` [PATCH 1/5] perf cs-etm: Print size using consistent format Leo Yan
2021-09-23 16:24 ` Mathieu Poirier
2021-09-30 12:09 ` German Gomez
2021-09-30 16:30 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015141601.GA66946@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=James.Clark@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=german.gomez@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).