From: Maxime Ripard <maxime@cerno.tech>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-can@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Jeroen Hofstee <jhofstee@victronenergy.com>,
Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: r40: add node for CAN controller
Date: Mon, 22 Nov 2021 11:56:35 +0100 [thread overview]
Message-ID: <20211122105635.mmusmv5hhulvrz6x@gilmour> (raw)
In-Reply-To: <20211122104616.537156-4-boger@wirenboard.com>
Hi,
On Mon, Nov 22, 2021 at 01:46:16PM +0300, Evgeny Boger wrote:
> Allwinner R40 (also known as A40i, T3, V40) has a CAN controller. The
> controller is the same as in earlier A10 and A20 SoCs, but needs reset
> line to be deasserted before use.
>
> This patch adds a CAN node and the corresponding pinctrl descriptions.
>
> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> ---
> arch/arm/boot/dts/sun8i-r40.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
> index 1d87fc0c24ee..c99c92f008a0 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -511,6 +511,16 @@ pio: pinctrl@1c20800 {
> #interrupt-cells = <3>;
> #gpio-cells = <3>;
>
> + can_ph_pins: can-ph-pins {
> + pins = "PH20", "PH21";
> + function = "can";
> + };
> +
> + can_pa_pins: can-pa-pins {
> + pins = "PA16", "PA17";
> + function = "can";
> + };
> +
These nodes should be ordered alphabetically
Also, we should mark them with /omit-if-no-ref/ to remove them from the
DT if they are not referenced anywhere else in the DT.
Maxime
> clk_out_a_pin: clk-out-a-pin {
> pins = "PI12";
> function = "clk_out_a";
> @@ -926,6 +936,15 @@ i2c3: i2c@1c2b800 {
> #size-cells = <0>;
> };
>
> + can0: can@1c2bc00 {
> + compatible = "allwinner,sun8i-r40-can";
> + reg = <0x01c2bc00 0x400>;
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_CAN>;
> + resets = <&ccu RST_BUS_CAN>;
> + status = "disabled";
> + };
> +
> i2c4: i2c@1c2c000 {
> compatible = "allwinner,sun6i-a31-i2c";
> reg = <0x01c2c000 0x400>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-11-22 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 10:46 [PATCH 0/3] add support for Allwinner R40 CAN controller Evgeny Boger
2021-11-22 10:46 ` [PATCH 1/3] dt-bindings: net: can: " Evgeny Boger
2021-11-30 2:25 ` Rob Herring
2021-11-22 10:46 ` [PATCH 2/3] can: sun4i_can: add support for " Evgeny Boger
2021-11-22 10:46 ` [PATCH 3/3] ARM: dts: sun8i: r40: add node for " Evgeny Boger
2021-11-22 10:56 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122105635.mmusmv5hhulvrz6x@gilmour \
--to=maxime@cerno.tech \
--cc=boger@wirenboard.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=info@gerhard-bertelsmann.de \
--cc=jhofstee@victronenergy.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mkl@pengutronix.de \
--cc=wens@csie.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).