From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B328BC433F5 for ; Mon, 14 Mar 2022 06:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MsxxMhK2tLiEYkriOVjFxiZiprBR5TPUq4zSA0D5YOE=; b=q6ijz/DjWHikxN wc6CUym2PA0OnALEgbEuzbA1TTUAEy1Z+G5AOjsr03pUjflzVocDztE3WSd6xDpHY+vhZoG9PSci1 pa3jPUp0hFfcnfvAAIdAovGB++wQZhuLCpPwMERw2wwXTkL0CcKo10ws4pAUQiSdhUzF60/rvnTat PxZvQ/erjq7FwbHTAJ6ZwZ0aP1gurEhpE3ulk2PiqE2rgW1OTKWFCspj+6WcUoW/hu/vx6C+S3oDf 4MwnpJ5Ev998qTj8vvRuLfIErycRWlujxul3UOm+s4A5y4nbObxjm4/rz0jw8rpvHfhLLlCWuhfPb MIE/86g7yLKiWrMCEpXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTebQ-003zPF-IV; Mon, 14 Mar 2022 06:54:48 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTebM-003zNY-Lo for linux-arm-kernel@lists.infradead.org; Mon, 14 Mar 2022 06:54:45 +0000 Received: by mail-pl1-x630.google.com with SMTP id q13so12708410plk.12 for ; Sun, 13 Mar 2022 23:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ty6PwcxLzIVrqLfmu+9Ne928mUjT7ENA64son7AJAZo=; b=ZGY/KZNA9gTe1grOsoHZT2V1gfXNR7zcB/QMdQc0lY0zzvx6LFNO89ToSoVPvcwdKS aMA4qwy4WgaS2gGCJIZUUIszGUL0empqFJVQar4anjnNgukjglDVIzdnng1IkGQ+a4Af gnxIdAI9C9/7KOcV2Wu/WR41fNqYybY4sC3gyrWMH0O/XZICKRSflhJ27SgG4K9U2kLN d3VBgGhPXuB3BT0PWX8sITD/5PRzmNLaEXV1l0U71G5DpPALuwzS6wJ+RIuZ+oOGvddg 5z3OwlP+A+BRDd7VtejvLIVjMBrnxDrb9IZoOiCgO1k/m8XL7OC6t2A0k93ZDeaeWxfg TcOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ty6PwcxLzIVrqLfmu+9Ne928mUjT7ENA64son7AJAZo=; b=VOT5APg4DelpiQp+tGgUtgAVPn1GroAhm6svBAuPTEDRHI2oSsrURpiw1yahjo+M2D dYE9OjSPGnAsZSRGbYp6t3Z+FkXYiwfiyd4jMAtGfeE/wYJCVSF2qKJbyrHZjVSEwlfW BZ78YwC2uX7f3laGbkF+8moQNuUbIhsRse1vslB3uoM7B7szQ4zXHai9Bj/TtaTjnDRz B1LzYeMZ2WFDYbR/Ioq0zlIho35AsH5rsgLKByRwsNgc8GKbCAMmbxYmISjaLpWuUomo ormsg4jX8q+Vylf4yHF8hzZVRZxQVwoaWMtq6Gy/ADMAguDh88qzcvgDEndvBWvku5R9 iqrQ== X-Gm-Message-State: AOAM532P4N5+S85OGQoGGgQCNlbemsTzMN1YLMDmMnqVekLBNzPVnvii z/eiqO5fxQzmLq1ncyj4mhM= X-Google-Smtp-Source: ABdhPJy9dg1ytDwWF5oBI9JRVSns4+X/cV/eUxiu8GWjgUVo7wm+A3Nzdx5ki2X39sTeFdtdRP7LfA== X-Received: by 2002:a17:90a:430d:b0:1bc:f340:8096 with SMTP id q13-20020a17090a430d00b001bcf3408096mr23455757pjg.93.1647240880682; Sun, 13 Mar 2022 23:54:40 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.53.68]) by smtp.gmail.com with ESMTPSA id p17-20020a639511000000b0038108d69e8fsm9310536pgd.53.2022.03.13.23.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Mar 2022 23:54:40 -0700 (PDT) Date: Mon, 14 Mar 2022 12:24:34 +0530 From: Kuldeep Singh To: Viresh Kumar Cc: soc@kernel.org, Arnd Bergmann , Viresh Kumar , Shiraz Hashim , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: spear13xx: Update SPI dma properties Message-ID: <20220314065434.GA43329@9a2d8922b8f1> References: <20220312180615.68929-1-singh.kuldeep87k@gmail.com> <20220312180615.68929-2-singh.kuldeep87k@gmail.com> <20220314035118.gbjbrwbsywxljjti@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220314035118.gbjbrwbsywxljjti@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220313_235444_745715_C2BFFBE8 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 14, 2022 at 09:21:18AM +0530, Viresh Kumar wrote: > On 12-03-22, 23:36, Kuldeep Singh wrote: > > Reorder dmas and dma-names property for spi controller node to make it > > compliant with bindings. > > > > Signed-off-by: Kuldeep Singh > > What about a fixes tag ? Sure, will add one. > > --- > > arch/arm/boot/dts/spear13xx.dtsi | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi > > index c87b881b2c8b..45f0b2a33e02 100644 > > --- a/arch/arm/boot/dts/spear13xx.dtsi > > +++ b/arch/arm/boot/dts/spear13xx.dtsi > > @@ -284,9 +284,8 @@ spi0: spi@e0100000 { > > #size-cells = <0>; > > interrupts = <0 31 0x4>; > > status = "disabled"; > > - dmas = <&dwdma0 4 0 0>, > > - <&dwdma0 5 0 0>; > > - dma-names = "tx", "rx"; > > + dmas = <&dwdma0 5 0 0>, <&dwdma0 4 0 0>; > > + dma-names = "rx", "tx"; > > Why does the order matter here since we have dma-names anyway, which > was correct earlier ? Dma-names order matters here. As per pl022 binding, dma-names order specify rx,tx and all DTs which have tx,rx as order start raising dtbs_chek warning. Thus, need to reverse this order. Please note, no functional change in this patch apart from just fixing warning. Warning: 'rx' was expected 'tx' was expected Regards Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel