From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C936C433F5 for ; Wed, 16 Mar 2022 02:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=u76d0YyWhKE3npb1xsNOqKfgg6XMaSGgw6B5hbvPluY=; b=PbMakvzuD8JcEa ywmoUQOAV2BW6PipjmcBXKYG57ne9/6NxvdDXmeL1ec5X+jSyZ68jxc29DYReCeRgqGli8+BGkf4C Ks5rpvqUQL4O1qYHwbc7cRGbDm9L2dXqpgI0q3FFwcrfbQUWXD486gzCh+jf2G8ex73OHP7CPvl2H XFSjOBivnNwCiBYFcFRPj4+TfaubR3OLIebiBWWVDeECX4DDhTEXwJLSZejiJaoTRf9Rq1phSU6bA /7J0D7G3/JATEPFsKEhzhRR0v2U1lmrngVv2trLrDmFAKudObrqAsRv6NfflPG9qcQVhIHFQcHX0y FYYHiNg28zrMflu9R7Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUJUJ-00BDXN-QY; Wed, 16 Mar 2022 02:34:11 +0000 Received: from out29-1.mail.aliyun.com ([115.124.29.1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUJUG-00BDVR-4P for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 02:34:09 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.2041822|-1; BR=01201311R111S35rulernew998_84748_2000303; CH=blue; DM=|CONTINUE|false|; DS=CONTINUE|ham_system_inform|0.0423659-0.00231199-0.955322; FP=0|0|0|0|0|-1|-1|-1; HT=ay29a033018047193; MF=victor@allwinnertech.com; NM=1; PH=DS; RN=12; RT=12; SR=0; TI=SMTPD_---.N5VpE7V_1647398035; Received: from sunxibot.allwinnertech.com(mailfrom:victor@allwinnertech.com fp:SMTPD_---.N5VpE7V_1647398035) by smtp.aliyun-inc.com(33.37.2.29); Wed, 16 Mar 2022 10:33:56 +0800 From: Victor Hassan To: linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk, linus.walleij@linaro.org, yanfei.xu@windriver.com, ardb@kernel.org, tglx@linutronix.de, mirq-linux@rere.qmqm.pl, arnd@arndb.de Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, allwinner-opensource-support@allwinnertech.com, Victor Hassan Subject: [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug Date: Wed, 16 Mar 2022 10:33:56 +0800 Message-Id: <20220316023356.120595-1-victor@allwinnertech.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_193408_384176_52A6A44A X-CRM114-Status: UNSURE ( 8.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org earlycon uses fixmap to create a memory map, So we need to close earlycon before closing fixmap, otherwise printk will access illegal addresses. After creating a new memory map, we open earlycon again. Signed-off-by: Victor Hassan --- arch/arm/mm/mmu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 274e4f73fd33..f3511f07a7d0 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -1695,6 +1696,9 @@ static void __init early_fixmap_shutdown(void) pmd_clear(fixmap_pmd(va)); local_flush_tlb_kernel_page(va); +#ifdef CONFIG_FIX_EARLYCON_MEM + console_stop(console_drivers); +#endif for (i = 0; i < __end_of_permanent_fixed_addresses; i++) { pte_t *pte; struct map_desc map; @@ -1713,6 +1717,9 @@ static void __init early_fixmap_shutdown(void) create_mapping(&map); } +#ifdef CONFIG_FIX_EARLYCON_MEM + console_start(console_drivers); +#endif } /* -- 2.29.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel