From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Maya Matuszczyk <maccraft123mc@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 06/10] arm64: dts: mediatek: asurada: Add keyboard mapping for the top row
Date: Thu, 17 Mar 2022 10:40:12 -0400 [thread overview]
Message-ID: <20220317144012.m7efcweyyqj3jtyt@notapiano> (raw)
In-Reply-To: <CAO_Mup+XApZBaSQLqBBxBPY5U1kOoRNwcWBhoaS+p_gCPx3XCg@mail.gmail.com>
Hi Maya,
On Wed, Mar 16, 2022 at 05:42:20PM +0100, Maya Matuszczyk wrote:
> śr., 16 mar 2022 o 16:26 Nícolas F. R. A. Prado
> <nfraprado@collabora.com> napisał(a):
> >
> > Chromebooks' embedded keyboards differ from standard layouts for the
> > top row in that they have shortcuts in place of the standard function
> > keys. Map these keys to achieve the functionality that is pictured on
> > the printouts.
> >
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >
> > .../boot/dts/mediatek/mt8192-asurada.dtsi | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> > index bd2730ab6266..1d1a4b9a989a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> > @@ -525,3 +525,32 @@ &uart0 {
> >
> > #include <arm/cros-ec-keyboard.dtsi>
> > #include <arm/cros-ec-sbs.dtsi>
> > +
> > +&keyboard_controller {
> > + function-row-physmap = <
> > + MATRIX_KEY(0x00, 0x02, 0) /* T1 */
> > + MATRIX_KEY(0x03, 0x02, 0) /* T2 */
> > + MATRIX_KEY(0x02, 0x02, 0) /* T3 */
> > + MATRIX_KEY(0x01, 0x02, 0) /* T4 */
> > + MATRIX_KEY(0x03, 0x04, 0) /* T5 */
> > + MATRIX_KEY(0x02, 0x04, 0) /* T6 */
> > + MATRIX_KEY(0x01, 0x04, 0) /* T7 */
> > + MATRIX_KEY(0x02, 0x09, 0) /* T8 */
> > + MATRIX_KEY(0x01, 0x09, 0) /* T9 */
> > + MATRIX_KEY(0x00, 0x04, 0) /* T10 */
> > + >;
> > + linux,keymap = <
> > + MATRIX_KEY(0x00, 0x02, KEY_BACK)
> > + MATRIX_KEY(0x03, 0x02, KEY_REFRESH)
> > + MATRIX_KEY(0x02, 0x02, KEY_ZOOM)
> > + MATRIX_KEY(0x01, 0x02, KEY_SCALE)
> > + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ)
> > + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
> > + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
> > + MATRIX_KEY(0x02, 0x09, KEY_MUTE)
> > + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
> > + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
> > +
> > + CROS_STD_MAIN_KEYMAP
> > + >;
> > +};
> > --
> > 2.35.1
> >
> I'm honestly a bit confused about function of this.
> Does this change the reported key codes via evdev interface?
Yes.
> Or is this just a hint to userspace? If yes, would libinput report
> key presses as F-keys or the custom function keys?
> Would users be able to use the usual key combination to switch
> between TTYs?
> Would programs requiring F-keys still work?
Not with this keyboard, since the embedded keyboard on Chromebooks doesn't have
F-keys.
This patch is just setting the keymap present on this platform, so that the
devicetree correctly describes the hardware.
Thanks,
Nícolas
>
> Best regards,
> Maya Matuszczyk
>
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-17 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 15:13 [PATCH v1 00/10] Introduce support for MediaTek MT8192 Google Chromebooks Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 01/10] arm64: dts: mediatek: Introduce MT8192-based Asurada board family Nícolas F. R. A. Prado
2022-04-27 8:43 ` Chen-Yu Tsai
2022-04-27 13:54 ` Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 02/10] arm64: dts: mediatek: asurada: Document GPIO names Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 03/10] arm64: dts: mediatek: asurada: Add system-wide power supplies Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 04/10] arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 05/10] arm64: dts: mediatek: asurada: Add ChromeOS EC Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 06/10] arm64: dts: mediatek: asurada: Add keyboard mapping for the top row Nícolas F. R. A. Prado
2022-03-16 16:42 ` Maya Matuszczyk
2022-03-17 14:40 ` Nícolas F. R. A. Prado [this message]
2022-03-16 15:13 ` [PATCH v1 07/10] arm64: dts: mediatek: asurada: Add Cr50 TPM Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 08/10] arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 09/10] arm64: dts: mediatek: asurada: Add I2C touchscreen Nícolas F. R. A. Prado
2022-03-16 15:13 ` [PATCH v1 10/10] arm64: dts: mediatek: spherion: Add keyboard backlight Nícolas F. R. A. Prado
2022-03-18 11:41 ` [PATCH v1 00/10] Introduce support for MediaTek MT8192 Google Chromebooks AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317144012.m7efcweyyqj3jtyt@notapiano \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).