From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6380C433EF for ; Wed, 23 Mar 2022 18:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YOLIl5geUrroCNN+phDAWvhZXHhrUMBuQ6ARv4VgGlY=; b=j7u6hLm+INtvUs eg64Z5QpT0aCyJJcl+DzsdKRxCtegN0NpJlGfK3U+1GCHzC6hnkC84tNTrWz0tiC1oA3n4IqmkWDP Q/SU+mgXQV8qAu3YbnQmUUTxa86tOIpQ4MR9fsq2v3czK7mT629J4ZF9Yrhaz5aL96xgPS+MajTZb qSneS/+BwpA5PFy0kJ656jk3Npn762pk1g/bIgLiUOlsOWYe2R/39+3m6ebx8PbcBhrkXuxTfktze TfOr7SyTbdHJqjw8S6lBnQSdNLGgXWVgjmrsodXo1/eGUvnaWPnM8EigwjzxAiy9v/d7ohYikKzyV 7tFGORNySewf+0sSla8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX5pv-00EaU4-1Q; Wed, 23 Mar 2022 18:35:59 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX5pn-00EaRl-NG for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 18:35:53 +0000 Received: by mail-pj1-x1034.google.com with SMTP id l4-20020a17090a49c400b001c6840df4a3so2735457pjm.0 for ; Wed, 23 Mar 2022 11:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WvsBxfCeE3uzDy/FhG1cS64vo7phnxHLbDB9aw3w/TA=; b=S3WvMCVoL2+cTrcEpJ+Ov3n9R/VqZn2PAnXqHSQx0QnWSIsNOplqjj85PGxOC93+ri ZtlxSLWyKV6Zb9QFKFTdoE5lDJIWCjPFWgW5UWCxhNs2VoOFpmW3g7iokX5aitsQpfsC WrfPv9PEsV+pjCvHQYWNPHLvA+YhZbC7TTS2kQrVaAlxUlVtcPYKmHsuPOgWRCr3FT/U DJNollg1x0egZFUEBtvru5kdaku/HUQ1g7Cg6GjWZuTGdwEVwCDZIJcyQNyjlgXFD9N2 O/9Fd1awefF0KHWFysZOyJ5OUubUmVGZRTrQvwbpMWWOXl7+0fwdKww1+nULsAMFk0sg nrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WvsBxfCeE3uzDy/FhG1cS64vo7phnxHLbDB9aw3w/TA=; b=SuZpx1ZocJqld0D/E+4L60QXXRJswEVTDUbOUSZ/M7oNqNE610gIv0ChTWsrrN2cYU SHEy796zXRoam2oTTWOOWm08pWEJIzjESzV0J6Hd3Ew27KINoGXGdbYF7U1JWSm0cCBS 1yqoWuiePthewz9oRnNankFPVTfUYKconVIV4RXEg3Ab/KHM3Z3/qIdai3ypFN1pzfWp zo2wJ8AVceVMVwxa8/M4lQ5fMOy1k6ixlSco+Zx0ut3sZ720ESGA+zNDbDjRATQNVfIG dA4TtgWbLVNS0I6Bd942rcm4E83XUxr6ZWaOa7kLMCXjU1/wl7wsTkNwNNLvlb4bQ1Gz LLhQ== X-Gm-Message-State: AOAM533TeLZfZNxkC6EIJrzUvFT6VU/r0YxpKc15pQ2GhF1UTnEWdTtI BDcLw5nywXHijkL3wqej5Ls= X-Google-Smtp-Source: ABdhPJyQZohjwI0ZKLNEeABcyKjsZIgdGygyJHI0Ay2CI3+Q9hMTZYY5dgNR/mObLZVelfIfTs1L5Q== X-Received: by 2002:a17:903:204a:b0:154:80a6:3580 with SMTP id q10-20020a170903204a00b0015480a63580mr1488902pla.47.1648060550482; Wed, 23 Mar 2022 11:35:50 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.51.18]) by smtp.gmail.com with ESMTPSA id g14-20020a63be4e000000b00382800d1528sm458279pgo.21.2022.03.23.11.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 11:35:50 -0700 (PDT) Date: Thu, 24 Mar 2022 00:05:44 +0530 From: Kuldeep Singh To: Robin Murphy , Rob Herring Cc: Marc Zyngier , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: timer: Document arm, cortex-a7-timer in arch timer Message-ID: <20220323183544.GA95717@9a2d8922b8f1> References: <20220317191527.96237-1-singh.kuldeep87k@gmail.com> <20220317191527.96237-3-singh.kuldeep87k@gmail.com> <558f0c92-c499-daca-e1ad-2b16137f8c06@arm.com> <20220317212508.GB99538@9a2d8922b8f1> <44f3abe1-09a2-657f-7637-afa34781709b@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <44f3abe1-09a2-657f-7637-afa34781709b@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_113551_793141_19EB46B8 X-CRM114-Status: GOOD ( 47.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 21, 2022 at 11:52:27AM +0000, Robin Murphy wrote: > On 2022-03-20 18:47, Rob Herring wrote: > > On Fri, Mar 18, 2022 at 02:55:08AM +0530, Kuldeep Singh wrote: > > > On Thu, Mar 17, 2022 at 08:25:12PM +0000, Robin Murphy wrote: > > > > On 2022-03-17 19:15, Kuldeep Singh wrote: > > > > > Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in > > > > > conjugation with "arm,armv7-timer". Since, initial entry is not > > > > > documented, it start raising dtbs_check warnings. > > > > > > > > > > ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long > > > > > 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] > > > > > 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] > > > > > > > > > > Document this compatible to address it. The motivation to add this > > > > > change is taken from an already existing entry "arm,cortex-a15-timer". > > > > > Please note, this will not hurt any arch timer users. > > > > > > > > Eh, if it's never been documented or supported, I say just get rid of it. > > > > The arch timer interface is by definition part of a CPU, and we can tell > > > > what the CPU is by reading its ID registers. Indeed that's how the driver > > > > handles the non-zero number of CPU-specific errata that already exist - we > > > > don't need compatibles for that. > > > > > > > > In some ways it might have been nice to have *SoC-specific* compatibles > > > > given the difficulty some integrators seem to have had in wiring up a stable > > > > count *to* the interface, but it's not like they could be magically added to > > > > already-deployed DTs after a bug is discovered, and nor could we have > > > > mandated them from day 1 just in case and subsequently maintained a binding > > > > that is just an ever-growing list of every SoC. Oh well. > > > > > > Robin, A similar discussion was already done on v1 thread. Please see > > > below for details: > > > https://lore.kernel.org/linux-devicetree/20220317065925.GA9158@9a2d8922b8f1/ > > > https://lore.kernel.org/linux-devicetree/726bde76-d792-febf-d364-6eedeb748c3b@canonical.com/ > > > > > > And final outcome of discussion turns out to add this compatible string. > > > > I agree with Robin on dropping. More specific here is not useful. If > > we're going to add some cores, then we should add every core > > implementation. Sure Rob, I will drop A7/15-timer entry from compatibles. This means only two entries i.e arm,armv7/8-timer will be there under compatibles now. I actually added A7-timer because A15-timer was already present in binding. Since, it was added by you that's why I added this one. I will update compatibles accordingly as you said above. > > Yeah, what I was trying to convey is that a compatible like > "arm,cortex-a76-timer" has the problem of being both too specific *and* not > specific enough to be genuinely useful *for the particular case of the arch > timer*. It's an architectural interface, where the actual functional > features are described through the interface itself, so the purpose of the > DT entry is really just to indicate that the standard interface is present > and describe how its externally-routed interrupts are wired up. > > However, it's also true that implementations of standard functionality > sometimes have bugs that software needs to know about, but in order for > specific DT compatibles to be useful in that respect they really need to > identify the *exact* implementation, e.g. to know that > "arm,cortex-a76-r0p0-timer" has a bug which needs working around, but > "arm,cortex-a76-r4p0-timer" does not. There might be cases where every known > version of a CPU is equally affected (e.g. Cortex-A73), but it doesn't hold > as a general assumption. Furthermore as mentioned, the other class of bugs > which affect this interface are not in the CPU's implementation of the > interface at all, but in the external SoC logic that provides the counter > value, and therefore it can be identification of the overall SoC that > matters regardless of which CPU IP(s) may be present. > > If we'd had the benefit of 10 years worth of hindsight 10 years ago, we > probably wouldn't have defined "arm,cortex-a15-timer" either. However the > fact that we can't erase the legacy of that decision doesn't make an > argument for repeating it now. > > > If one has a big.LITTLE system with A15/A7 what would be the right > > compatible value? > > > > > > > > I see people with different set of perspective in regard to whether keep > > > compatible string or not. We should have some sort of evidences to > > > support claims so that next time when similar situation arises, we'll be > > > aware beforehand how to proceed. > > > > Every situation tends to be different. > > Indeed, I certainly don't have a personal perspective of "delete all the > bindings!" in general - only when they're truly redundant (functionally, any > driver that can touch the arch timer registers can also read the CPU ID > registers, but even in the DT there should already be compatibles for the > CPUs themselves). Thanks Robin for providing inputs. I agree with your opinion of having soc specific compatibles which is also mentioned under dos and dont's of bindings and other cases will require investigation though. https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html - Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel