From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C58AC433F5 for ; Tue, 5 Apr 2022 09:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ptNUgPy7skf3YpB9gPnTdXui7h673SZRfx8wz7vof+A=; b=4Gm90Ya7b0mLjA hdfadqXGQ81gGSTndtNVD2rLfJGTc91Zhi9KrGs6j68p7LDQOZVOZLfynTLOKjpGVrs+5zICRol+U oZpzTm6oER/QSzTkq9RBCQcB+SqVXfpqwOgj7RrnStZeyGAfTLyQgvjPVz1SCldAEwwaPrg1BZqsX CZFtBgP+0k7eeO45OI4WN3jpkC1njyWlBFJ+qHNTPXwZQU9EeIvYTo7MMTMv/7Q7aiHC8+iCb1916 LAgqvPtbeZl2yAfSeP4VANRfRlzf/R1gZaFsY0vx9etiG8zKkMEM7gVYt80T+Zizph4AYLRgtxP7c yF1Akv2+lH5gT0RO8ICw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbfe3-000Tr7-4i; Tue, 05 Apr 2022 09:38:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbfcX-000T83-LY for linux-arm-kernel@lists.infradead.org; Tue, 05 Apr 2022 09:37:07 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbfcV-00089z-OS; Tue, 05 Apr 2022 11:37:03 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nbfcS-0005WI-5z; Tue, 05 Apr 2022 11:37:00 +0200 Date: Tue, 5 Apr 2022 11:37:00 +0200 From: Sascha Hauer To: Andy Yan Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Message-ID: <20220405093700.GQ4012@pengutronix.de> References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:07:04 up 5 days, 21:36, 61 users, load average: 0.05, 0.19, 0.16 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220405_023705_782679_9C7AD5F4 X-CRM114-Status: GOOD ( 34.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: > Hi Sacha: > > On 4/1/22 20:52, Sascha Hauer wrote: > > -- > > >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 > > From: Sascha Hauer > > Date: Fri, 1 Apr 2022 14:48:49 +0200 > > Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver > > > > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > index 7dba7b9b63dc6..1421bf2f133f1 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) > > } > > } > > + if (vop2->data->soc_id == 3566) { > > + /* > > + * On RK3566 these windows don't have an independent > > + * framebuffer. They share the framebuffer with smart0, > > + * esmart0 and cluster0 respectively. > > + */ > > + switch (win->data->phys_id) { > > + case ROCKCHIP_VOP2_SMART1: > > + case ROCKCHIP_VOP2_ESMART1: > > + case ROCKCHIP_VOP2_CLUSTER1: > > + continue; > > + } > > > Think about this , there maybe other upcoming vop2 base soc, they may only > have > > mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. > > I think this should add WIN_FEATURE at the platform description file > rockchip_vop2_reg.c, then > > check the FEATURE to decide whether the driver should give this window a > special treatment. > > this can make one code run for different soc with different platform > description. or we should add > > the same code logic for different soc again and again. You mean like done in the downstream Kernel? Here indeed we have a WIN_FEATURE_MIRROR flag added to the platform description. This is then evaluated with: static bool vop2_is_mirror_win(struct vop2_win *win) { return soc_is_rk3566() && (win->feature & WIN_FEATURE_MIRROR); } So a flag is added and afterwards its evaluation is SoC specific. That doesn't help at all and only obfuscates things. Besides, experience shows that you can't predict a good abstraction for future hardware revisions, the hardware guys are just too creative in creating hardware that breaks existing abstractions. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel