From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C637C433F5 for ; Wed, 13 Apr 2022 13:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CXtZzGvHRJZ87jaV7TK6Mk8htjDOgxus7EalMVjl6GM=; b=iZUTz5PvMQqfrM q3cFV5M+wSAN9eWYpFs2HoswyMWm01cnjzFFWu4+2OvjzJ58qoy3BRtM13NCFVLi9RAdKKti9IoXY Hjei5mcK2/FBrXeFNZ/Qf9zD7rRlHmwb2MUDLZcXTNZijsMAzxi8T3fJFBiAiKDa9nmv61fEsbFEw RqwqDot5x8q3PD8UB+51OiI8R9GS691IXLiY2qRVS8X13smDwQt45x5q+hgNaWUES0wj4fjfS8Qkj HhgqRd8NviZ3JMQgBN71QFH9EgjijSEalJLs+9UjIlaa4FBfvRd++ewnJP+rcJSDQPzOJwY57SD5i n3R5tKpXtfUuuS9hSG2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1necal-0017Qs-1A; Wed, 13 Apr 2022 12:59:27 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1necai-0017Os-4t for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 12:59:25 +0000 Received: by mail-wm1-x32e.google.com with SMTP id ay36-20020a05600c1e2400b0038ebc885115so2753674wmb.1 for ; Wed, 13 Apr 2022 05:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tLvIKnCsgwq0Fk81VHoLGLNWgDzppdl1EGVsnwIiwWk=; b=J+TeCd/41OhdiO9FUGEfBABaBHyh/+x7sT23BLdtYO5M/x78pQgF4HUNKv9pzckLvE MxPd2HtNgkI6X7aRD/PgoHW6pVhDxI8euAS9xxP6mmaE1kusyaJ0y+ZjzUz6BMYa5ozG 9uinPwymgXMcz+Gg+OuQDeTD5Y8mH6LmuNMUDP/r/iZ6ncTL2KniEyeWwa8admD2JJxh 55468CiYjZUtegpegbpzGpHqZ2PuQ9QJf08kGj4VNjg0PuJiBgKjEWPP6vJNz5uLeKJS pPiToZDXWjoFGkMUuKIofSm8bW4zIWYbuSBz6fEuW6Ccl8EM9Nmw4ioblOFhaO1IvD9d ZBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tLvIKnCsgwq0Fk81VHoLGLNWgDzppdl1EGVsnwIiwWk=; b=0Vbg5n3ln2BJcAeOJgw5di19Pez+U89gGg2WBgzKFEh+OkE/gGN4I77kUQjD/R3qIt eKsVHhfF+Ch16CKIpRKWZXRqOkMJ73BfMB/oj6PLBpso7c7F5ZELsD+K1OMwEzYJYqS6 sNA8hKB2dsLw76++ln6zVg/FWcC4PvaP+in4AHPsCO4yMdAWB7d0Sms+KN7ErZDnSoUN yoM0edL0DypTXMbPrOKYxat7AxwBn5HbBvLAtY3v4PNbsjjEUlLjJQ/oSBUmgKOVg1F9 8BesQN6uGowTw+tnc20bWShcRPQTcIu3ng6W3ljawP7H173ciJ0Qi0npE+qHUDaIdGs8 ttaw== X-Gm-Message-State: AOAM532uLfcvx6RI2nrxmJ3OxQUhViA+FrdJj+JJzHJJ5jTpkLakuaAl dpN6fuCL9OY6k70KzY8W/UE= X-Google-Smtp-Source: ABdhPJzHDsOyWeJ1XYw5H42kbzi5IU99y9X4kNsBdhZkSZSUb/AfGgMpOXsUKWaFNT0R/LhnDJ9bFw== X-Received: by 2002:a05:600c:5128:b0:38e:bcdd:53bf with SMTP id o40-20020a05600c512800b0038ebcdd53bfmr8352243wms.109.1649854759438; Wed, 13 Apr 2022 05:59:19 -0700 (PDT) Received: from hoboy.vegasvil.org (195-70-108-137.stat.salzburg-online.at. [195.70.108.137]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c4e8900b0038cc29bb0e1sm2873992wmq.4.2022.04.13.05.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 05:59:18 -0700 (PDT) Date: Wed, 13 Apr 2022 05:59:15 -0700 From: Richard Cochran To: Tan Tee Min Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Rayagond Kokatanur , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng , Wong Vee Khee , Song Yoong Siang Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop Message-ID: <20220413125915.GA667752@hoboy.vegasvil.org> References: <20220413040115.2351987-1-tee.min.tan@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220413040115.2351987-1-tee.min.tan@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_055924_227641_86681BE5 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 12:01:15PM +0800, Tan Tee Min wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index d3b4765c1a5b..289bf26a6105 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -279,10 +279,11 @@ static int dwmac4_wrback_get_rx_timestamp_status(void *desc, void *next_desc, > /* Check if timestamp is OK from context descriptor */ > do { > ret = dwmac4_rx_check_timestamp(next_desc); > - if (ret < 0) > + if (ret <= 0) > goto exit; > i++; > > + fsleep(1); This is nutty. Why isn't this code using proper deferral mechanisms like work or kthread? > } while ((ret == 1) && (i < 10)); > > if (i == 10) > -- > 2.25.1 > Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel