From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 3/4] staging: media: Add support for the Allwinner A31 ISP
Date: Wed, 20 Apr 2022 11:53:39 +0300 [thread overview]
Message-ID: <20220420085339.GA2969@kadam> (raw)
In-Reply-To: <20220420085132.GC2951@kadam>
On Wed, Apr 20, 2022 at 11:51:33AM +0300, Dan Carpenter wrote:
> On Wed, Apr 20, 2022 at 09:50:42AM +0200, Paul Kocialkowski wrote:
> > Hi Dan,
> >
> > On Wed 20 Apr 22, 10:42, Dan Carpenter wrote:
> > > I ran Smatch on this patch.
> >
> > Thanks for doing this!
> >
> > > On Fri, Apr 15, 2022 at 05:37:07PM +0200, Paul Kocialkowski wrote:
> > > > +void sun6i_isp_capture_configure(struct sun6i_isp_device *isp_dev)
> > > > +{
> > > > + unsigned int width, height;
> > > > + unsigned int stride_luma, stride_chroma = 0;
> > > > + unsigned int stride_luma_div4, stride_chroma_div4;
> > > > + const struct sun6i_isp_capture_format *format;
> > > > + const struct v4l2_format_info *info;
> > > > + u32 pixelformat;
> > > > +
> > > > + sun6i_isp_capture_dimensions(isp_dev, &width, &height);
> > > > + sun6i_isp_capture_format(isp_dev, &pixelformat);
> > > > +
> > > > + format = sun6i_isp_capture_format_find(pixelformat);
> > > > + if (WARN_ON(!format))
> > > > + return;
> > > > +
> > > > + sun6i_isp_load_write(isp_dev, SUN6I_ISP_MCH_SIZE_CFG_REG,
> > > > + SUN6I_ISP_MCH_SIZE_CFG_WIDTH(width) |
> > > > + SUN6I_ISP_MCH_SIZE_CFG_HEIGHT(height));
> > > > +
> > > > + info = v4l2_format_info(pixelformat);
> > > > + if (WARN_ON(!info))
> > > > + return;
> > > > +
> > > > + stride_luma = width * info->bpp[0];
> > > > + stride_luma_div4 = DIV_ROUND_UP(stride_luma, 4);
> > > > +
> > > > + if (info->comp_planes > 1) {
> > > > + stride_chroma = width * info->bpp[1] / info->hdiv;
> > > > + stride_chroma_div4 = DIV_ROUND_UP(stride_chroma, 4);
> > >
> > > stride_chroma_div4 is not intialized on the else path.
> >
> > One could say it's not an issue to put an uninitialized value in this situation
> > since the hardware won't be taking it into account but I'll initialize the value
> > early in the next iteration.
> >
>
> My understanding is that it will trigger a KASAN warning at run time.
Or is it KMEMsan? One of those. The one that complains about
uninitialized memory.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 8:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 15:37 [PATCH v3 0/4] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / ISP Driver Paul Kocialkowski
2022-04-15 15:37 ` [PATCH v3 1/4] dt-bindings: media: Add Allwinner A31 ISP bindings documentation Paul Kocialkowski
2022-04-16 1:59 ` Samuel Holland
2022-04-19 9:45 ` Paul Kocialkowski
2022-04-19 13:48 ` Rob Herring
2022-04-16 22:17 ` Rob Herring
2022-04-15 15:37 ` [PATCH v3 2/4] dt-bindings: media: sun6i-a31-csi: Add ISP output port Paul Kocialkowski
2022-04-19 13:08 ` Rob Herring
2022-04-19 13:35 ` Paul Kocialkowski
2022-04-15 15:37 ` [PATCH v3 3/4] staging: media: Add support for the Allwinner A31 ISP Paul Kocialkowski
2022-04-20 7:42 ` Dan Carpenter
2022-04-20 7:50 ` Paul Kocialkowski
2022-04-20 8:51 ` Dan Carpenter
2022-04-20 8:53 ` Dan Carpenter [this message]
2022-04-28 12:14 ` Sakari Ailus
2022-04-28 14:30 ` Paul Kocialkowski
2022-04-28 21:07 ` Sakari Ailus
2022-05-20 14:57 ` Paul Kocialkowski
2022-05-22 17:34 ` Laurent Pinchart
2022-05-23 12:51 ` Paul Kocialkowski
2022-05-23 13:27 ` Laurent Pinchart
2022-05-24 12:37 ` Paul Kocialkowski
2022-04-15 15:37 ` [PATCH v3 4/4] MAINTAINERS: Add entry for the Allwinner A31 ISP driver Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420085339.GA2969@kadam \
--to=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).