From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 042A5C433FE for ; Thu, 21 Apr 2022 08:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=skSiDkG5ATMs79TeddBXkh3/S0Z66LSlpz96QAauwjM=; b=mCRS+YB+NsXZ8r bpmlGWVie7T4FdbgDyniS/w6yVWx/0nc4p8FBU6fWzsvma8Y1Cd7Y8kBoS+w+MELj69XK+fEeP24x D5PnPOAkUhuFDUIDL4x5fwu6gLlBaFxDdvQHjiIKp0MlyZ/gTGmoYAEHNlhEAxPLTsL0OUXONXJuX YNfFT2IzXtGBWxtciTXR9hSE6zRAfKbi1dYbw4IPvLvCU8hW8pGbVMb6x5xBA3R4+cRBSh6dFfgUL a1sKeNK26sWewimL3mf52DU9/ttuM+uBRSnZXBtTOWszCHbBR5Ipc0ut8dUr0IHrWliwtGLLtlbyX DJoYi3P3HQGGODYdwS+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhSGD-00CRkg-Fb; Thu, 21 Apr 2022 08:33:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhSGA-00CRiw-10 for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 08:33:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C9A0961BDC; Thu, 21 Apr 2022 08:33:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71689C385A1; Thu, 21 Apr 2022 08:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650530032; bh=p6bgQ7Z9qqrV3XSCYlYFJ6UsMOIanchbxmGz7bNMIOc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KjZV1eFzBSUr3Vu8AH+Km5fn5LKTLHbTAvPAkvFETrl8aUafFNgofCy+nn6Oa+Y7z MnpovExZj+Ez7OOZUbUBVShphPsWnxoHCF9F53/WfTFeXqCP/sc+pLb0zAxuv+xhSk PfVgh+6DweF7ldJAn2KsMG/iCj5TVX14H56FqR8TX38Fmy7jDiTOmmkTRJUznqOOpu Q8WYLA7lACCNlSEK8wbDHE4PZzUbWMZIItAybWjunGgCpboMyN/ctvHIy33MnCRpN3 rbe2fhpY0FtQQj6xO3hnjxzUy2HEXfF/q/SvD0LMaBpCb4nTF8+XWJ93KhOoCiV4Rd hV+IWiSNlneKg== Date: Thu, 21 Apr 2022 09:33:45 +0100 From: Will Deacon To: Robin Murphy Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu() Message-ID: <20220421083345.GA8303@willie-the-truck> References: <2e59602d982fd4941ec923571940fa3c628b2188.1649935679.git.robin.murphy@arm.com> <20220419144042.GA6186@willie-the-truck> <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_013354_143261_6FF3927E X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, mjrosato@linux.ibm.com, sven@svenpeter.dev, zhang.lyra@gmail.com, joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, gerald.schaefer@linux.ibm.com, baolu.lu@linux.intel.com, yong.wu@mediatek.com, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 20, 2022 at 05:05:03PM +0100, Robin Murphy wrote: > On 2022-04-19 15:40, Will Deacon wrote: > > On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote: > > > Stop calling bus_set_iommu() since it's now unnecessary. With device > > > probes now replayed for every IOMMU instance registration, the whole > > > sorry ordering workaround for legacy DT bindings goes too, hooray! > > > > Ha, I hope you tested this! > > Oh alright then, since it's you... :) > > I've hacked up a Juno DT with the old bindings, and (after needing a while > to remember that they're fundamentally incompatible with disable_bypass), > can confirm that with my whole dev branch including this series applied, it > boots and creates IOMMU groups as expected. I then made the mistake of > trying without the branch to check whether the squawks from > iommu_setup_dma_ops() were new or not, and... well... plain rc3 doesn't even > boot on the same setup - it's somehow blowing up in the failure cleanup path > of iommu_bus_init(), apparently calling iommu_release_device() on something > where dev->iommu->iommu_dev is NULL, for reasons that are far from clear and > I'm not sure I can really be bothered to debug further... :/ Great, so your series is a fix! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel