From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0036C433FE for ; Sat, 7 May 2022 12:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QClb0DkLO9ilOdBdZA8J7pfBcQorEkIYRG5NuQAzR/k=; b=m1vCcXH2kLerd/ xdvONkkl+C18u3HZ8ZlOLrXA48bi8wOPMoUyjokXHQ8lejSmFv+VI1xn2rxVMda8Xb5b0iNaVLqcp kR/I0muwU/Ra22R3HeAi91tEHKEruxFAXaOeZLy2/LvIlhfO1wwmd0w0YpDvNHhvuiue7bElzWEi/ 9Wu6zQX+FlMaUz3oQJJZEs+jfBw3YvgBbWumBidCJfXFLoJWr8+Mhto89+YXPKJEqKyZScZtMz6+l IFDPidI8Ia2/+JBecxf9hjWNUDlrtULpbPJZjybAyaNOIeoeTwuffnsf2P8WG/r8B+kjjpfhfTlN6 158BwEJU5bfqJiXl6c6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJqk-007Azm-SB; Sat, 07 May 2022 12:47:54 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJqZ-007Ay7-Vl for linux-arm-kernel@lists.infradead.org; Sat, 07 May 2022 12:47:45 +0000 Received: by mail-lf1-x132.google.com with SMTP id b18so16647358lfv.9 for ; Sat, 07 May 2022 05:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gwVpejRRRIX6iBHQ9uQjh7sUWq7n5QC76X2Ncl9Icms=; b=R9xxBV26A1ASOHDlV8cCG+DHnUYpfWLA6as8YvU8OaxoaRlu1IXgq/KXRLyfX0dZf6 pWxVchX4XsP7tN14Tu/NGZp5REONf68XwDbZMpOsmDC90snjdOtizDn7RR8KnYUv8sku PiNUYylxzEcVBIo3IQlETHYehyLqWFCESKZJ5fJpbHDAoUACU6ePd84bIq0luyV5dCEF nDKtVlZJhgNzXCPiwAZGPjCDJtsuY8WBSBsHjt6WNqbuVYtPiPQpEgIpd/6paVeDDQoU 15tooNSD1xA5Hik5AsHGMKmoOWRYMq0F5iUzgn50Lkxho9ezRDXHXxMfi+eYiY1O8piu 7DrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gwVpejRRRIX6iBHQ9uQjh7sUWq7n5QC76X2Ncl9Icms=; b=J4UUb7eM0+Y5WHXaOYb8aojNdlyGpr6g1YlTqKrQCaCv/DLPrRae5LXviK4fYPQtv+ QoB+dBADPSDSovktNoAJT+peXlVr3l1IICoCpFVF9n7iS2k10LLL7W8+vjrEPvKwNQvs M6s6GTeruAflyq9BTXgNHlLFBGkXTMJzBQw2n1MwUocs3IWjVNYms49+5uLZeePMhjTA W0KCGB2tSbStqFdWwxaWlYs+ysyGMqgXPhgpMfcFwUoXcCXZ8aY/L+101OSyLcyoxYNs 9k0PKzRGnhxo5wf6NuSuev4C5760AhvfOCMQO5Poke2eC0RfK2DA+Rh+W9qOboqajrQd dnLQ== X-Gm-Message-State: AOAM532kRFNIHxmnbvacOFOPq81kR8388VqjxYODyCjAu/jcXEyD+h/z b8vVr7VESq5Moc8QblXffwUzni3hv/PyNQ== X-Google-Smtp-Source: ABdhPJzL+kzMgek6BiuhNQ+zLBs/7kB5dKUGH5xwJ99Qr5CA1dDHOmHXAaxKrwDfvmS6yKYiHRZn2w== X-Received: by 2002:a05:6512:c1d:b0:473:bf3f:66b0 with SMTP id z29-20020a0565120c1d00b00473bf3f66b0mr6247222lfu.313.1651927661958; Sat, 07 May 2022 05:47:41 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id x28-20020a19e01c000000b0047255d21138sm1105819lfg.103.2022.05.07.05.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 05:47:41 -0700 (PDT) From: Linus Walleij To: Sekhar Nori , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Arnd Bergmann , Linus Walleij Subject: [PATCH 2/2 v7] ARM: davinci: dm646x: Convert LEDs to GPIO descriptor table Date: Sat, 7 May 2022 14:45:36 +0200 Message-Id: <20220507124536.171930-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220507124536.171930-1-linus.walleij@linaro.org> References: <20220507124536.171930-1-linus.walleij@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220507_054744_059572_E8518E38 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This converts the DaVinci DM646x LEDs to use GPIO descriptor look-ups. Cc: Sekhar Nori Cc: Bartosz Golaszewski Reviewed-by: Bartosz Golaszewski Signed-off-by: Linus Walleij --- ChangeLog v6->v7: - Rebase on v5.18-rc1 ChangeLog v5->v6: - Rebase on v5.14-rc1 ChangeLog v4->v5: - Name each I2C expander instance explicitly as "u2" etc. - Tie the LEDs to the generated "i2c-u2" device name. ChangeLog v3->v4: - Rebase on v5.13-rc1 - Resend - LED maintainers: please apply this patch, it is ACKed by a DaVinci maintainer ChangeLog v2->v3: - Rebase on v5.10-rc1 - Resend ChangeLog v1->v2: - Collect Bartosz' review tag - Rebase on v5.9-rc1 - Resend --- arch/arm/mach-davinci/board-dm646x-evm.c | 34 +++++++++++++++++------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c index ee91d81ebbfd..00c074fddce6 100644 --- a/arch/arm/mach-davinci/board-dm646x-evm.c +++ b/arch/arm/mach-davinci/board-dm646x-evm.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -202,10 +203,10 @@ static struct i2c_driver dm6467evm_cpld_driver = { /* LEDS */ static struct gpio_led evm_leds[] = { - { .name = "DS1", .active_low = 1, }, - { .name = "DS2", .active_low = 1, }, - { .name = "DS3", .active_low = 1, }, - { .name = "DS4", .active_low = 1, }, + { .name = "DS1" }, + { .name = "DS2" }, + { .name = "DS3" }, + { .name = "DS4" }, }; static const struct gpio_led_platform_data evm_led_data = { @@ -213,18 +214,32 @@ static const struct gpio_led_platform_data evm_led_data = { .leds = evm_leds, }; +static struct gpiod_lookup_table evm_leds_gpio_table = { + .dev_id = "leds-gpio.0", + .table = { + /* + * These GPIOs are on a PCF8574a GPIO expander, which + * is in turn named after the I2C device name. This is + * device "u2" on I2C bus 1 with address 0x38. These + * leds are at offset 4, 5, 6, 7. + */ + GPIO_LOOKUP_IDX("i2c-u2", 4, NULL, 0, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("i2c-u2", 5, NULL, 1, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("i2c-u2", 6, NULL, 2, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("i2c-u2", 7, NULL, 3, GPIO_ACTIVE_LOW), + { }, + }, +}; + static struct platform_device *evm_led_dev; static int evm_led_setup(struct i2c_client *client, int gpio, unsigned int ngpio, void *c) { - struct gpio_led *leds = evm_leds; int status; - while (ngpio--) { - leds->gpio = gpio++; - leds++; - } + /* Add the lookup table */ + gpiod_add_lookup_table(&evm_leds_gpio_table); evm_led_dev = platform_device_alloc("leds-gpio", 0); platform_device_add_data(evm_led_dev, &evm_led_data, @@ -438,6 +453,7 @@ static struct i2c_board_info __initdata i2c_info[] = { }, { I2C_BOARD_INFO("pcf8574a", 0x38), + .dev_name = "u2", .platform_data = &pcf_data, }, { -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel