From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 383B4C433F5 for ; Mon, 9 May 2022 15:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ujt++8ewIDTeFb0cCXDVvFMVlZLKRa6uk49nXEsndBw=; b=eXIRDWrYFVpvX/ Ozt1dhbd95ibIAuJb9dWIMKJ+6049cE9ZMZ5esDJfi3cv/Y4mwrz0TReqTFqIvA9vcKctfvanw8yp vA74limT0epPzYLCwWJVYQvNurmr/X2aBxbYm01iZReR+JOIoUfMzwS5LKTarZAaoBY8IOw2cF2+J 5lM33CwfRGG3jiCViwUVPDz45NNh5YJyLfmKImUByfXr/aF05zmj1iJ1F+RbaXpoXEtHjLr2pWt9E K1RIuISn9zQ/W//KiAVEhSNSNkbDmeSzRe+E+Mm1L9yuD3P/xVvUIPO1DV3FMEvN0w0nSIRtUyWrG 90BWj1gBXi1Vb38fL8dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no5Au-00F3uj-CW; Mon, 09 May 2022 15:19:52 +0000 Received: from mail-mw2nam12on20714.outbound.protection.outlook.com ([2a01:111:f400:fe5a::714] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no5Ag-00F3oS-BU for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 15:19:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b4IJHZKfDs52Jckz4JS/0Zpp75mRSxAMrnemKTAfXtwb/vH5pCuXssa4HazAHIE29Lq/qQcEPvtIqJ+p/3Z2ru4+ydJoHp57bd+njH17B3zBXZoNXRhHmgii1Dxky78914PKApSlNcD6ggqexVPpexPN0eKlCz6dGrfOC/sE9tevuvplAwHMnk9K6NvizQUwTpHgc9znPy0EjS1YBwA6ta7K9Flm8HFr8mNfPT3RGxbwtM3WKZBggxqBaUdqBMpFpZLF42pUPV0qd4BmVcnMdAkExd4+gXjGG6hod2EvExILdh8GAkkP3Fg8nbAegfx00cYqFom9JTTbd0Zvj0Vf3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BZeLJnCRNV+NIRfoQkRrxtCvxMud/O3Y+k7ZnZvfUQU=; b=UgEveS2T0A71SHBtlfpOd5Pq8QFe5Yq62LjLTpdOowW9cq4C2+dDjc0NyndEZSYtongzdSpuad30j6//RolaRsswC0UNWo6Nup7tCkTA0B+XCI3vcIWKkEDCuioFoVXRkT+gQzoMIprrxog0CUTZvUIxOzWTWvSFkLpaOdVm1OobLyvoJuWphXGysjoR8uSfeLAy47PrLUGXUznkqOlPVFAF6rF6cE89m+h8dQDbTPfv9HrJ6hqyCGZVEA4/dFXPVECym0YQPE/I119CS9vgzDhUWIcaKd0OFsmOb7ePnhrgsWndRNADR3K68iI9PNjwAkv/t4vSYwCA4YSLb1Bg6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZeLJnCRNV+NIRfoQkRrxtCvxMud/O3Y+k7ZnZvfUQU=; b=gGjKeX1XTZV41dmgqHQQVb5JF7F4RoH1QIQ0qfX4WlhiExS1nlWjCnPxlPcWc158dp4I1HOatVcuoT9Dpc8oUItBLnhroFPIAy9GTE+KsfFfjcUxYoCed73EJPScpT1OLzMoygJx4/i8V6bj19BOYkX4sn2Hb6o3ajd2nBe/S00= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by DM5PR10MB1353.namprd10.prod.outlook.com (2603:10b6:3:9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 15:19:33 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::4581:787c:1a7a:873e]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::4581:787c:1a7a:873e%3]) with mapi id 15.20.5227.020; Mon, 9 May 2022 15:19:32 +0000 Date: Mon, 9 May 2022 15:19:31 -0700 From: Colin Foster To: Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Terry Bowman , Wolfram Sang , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Vladimir Oltean , Lee Jones Subject: Re: [RFC v8 net-next 06/16] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Message-ID: <20220509221931.GA895@COLIN-DESKTOP1.localdomain> References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-7-colin.foster@in-advantage.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e3f68df-3c3e-433d-cbbd-08da31cf5167 X-MS-TrafficTypeDiagnostic: DM5PR10MB1353:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GNBGIkK09lpUwSp7OkV/y1fz92EwAkavUobxWutn1n5FKjycOOPLiiAX+ZCiRpOthfaL7l2E+TnbJeFilCuWLddokA6MixB0MZeK3ai4jUk061ltG0whavT2SHnGK0fA+H6WL50qqZLuqAIdjo+VNHQIC0xugFECa9cwkDVX4MEAi8r7XyrERWa1h/XveBZQYyqaN/N18cBXinRkLHExLo16uH7Ca9skWqcIV9j+urIKABnSrdHRq8uvxKEzuhJJAgychlAYO2LqioI0jUhk7fNQPqpmp+50TGOQgnqpv/oqB2IZlJllX3LMo0sQ3YWyZ3vYXnP8pLX8trmWOEsQ9qIQK0Rd9lqR3dn053Bnbv50he3BYQgwjt6tr8elF4c+T/FAzQ/K2GFmgmGreI9uzexZvXThub6sX9iYlBBX2f1rjhLWHRLQBO30XI+HW8/3oeqLtnukjkLoHWBwdUh+3Eyt0TU+NydYJijCzyRE3TOAyeYg276S+tnTz3cJkRrBBnEQLSCn2UFQ7iMFzpJmw3zzBGNS/MsCExjQ4hXzzIXr9GASkep7lxoceIfTPXGZUBoJLetysByNm9AvTZSV4zT7x3otvUZIh4OvHozQe8yWhEcHAvEsbhYmBnmDL0gE1FKCF1wkd3C0Op1nZhRh4GUPPyiTETT8UenIFj8WrDp6NtTH+TEqxgq+LH9DdUDcPRcTC60PLnAOdznMe5VOzA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(376002)(39830400003)(396003)(346002)(366004)(136003)(508600001)(8936002)(6512007)(8676002)(186003)(9686003)(66556008)(2906002)(33656002)(66946007)(66476007)(52116002)(83380400001)(54906003)(6916009)(86362001)(53546011)(6506007)(316002)(1076003)(5660300002)(44832011)(6486002)(7416002)(26005)(38350700002)(38100700002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X+bxyhRqytagOM3pXL8Bnb0Jkl7izZRVIi10lH1MlXZ/PQN2J++F+M7kLKIc?= =?us-ascii?Q?32Xqu0QilEupG5sOSBq2cJmzGAys2rRKyjOoh21OqY1DHm7XIyGQtcEKrSEC?= =?us-ascii?Q?U+SuB6JeV9NnaqTaCRjhjNPlYbmzk1llR4fQsX9vALqANaJ+B7WeVoBy1MgX?= =?us-ascii?Q?XqfPl7eOUKNCjAPf4/sYor3QEzzVCHJDiLyNDtxHy4y6nCV2y3N+N6wpQ5RB?= =?us-ascii?Q?GY6YMOFeITzhqpt4UHikNf1xfBFi0jdPukBfhi81K1bbzK8UpFfyVtgROwY3?= =?us-ascii?Q?6D2bv2Z7JZ8c8F/PvMO+VGTItmHFw+Q8UvceJOr7P5bVYAU85avWpn0DJyS7?= =?us-ascii?Q?do0qdHrC1guH7hDgWNFRnD3DGT33xl/kJDCXcHr2eHG/Dz4Vt0MftZG3GqBv?= =?us-ascii?Q?ZKTPPDaQEp9MceSvNK7CVi8mFHHtt+m6MBs7dmeMgMtwNMYQGuxGP9Zm27Sx?= =?us-ascii?Q?syYeyhUHU4nJ/Hz6PvvCv2MrgP4IuJSySq+HJuqy93hSH2FGzDbdYSRBL9b+?= =?us-ascii?Q?xcsQ526hMu7zTJ5vrAZ5TofwicBU8cKf9nlkqHG4mJ6j1Fr/+8fvPek0/8CM?= =?us-ascii?Q?lECOvDnzCl9yvdfkU9hUNDDQjELpPIkeFhRIqHKp+mrij9lsTjWHUVVOc8P0?= =?us-ascii?Q?SNWOusKwyBc+EVVPA8ganQUBy7pepQ5bqSxA0aqcI5Sf4zmUywHPjJKkcu+Q?= =?us-ascii?Q?ZhWaTy37MNzgenuhj3BcuhKjLKw+HI8FbYOifo+VnRy70WN2EHUnzIfSw9qF?= =?us-ascii?Q?H5nlgLI511bKjnN+OuTKWye5/+w0hu4FSwD7Vkww/sSoDqO60LOtFmh78CVV?= =?us-ascii?Q?bIaJIX6Keg8juyiAHXP4GbOfcN3rHbzRb5w6RXxHDcaKOvDuC45BNZ5iTsmx?= =?us-ascii?Q?bzm/9hBV0ZyIBqEhC3EZnLEAZcIPDwTumoXx8RtEXDtfYnLJMzYdLAKr3Htd?= =?us-ascii?Q?jYe/FRGjGfk3xU3HeeQTBH8bEKq6EPAPVYVINVk28GQan0mWobxQdEj1l5Xe?= =?us-ascii?Q?rMbGpLXgw3hHRsLBXbCUV/xh6jXRW1zUigp6uk7Ae84efr4/MBIs4Z+b0s2F?= =?us-ascii?Q?ROUsw8iuG/ebJytpu28KAvYEx+B7JbEAxqLschhggONZz+bRb6CGlKnybR6n?= =?us-ascii?Q?We/jWHVLaS/jAwEM9v/1uOls5Z49rELfkFpsiHxCpnB2fOkuVWldsMJ1ae9Z?= =?us-ascii?Q?Lo/YWESFh96qF6NoRbG9oxJRTxvkgWzx33um9kpk6LYpfvwmjd3Hkf8RhDYt?= =?us-ascii?Q?XOOrkxoS7mYtlmS0Q/BUtV0LNl3QhNS6ohP0d+42N7SntgMx3POcs1KbUTma?= =?us-ascii?Q?qbKzb2ZfFJCTOZaCscvFQWrywASozlrM40+0LmxDXMRh+VL3K6z6qBhC+8N0?= =?us-ascii?Q?Ve6aWswK12zAJaNQV/V007WYJhXiMEPEpRxurjPSgWTxS+tALTp1DRAxT97r?= =?us-ascii?Q?DEQdxteEpUrAtsKzr37KJGJT1vn+lTi3hlcERVuMDGDTmA8hU1Z2owg/s+bD?= =?us-ascii?Q?+BW+7mlNgeL9JE/wRHSNFHisrYpjggG7VCT+oOLufs/Ue9GpT+Gc11TCXKbh?= =?us-ascii?Q?LhmrfJIDYfWOgHaiYV1rKTAYGLtU39+PO6A6bZCWnaU4hKQ46cbSuKFwNfY5?= =?us-ascii?Q?oWHfG0GB3GZ4gL/cpxqzhjWRpat666dEzakjaol30EY3Hrty6SBt1DmMr2XE?= =?us-ascii?Q?xvpjcFG/sqVcMdVO1hZnEZ7l+SomnZcEBg7LekMuVzK9fAzKKWgrMuba08kd?= =?us-ascii?Q?t3LqoVsd9kqHebQRysybJMA7Pmce0V8Z9a+ip60AtT0g0XK2JPld?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3f68df-3c3e-433d-cbbd-08da31cf5167 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 15:19:32.3219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aV+AZRPXG2vkBajhT1xs876Wj0wUEqWT/mq+ZU8S+20x/hPmQjERnatcMHvzd7S1pVJe06vQnAxJybORACAMGoYPZTqolOrF00pM/If1qsQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1353 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_081938_642137_43FFB9EC X-CRM114-Status: GOOD ( 22.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, May 09, 2022 at 10:44:42AM +0200, Andy Shevchenko wrote: > On Sun, May 8, 2022 at 8:53 PM Colin Foster > wrote: > > > > There are a few Ocelot chips that can contain SGPIO logic, but can be > > controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In > > the externally controlled configurations these registers are not > > memory-mapped. > > > > Add support for these non-memory-mapped configurations. > > ... > > > - regs = devm_platform_ioremap_resource(pdev, 0); > > - if (IS_ERR(regs)) > > - return PTR_ERR(regs); > > + regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); > > + if (IS_ERR(regs)) { > > + /* > > + * Fall back to using IORESOURCE_REG, which is possible in an > > + * MFD configuration > > + */ > > + res = platform_get_resource(pdev, IORESOURCE_REG, 0); > > + if (!res) { > > + dev_err(dev, "Failed to get resource\n"); > > + return -ENODEV; > > + } > > + > > + priv->regs = ocelot_init_regmap_from_resource(dev, res); > > + } else { > > + priv->regs = devm_regmap_init_mmio(dev, regs, ®map_config); > > + } > > > > - priv->regs = devm_regmap_init_mmio(dev, regs, ®map_config); > > if (IS_ERR(priv->regs)) > > return PTR_ERR(priv->regs); > > This looks like repetition of something you have done in a few > previous patches. Can you avoid code duplication by introducing a > corresponding helper function? That's a good idea. Thanks for the feedback! > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel