From: Sascha Hauer <s.hauer@pengutronix.de>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, "Andy Yan" <andy.yan@rock-chips.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Wed, 11 May 2022 10:21:07 +0200 [thread overview]
Message-ID: <20220511082109.1110043-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20220511082109.1110043-1-s.hauer@pengutronix.de>
The VOP2 driver relies on reg-names properties, but these are not
documented. Add the missing documentation, make reg-names mandatory
and increase minItems to 2 as always both register spaces are needed.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Notes:
Changes since v1:
- Drop minItems
- Add reg-names properties to example
.../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
index 655d9b327f7d3..fba45091d9092 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
@@ -22,7 +22,6 @@ properties:
- rockchip,rk3568-vop
reg:
- minItems: 1
items:
- description:
Must contain one entry corresponding to the base address and length
@@ -31,6 +30,11 @@ properties:
Can optionally contain a second entry corresponding to
the CRTC gamma LUT address.
+ reg-names:
+ items:
+ - const: vop
+ - const: gamma-lut
+
interrupts:
maxItems: 1
description:
@@ -86,6 +90,7 @@ properties:
required:
- compatible
- reg
+ - reg-names
- interrupts
- clocks
- clock-names
@@ -104,6 +109,7 @@ examples:
vop: vop@fe040000 {
compatible = "rockchip,rk3568-vop";
reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>;
+ reg-names = "vop", "gamma-lut";
interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru ACLK_VOP>,
<&cru HCLK_VOP>,
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-11 8:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:21 [PATCH v2 0/3] RK356x VOP2: Change register space names Sascha Hauer
2022-05-11 8:21 ` Sascha Hauer [this message]
2022-05-13 22:26 ` [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Heiko Stuebner
2022-05-17 9:02 ` Krzysztof Kozlowski
2022-05-17 9:10 ` Heiko Stübner
2022-05-16 15:12 ` Rob Herring
2022-05-16 17:08 ` Sascha Hauer
2022-05-11 8:21 ` [PATCH v2 2/3] drm: rockchip: Change register space names Sascha Hauer
2022-05-11 8:21 ` [PATCH v2 3/3] arm64: dts: rockchip: rk356x: Change VOP2 " Sascha Hauer
2022-05-16 22:26 ` (subset) [PATCH v2 0/3] RK356x VOP2: Change " Heiko Stuebner
2022-05-17 18:22 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511082109.1110043-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).