From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FD89C433F5 for ; Thu, 26 May 2022 14:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IK72ak/2xY93NV3GDOYHSJl2LraCqAZzyk1dyMgQkKw=; b=BPK+IWl/OXkYN7 RvjuNorRUWzmpuc5ubEB0CmHLDXQRqJFqiQYNkQt1CVKgddN/C03Ewkv/HLWF+EwGuejhcqzcpNov tpaIRdise4kwPb32W9AHRSkVVsIxpfuX2Y71Va1QM2XmJPEfo7aAUy8hsn04GOqEC7PGHDT29Yaua yab/24Y+iw1s4szPlSki+zTWBzN3rSsHxqk4zXY2pmta1RuLIT2yeYj/bnyQrEPL6ox/+yhhqT1eR oA46nedelMZh8tq3TSCManx3qaYMjK/0fkagRNCMG5Bp/ca/SDv+PuEigtdZfAsGJzpnPS4Nhlmh3 YQaXWYqSOyxSPcn/9wWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuEcB-00F8z4-DX; Thu, 26 May 2022 14:37:27 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuEc7-00F8y0-Id for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 14:37:25 +0000 Received: by mail-ed1-x533.google.com with SMTP id u20so2066035edd.6 for ; Thu, 26 May 2022 07:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NW/L2mpONxggciw8AsbAzWz7p7bM7K4sMkOMScTEkGQ=; b=aVnw/qEXKRYEjrP4Ca8IrQYX54A5B1qs1ZR9okmbKSDwrIp8pAbgY+7dkTGkiTxggX 8SSEgGrpq2T1mbz3XYbd3kj3u8FnEN9UAKISRxVnZP/qFqMYFznZPaZdfDefUp8qGk01 8AgqXCU3+cMR2t1T+WuccCFyIVF/Etm+iF7AQ8Ttodb9FEDjMNhtlt7YY1E0PeN4fZ2F E4qKFDdQQRTV0H8Vgcw0JWQlQbQ285vfbnqISZS2UumkpPLGE0K7GiHx8TSczb68R2Xt Gf5QLjUcZx6m+FgNNwcPyNvlWdHC9To7SrdNvMQoZk4laQ7SPW5ziI3NA1UoIlnXmHAK 1hjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NW/L2mpONxggciw8AsbAzWz7p7bM7K4sMkOMScTEkGQ=; b=NWf5XFnuW+YRVWJ5sAkCHR53PpgA7A0hCvi9jPCpTOCeKMW26AsHrqSjIKR/kbfS2O tTDoLBWc4MrjmfoPII9bsp+61uSrMAY34IXfLEE057Rp0OFP+lbsV1t7YMXGJbVMOiwC x+bJX//Gnzofcariv1M5LkBU0zhZUTYija9UvBrHf/WE9XzdwQNBtbORG2IQynpmhtj0 9WUOejDHSu3SraKKUVusZTR6szOFL5Y6UNkngmczQtgIZxBd5gwHgdjQcKrOGZZoATzH pjAlQasuBjFVa7U1RIhqmDMN4SYN5Y22AvwAh5dH/i/75MgqLklW+GWIANwo3iQxXa9g I4iQ== X-Gm-Message-State: AOAM531G9QOGTR7UxvboX5XMcsCuCjifubAaXjbUMZA46gwkSPQEPCWC XMQrmYfE+h755+HhoqnMeOUQIGu1dT3gS1xU X-Google-Smtp-Source: ABdhPJyi71OtHKHk9p0oVmIUZS2zJCa6U6Xxc4FHaNoYiOfV/dwoHX49Dd2dNEEMnVYc+kCu1Ycj+g== X-Received: by 2002:a05:6402:27cc:b0:42a:64da:64c8 with SMTP id c12-20020a05640227cc00b0042a64da64c8mr27535879ede.196.1653575840758; Thu, 26 May 2022 07:37:20 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id f27-20020a50a6db000000b0042be2dfa8bdsm267962edc.81.2022.05.26.07.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 07:37:19 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 0/7] pinctrl/arm: dt-bindings: deprecate header with register constants Date: Thu, 26 May 2022 16:37:00 +0200 Message-Id: <20220526143707.767490-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_073723_662258_85784D5B X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, The Samsung pin controller drivers were always expecting DTS to use raw register values for pin configuration (e.g. pull up/down, drive strength). DTS had these values hard-coded all over, so at some point we decided for convenience to move them to dt-bindings header. Less code duplication, some meaning added to raw number, etc. However these constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. With minor exceptions, the Linux drivers actually do not use the bindings header at all. Because of this "dt-bindings ID" approach, these constants were re-used between chips, e.g. Exynos ones in S5PV210. These does not make much sense because the values between Exynos and S5PV210 (or S3C24xx) are not related. If it was an abstraction ID, this would be fine. But it's not. Clean this up by: 1. Moving the constants to DTS-local headers. 2. Deprecating the bindings header. Tested by comparing DTBs (dtx_diff, fdtdump). Best regards, Krzysztof Krzysztof Kozlowski (7): ARM: dts: s3c2410: use local header for pinctrl register values ARM: dts: s3c64xx: use local header for pinctrl register values ARM: dts: s5pv210: use local header for pinctrl register values ARM: dts: exynos: use local header for pinctrl register values arm64: dts: exynos: use local header for pinctrl register values arm64: dts: fsd: use local header for pinctrl register values dt-bindings: pinctrl: deprecate header with register constants arch/arm/boot/dts/exynos-pinctrl.h | 55 ++ arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +- arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +- arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 2 +- arch/arm/boot/dts/s3c2410-pinctrl.h | 19 + arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 +- arch/arm/boot/dts/s3c64xx-pinctrl.dtsi | 178 +++---- arch/arm/boot/dts/s3c64xx-pinctrl.h | 27 + arch/arm/boot/dts/s5pv210-aquila.dts | 4 +- arch/arm/boot/dts/s5pv210-aries.dtsi | 134 ++--- arch/arm/boot/dts/s5pv210-fascinate4g.dts | 22 +- arch/arm/boot/dts/s5pv210-galaxys.dts | 34 +- arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 480 +++++++++--------- arch/arm/boot/dts/s5pv210-pinctrl.h | 39 ++ arch/arm64/boot/dts/exynos/exynos-pinctrl.h | 79 +++ .../boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- .../boot/dts/exynos/exynos7-espresso.dts | 6 +- .../boot/dts/exynos/exynos7-pinctrl.dtsi | 72 +-- .../boot/dts/exynos/exynos7885-pinctrl.dtsi | 2 +- .../boot/dts/exynos/exynos850-pinctrl.dtsi | 2 +- .../boot/dts/exynos/exynosautov9-pinctrl.dtsi | 2 +- arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 92 ++-- arch/arm64/boot/dts/tesla/fsd-pinctrl.h | 33 ++ drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +- drivers/pinctrl/samsung/pinctrl-exynos.h | 3 + drivers/pinctrl/samsung/pinctrl-samsung.c | 4 +- drivers/pinctrl/samsung/pinctrl-samsung.h | 8 + include/dt-bindings/pinctrl/samsung.h | 3 + 34 files changed, 813 insertions(+), 550 deletions(-) create mode 100644 arch/arm/boot/dts/exynos-pinctrl.h create mode 100644 arch/arm/boot/dts/s3c2410-pinctrl.h create mode 100644 arch/arm/boot/dts/s3c64xx-pinctrl.h create mode 100644 arch/arm/boot/dts/s5pv210-pinctrl.h create mode 100644 arch/arm64/boot/dts/exynos/exynos-pinctrl.h create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.h -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel