From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EB55C43334 for ; Wed, 15 Jun 2022 13:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uqZuyc8mQeH00j/jCVlSGbgeEC8BBLLjDIB8L6CbKs4=; b=P/m+BIVub6vKCd 6AUGX8Ckd0xD40KK/3PEvWqPe+suF0BxKboI3KtppMuw7oBYFpVw4h4GGoKwDy0QkOrAo1Edblb7l rpRMLNFBlwRJ9m8VzWbDTgDv6z0lNquZLcg6kjkuJnQkU3YOGHSuVwdNnVtqZ453xSmpaYFvSNwfU ULwW3+Wk15RKqD/d4OLphaJ5Zj3tIJQVfg37h78FmxCqy9TS8LV3wKMO4wPHbAUN7dgT8a73PYEnS FHxUwMlRArwXuBtG/G5B+Irq+yI0csv1euo+AFEsi/XxCSz6AExEkQgXbTBC3mOCm8ttsRt2dA5TX YwytHwxevxYTnGEKoShA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1T4V-00EhWQ-UA; Wed, 15 Jun 2022 13:28:36 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1T4S-00EhUt-8i; Wed, 15 Jun 2022 13:28:33 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id F25FC1C0BC8; Wed, 15 Jun 2022 15:28:30 +0200 (CEST) Date: Wed, 15 Jun 2022 15:28:27 +0200 From: Pavel Machek To: Tom Fitzhenry Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Holland , Ondrej Jirman , Martijn Braam , Ondrej Jirman Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Message-ID: <20220615132827.GB1429@bug> References: <20220529031705.278631-1-tom@tom-fitzhenry.me.uk> <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_062832_507099_A90F4A89 X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > + // Per "RK 3399 SARADC", page 8. > + adc-keys { > + compatible = "adc-keys"; > + io-channels = <&saradc 1>; > + io-channel-names = "buttons"; > + keyup-threshold-microvolt = <1600000>; > + poll-interval = <100>; > + > + button-up { > + label = "Volume Up"; > + linux,code = ; > + press-threshold-microvolt = <100000>; > + }; > + > + button-down { > + label = "Volume Down"; > + linux,code = ; > + press-threshold-microvolt = <300000>; > + }; > + }; Wow. Quite a hack... > + // Per "RK3399 GPIO", page 11. > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&red_led_pin &green_led_pin &blue_led_pin>; > + led-standby { + color = ; + default-state = "off"; + function = I wish LED was connected to PWM, not to simple GPIO... Plus, it is really one RGB LED, right? It should be handled as such. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel