From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4343BC43334 for ; Thu, 7 Jul 2022 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ny8NGgOTaOfQVYjx1rJqE6ayVPlAKbvAwUzAQOkmngg=; b=zq1/H8QjkBqonY W+yU1+5cyOyf8Tnj1v3Mf1kqempvG21XYHOAdIuUZwqkoEr1sNSs/NULDChcGVzOfBtYiqGW35ylr +MKImfuYkfr2FzCefK2GUwFyrraGP1dUZ/cJOS4wi0KIlDbBpiFOxp8USpVR++X2swb5uqGdoAHcz r3+CMHg2g8YPzPZJ3ecOPDkkfMndpAZPQkvPEUj4V+TyAk7osDVe7wRq//B+vNXMlocg7OtjYjzq3 HTEq5ytA8z9KBbMeiE08fsZS56WN3Xwu2FskZ/M4gwyXXyhlPTQIabVTuIDijGTyMiapYLZTswuCu yq45dGvAPVdzfMBKBotw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9UV6-00H0ef-6I; Thu, 07 Jul 2022 16:37:12 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9UV1-00H0aS-QS for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2022 16:37:09 +0000 Received: by mail-pg1-x52a.google.com with SMTP id e132so19486745pgc.5 for ; Thu, 07 Jul 2022 09:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tV06X8ZwNG1YBW7qI4+9zEQPn4cces6TNXHqdWyfoC4=; b=kbGamTCBrLg0oYMpjTNMko7htfU0e7BF3RC13JW65s78vOyzbUBDgfcuvDxlAskpL0 4di1UMNwDc9jSx1j6TVrXpaem4bEpE6L9IfQWCoEzjTTb0aE0oawrFPaInrrvOxziQ1y FALtax7m1GT5J1rv7Z6NC1vROJ145ws/dnLm/Ih6unMwnkSpBzjrDTa3YKrPnlhPxJG9 7YGHuMgHV05txyHNaD0HrqgyGa3o1H/uQdl4V89MzBua7O0JgrkGZiKW/iBSwbLD40y4 sSO4mrAtAWbY4pOkXQFM+QNmnO9ykUIN0oLQUz9w/foNqqC2y0Omgu69TZBgL3+4RU09 O1sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tV06X8ZwNG1YBW7qI4+9zEQPn4cces6TNXHqdWyfoC4=; b=Vx5pRciHKSFkTzyzYXbUbBEC1+rMnMzqLLUzBpyKZb9TbB7t6VGwuZ518miut/WGA7 3zBUbfxz79ZqaRkVeI+zHeyTKg0nVmdLxT/7g2Lu7Ff9c94vhu65xzJliN9Ax+r8mxpU RIXsI+eEJyPptxoM5wk0HpVpVUoJqRVXxVDGwQ0kvx1ihFKV2g0FzinFglVZ7+t3UOzP uifv65fJ7DKloeStpErS5DycNQ2OKSXaXNCHN1+lPH3XhXjL81i0GcGuvmAq81v68KS2 bCfUwgPXSrVehhsVzchvjLOCW2ywznAzij2N79TgpqNtH8qEY6u1vdg7Jt4RJyKJ2jut 7Ykg== X-Gm-Message-State: AJIora+s7hhWA2SMS26WamSdZP87NJRqtohyetervJxqwaTZu6nKNWMa fK3s45/aWWeX73HAkQE81hlDFw== X-Google-Smtp-Source: AGRyM1vzAxHVb8A5BM3cUTrB9ok+3+VShZVSqqsL9IGVRhf5PjhVblMcH7rfAoI61MaxE2OBZG+aWg== X-Received: by 2002:aa7:96da:0:b0:525:1752:85b with SMTP id h26-20020aa796da000000b005251752085bmr53522453pfq.63.1657211825312; Thu, 07 Jul 2022 09:37:05 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id f126-20020a623884000000b0052891272298sm6048037pfa.120.2022.07.07.09.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 09:37:03 -0700 (PDT) Date: Thu, 7 Jul 2022 10:37:01 -0600 From: Mathieu Poirier To: Besar Wicaksono Cc: suzuki.poulose@arm.com, robin.murphy@arm.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, sudeep.holla@arm.com, thanu.rangarajan@arm.com, Michael.Williams@arm.com, treding@nvidia.com, jonathanh@nvidia.com, vsethi@nvidia.com, mike.leach@linaro.org, leo.yan@linaro.org Subject: Re: [RESEND PATCH v3 0/2] perf: ARM CoreSight PMU support Message-ID: <20220707163701.GA2616901@p14s> References: <20220621055035.31766-1-bwicaksono@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220621055035.31766-1-bwicaksono@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220707_093707_957637_0A962D53 X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I will look at this patchset next week. Thanks, Mathieu On Tue, Jun 21, 2022 at 12:50:33AM -0500, Besar Wicaksono wrote: > Add driver support for ARM CoreSight PMU device and event attributes for NVIDIA > implementation. The code is based on ARM Coresight PMU architecture and ACPI ARM > Performance Monitoring Unit table (APMT) specification below: > * ARM Coresight PMU: > https://developer.arm.com/documentation/ihi0091/latest > * APMT: https://developer.arm.com/documentation/den0117/latest > > Notes: > * There is a concern on the naming of the PMU device. > Currently the driver is probing "arm-coresight-pmu" device, however the APMT > spec supports different kinds of CoreSight PMU based implementation. So it is > open for discussion if the name can stay or a "generic" name is required. > Please see the following thread: > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-May/740485.html > > The patchset applies on top of > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master next-20220524 > > Changes from v2: > * Driver is now probing "arm-system-pmu" device. > * Change default PMU naming to "arm__pmu". > * Add implementor ops to generate custom name. > Thanks to suzuki.poulose@arm.com for the review comments. > v2: https://lore.kernel.org/all/20220515163044.50055-1-bwicaksono@nvidia.com/ > > Changes from v1: > * Remove CPU arch dependency. > * Remove 32-bit read/write helper function and just use read/writel. > * Add .is_visible into event attribute to filter out cycle counter event. > * Update pmiidr matching. > * Remove read-modify-write on PMCR since the driver only writes to PMCR.E. > * Assign default cycle event outside the 32-bit PMEVTYPER range. > * Rework the active event and used counter tracking. > Thanks to robin.murphy@arm.com for the review comments. > v1: https://lore.kernel.org/all/20220509002810.12412-1-bwicaksono@nvidia.com/ > > Besar Wicaksono (2): > perf: coresight_pmu: Add support for ARM CoreSight PMU driver > perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute > > arch/arm64/configs/defconfig | 1 + > drivers/perf/Kconfig | 2 + > drivers/perf/Makefile | 1 + > drivers/perf/coresight_pmu/Kconfig | 11 + > drivers/perf/coresight_pmu/Makefile | 7 + > .../perf/coresight_pmu/arm_coresight_pmu.c | 1316 +++++++++++++++++ > .../perf/coresight_pmu/arm_coresight_pmu.h | 177 +++ > .../coresight_pmu/arm_coresight_pmu_nvidia.c | 312 ++++ > .../coresight_pmu/arm_coresight_pmu_nvidia.h | 17 + > 9 files changed, 1844 insertions(+) > create mode 100644 drivers/perf/coresight_pmu/Kconfig > create mode 100644 drivers/perf/coresight_pmu/Makefile > create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu.c > create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu.h > create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c > create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.h > > > base-commit: 09ce5091ff971cdbfd67ad84dc561ea27f10d67a > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel