From: kernel test robot <lkp@intel.com>
To: Alistair Francis <alistair@alistair23.me>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, shawnguo@kernel.org,
alistair23@gmail.com, robh+dt@kernel.org,
linus.walleij@linaro.org, s.hauer@pengutronix.de,
andreas@kemnade.info, krzysztof.kozlowski+dt@linaro.org,
rydberg@bitmath.org, dmitry.torokhov@gmail.com,
"Alistair Francis" <alistair@alistair23.me>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Mylène Josserand" <mylene.josserand@bootlin.com>,
"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH v8 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Wed, 3 Aug 2022 15:36:27 +0800 [thread overview]
Message-ID: <202208031503.3PE5bw9a-lkp@intel.com> (raw)
In-Reply-To: <20220802125827.34509-2-alistair@alistair23.me>
Hi Alistair,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on hid/for-next shawnguo/for-next linus/master v5.19 next-20220802]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alistair-Francis/Add-support-for-the-Cypress-cyttsp5/20220802-210032
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: nios2-randconfig-s031-20220803 (https://download.01.org/0day-ci/archive/20220803/202208031503.3PE5bw9a-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/9c372983ef0b8eb7ad48c025a156f80943269af7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Alistair-Francis/Add-support-for-the-Cypress-cyttsp5/20220802-210032
git checkout 9c372983ef0b8eb7ad48c025a156f80943269af7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/input/touchscreen/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/input/touchscreen/cyttsp5.c:602:36: sparse: sparse: incorrect type in initializer (different base types) @@ expected restricted __le16 [usertype] hid_desc_register @@ got int @@
drivers/input/touchscreen/cyttsp5.c:602:36: sparse: expected restricted __le16 [usertype] hid_desc_register
drivers/input/touchscreen/cyttsp5.c:602:36: sparse: got int
vim +602 drivers/input/touchscreen/cyttsp5.c
597
598 static int cyttsp5_get_hid_descriptor(struct cyttsp5 *ts,
599 struct cyttsp5_hid_desc *desc)
600 {
601 struct device *dev = ts->dev;
> 602 __le16 hid_desc_register = HID_DESC_REG;
603 int rc;
604 u8 cmd[2];
605
606 /* Set HID descriptor register */
607 memcpy(cmd, &hid_desc_register, sizeof(hid_desc_register));
608
609 rc = cyttsp5_write(ts, HID_DESC_REG, NULL, 0);
610 if (rc) {
611 dev_err(dev, "Failed to get HID descriptor, rc=%d\n", rc);
612 return rc;
613 }
614
615 rc = wait_for_completion_interruptible_timeout(&ts->cmd_done,
616 msecs_to_jiffies(CY_HID_GET_HID_DESCRIPTOR_TIMEOUT_MS));
617 if (rc <= 0) {
618 dev_err(ts->dev, "HID get descriptor timed out\n");
619 rc = -ETIMEDOUT;
620 return rc;
621 }
622
623 memcpy(desc, ts->response_buf, sizeof(*desc));
624
625 /* Check HID descriptor length and version */
626 if (le16_to_cpu(desc->hid_desc_len) != sizeof(*desc) ||
627 le16_to_cpu(desc->bcd_version) != HID_VERSION) {
628 dev_err(dev, "Unsupported HID version\n");
629 return -ENODEV;
630 }
631
632 return 0;
633 }
634
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-03 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 12:58 [PATCH v8 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2022-08-02 12:58 ` [PATCH v8 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2022-08-03 7:36 ` kernel test robot [this message]
2022-08-06 3:53 ` kernel test robot
2022-08-02 12:58 ` [PATCH v8 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller Alistair Francis
2022-08-02 14:01 ` Rob Herring
2022-08-02 15:10 ` Rob Herring
2022-08-02 12:58 ` [PATCH v8 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2022-08-02 12:58 ` [PATCH v8 4/4] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208031503.3PE5bw9a-lkp@intel.com \
--to=lkp@intel.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mylene.josserand@bootlin.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).