From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B561BC25B08 for ; Sat, 13 Aug 2022 09:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S2xElRCfUq6VVXAZp0sDGTzPO0QqzBHoAccDXMNJuO0=; b=XBwBYwUDh5huqW Q2GDf8t/r8QxtUP3NAtSYQ8Bm6h1i5t5e14Mb6UVUlAtms6veNNjbCQYbWfQW1KI6VL7TRvSILYXu UzAiqAfbe8SRfjTsDz6hpb10WDo2XGSB6mC9vCb9B/7l6bkKoP3DI8jqQo1h7tlggGkRbgyZurGuJ Kyj5Y7UTyDVTuueuEGyfkssyo/mCgiQl4VZusiED5GtHWImqTG/yFxeZ2n4be864022mEAkn2rXwK LOvI4gjzdstJ4unUKhYsC5YOKdPTjyF5kLzJrdMEPZQSRGbrGJ9FrCVUKpNT2+RJ1W9dRIqxQzr6X CShDuK/hH8vsF4TnyWHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMnpg-00DhMN-0V; Sat, 13 Aug 2022 09:53:28 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMnpc-00DhK6-6a for linux-arm-kernel@lists.infradead.org; Sat, 13 Aug 2022 09:53:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660384404; x=1691920404; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OamMQmkw1kw/qgC1ToQfGGYK5wCJuB1mv86EUB851PE=; b=grbqy4dEl3OTsAYGzf35JTS5KGFPFlgYyFCm5maP4LUtHeO7tkal/nSK SQVd+M7ScXp5ZiTk5tL5OOH7tTi0Bsg4HT4mJQr5ewU9WSm489FVvag87 ZVJOQTfXOWlWWjm+Xhb7SermqNy2f+54jhksbtBrAeuGKsWqgexvpr4jR 5o+0gTavef+r2tV3wnHLizThcSZS5YCxcMMs/EEJuLIJnPkaISqj3x3PZ zrQFzyJeCacmnSIDP6cfwEaMrKBHu+UEr2AEKaOHzDFXev8NhHnym+pb4 L06i6aBzpHdvpVpSWgZu0udsy/ITbULx6id60ET7xeMdoZLqQMJ/SE3Pf g==; X-IronPort-AV: E=McAfee;i="6400,9594,10437"; a="274797012" X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="274797012" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2022 02:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="582354751" Received: from lkp-server02.sh.intel.com (HELO 8745164cafc7) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 13 Aug 2022 02:53:14 -0700 Received: from kbuild by 8745164cafc7 with local (Exim 4.96) (envelope-from ) id 1oMnpR-0001Xd-36; Sat, 13 Aug 2022 09:53:13 +0000 Date: Sat, 13 Aug 2022 17:53:01 +0800 From: kernel test robot To: Mike Leach , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com, Mike Leach Subject: Re: [PATCH v3 05/13] coresight: etm3x: Update ETM3 driver to use Trace ID API Message-ID: <202208131723.4WupJz5f-lkp@intel.com> References: <20220809223401.24599-6-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220809223401.24599-6-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220813_025324_308508_8856CC58 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, I love your patch! Perhaps something to improve: [auto build test WARNING on acme/perf/core] [also build test WARNING on tip/perf/core atorgue-stm32/stm32-next linus/master v5.19 next-20220812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Leach/coresight-Add-new-API-to-allocate-trace-source-ID-values/20220810-063940 base: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220813/202208131723.4WupJz5f-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/48c9bb1ba00758132c4523dba423071440723ccd git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mike-Leach/coresight-Add-new-API-to-allocate-trace-source-ID-values/20220810-063940 git checkout 48c9bb1ba00758132c4523dba423071440723ccd # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/hwtracing/coresight/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hwtracing/coresight/coresight-etm3x-core.c:509:44: warning: 'struct etmv4_drvdata' declared inside parameter list will not be visible outside of this definition or declaration 509 | static int etm_set_current_trace_id(struct etmv4_drvdata *drvdata) | ^~~~~~~~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c: In function 'etm_set_current_trace_id': drivers/hwtracing/coresight/coresight-etm3x-core.c:517:58: error: invalid use of undefined type 'struct etmv4_drvdata' 517 | trace_id = coresight_trace_id_read_cpu_id(drvdata->cpu); | ^~ drivers/hwtracing/coresight/coresight-etm3x-core.c:519:24: error: invalid use of undefined type 'struct etmv4_drvdata' 519 | drvdata->traceid = (u8)trace_id; | ^~ In file included from include/linux/device.h:15, from drivers/hwtracing/coresight/coresight-etm3x-core.c:12: drivers/hwtracing/coresight/coresight-etm3x-core.c:523:25: error: invalid use of undefined type 'struct etmv4_drvdata' 523 | dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on CPU%d\n", | ^~ include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ drivers/hwtracing/coresight/coresight-etm3x-core.c:523:9: note: in expansion of macro 'dev_err' 523 | dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on CPU%d\n", | ^~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c:524:34: error: invalid use of undefined type 'struct etmv4_drvdata' 524 | dev_name(&drvdata->csdev->dev), drvdata->cpu); | ^~ include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c:523:9: note: in expansion of macro 'dev_err' 523 | dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on CPU%d\n", | ^~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c:524:56: error: invalid use of undefined type 'struct etmv4_drvdata' 524 | dev_name(&drvdata->csdev->dev), drvdata->cpu); | ^~ include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c:523:9: note: in expansion of macro 'dev_err' 523 | dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on CPU%d\n", | ^~~~~~~ drivers/hwtracing/coresight/coresight-etm3x-core.c: In function 'etm_enable_perf': drivers/hwtracing/coresight/coresight-etm3x-core.c:547:40: error: passing argument 1 of 'etm_set_current_trace_id' from incompatible pointer type [-Werror=incompatible-pointer-types] 547 | ret = etm_set_current_trace_id(drvdata); | ^~~~~~~ | | | struct etm_drvdata * drivers/hwtracing/coresight/coresight-etm3x-core.c:509:59: note: expected 'struct etmv4_drvdata *' but argument is of type 'struct etm_drvdata *' 509 | static int etm_set_current_trace_id(struct etmv4_drvdata *drvdata) | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ cc1: some warnings being treated as errors vim +509 drivers/hwtracing/coresight/coresight-etm3x-core.c 508 > 509 static int etm_set_current_trace_id(struct etmv4_drvdata *drvdata) 510 { 511 int trace_id; 512 513 /* 514 * Set the currently allocated trace ID - perf allocates IDs 515 * as part of setup_aux for all CPUs it may use. 516 */ 517 trace_id = coresight_trace_id_read_cpu_id(drvdata->cpu); 518 if (IS_VALID_ID(trace_id)) { 519 drvdata->traceid = (u8)trace_id; 520 return 0; 521 } 522 523 dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on CPU%d\n", 524 dev_name(&drvdata->csdev->dev), drvdata->cpu); 525 526 return -EINVAL; 527 } 528 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel