From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 777DFECAAA1 for ; Thu, 25 Aug 2022 21:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5yYz1Ic9wvpSPJpoewkFCjzCISqIei8gPIuhKA5gNus=; b=F2E6+pz4VOqLoB GGVRuh3u0a1/Crt1tSf9Xfx64lCcXdNja4ab+S9YoiQ7ALmb57faCf0jAVB1bCI/9nZiF+cvbKynX w5chWa4NkUQJUSLGeOLKch9wP5JsAQHwxkuNP+l9EJ6NHdVrekPvvEwPllOcSl8Tc0c04BPPSWZbX q1jLY/i0M3pgkQ3g554JkIF/Wn/qRKV8QQRnBL8qMtPHPd+t6TRum4Z/JfhSGN4B2B9OzEd/E0krp Rf9Y7MVFs4RZfKGUFTWTQQuqSsVfc+dEeIQ25ajIcK9yOklbDuwLF3pkVGWTXKxjBvyxzbXzgolo/ 15rCAokWex1YBcjnMVfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRK0J-003JDy-HS; Thu, 25 Aug 2022 21:03:07 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRK0F-003J75-RW for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 21:03:05 +0000 Received: by mail-ot1-f45.google.com with SMTP id l5-20020a05683004a500b0063707ff8244so14740797otd.12 for ; Thu, 25 Aug 2022 14:02:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=zlDgSVi6ybm28ADf/l4jQxot81q6KSDv8EU/4KXm+fU=; b=FX96Wr6eSovOsa/Q61f0tGy9UGLSPM2TwUMXNCJVWx6ZTX6J4ssaNPqjwkZWsYsqWF YXQ+er2UCtPcoA57bLr843WMD6g1b0WTwNsm3/unTS2AlqygDbm4+rIn4jU5iCObH+Ka O+LirgbK21iBJL8rbY5gf2bR9FChKR6obip96ozgZnhvv8609nxpDcbGXsRAD4z+v9So aXtIrpUabio1HQgJFCgVzbfrACPt8pTS5c19tmgy6WvNHroLajFPWuoS3ohN+9K5uTr0 XLrcxx0a8anon9VwsCHGC1/5Uj2iu92hxO/YZcJ6Dmc8dXkNz7/KaUZYgexulr3MvaXL 2U5Q== X-Gm-Message-State: ACgBeo2aFaTiictadVayuJn6MlP0d0ailVVkVGwbyexXPPbwLFKNCL+G IdReIfr2Px2x6NNUNKKnRQ== X-Google-Smtp-Source: AA6agR6Vlp9ebEknuUxzZiq3qwYENpFauxFBuzd6t2b++gnkgaGivXI0o6LrZdEEH5fh0PFr5laTyg== X-Received: by 2002:a9d:748a:0:b0:637:1cf2:c8c4 with SMTP id t10-20020a9d748a000000b006371cf2c8c4mr338370otk.274.1661461373789; Thu, 25 Aug 2022 14:02:53 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id t5-20020a4ab585000000b00448aff53822sm142942ooo.40.2022.08.25.14.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:02:53 -0700 (PDT) Received: (nullmailer pid 1682027 invoked by uid 1000); Thu, 25 Aug 2022 21:02:52 -0000 Date: Thu, 25 Aug 2022 16:02:52 -0500 From: Rob Herring To: Samuel Holland Cc: Srinivas Kandagatla , Chen-Yu Tsai , Jernej Skrabec , Greg Kroah-Hartman , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/4] dt-bindings: nvmem: Allow bit offsets greater than a byte Message-ID: <20220825210252.GA1671168-robh@kernel.org> References: <20220814173656.11856-1-samuel@sholland.org> <20220814173656.11856-4-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220814173656.11856-4-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_140303_913933_3AA971E4 X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 14, 2022 at 12:36:54PM -0500, Samuel Holland wrote: > Some NVMEM devices contain cells which do not start at a multiple of the > device's stride. However, the "reg" property of a cell must be aligned > to its provider device's stride. How is a DT author supposed to know this? I would lean toward it's the OS's problem to deal with (your option 1 I guess). I worry that one client could expect it one way and another client the other. Or folks making DT changes to 'fix' things. > > These cells can be represented in the DT using the "bits" property if > that property allows offsets up to the full stride. 63 is chosen > assuming that NVMEM devices will not have strides larger than 8 bytes. > > Signed-off-by: Samuel Holland > --- > > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > index 3bb349c634cb..4f440ab6a13c 100644 > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml > @@ -53,7 +53,7 @@ patternProperties: > $ref: /schemas/types.yaml#/definitions/uint32-array > items: > - minimum: 0 > - maximum: 7 > + maximum: 63 > description: > Offset in bit within the address range specified by reg. > - minimum: 1 > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel